samba-mirror

mirror of https://github.com/samba-team/samba.git synced 2025-01-22 22:04:08 +03:00

History

Noel Power eed4dfe3a4 libcli/smb: Fix failure of Smb3UnixTests.test_create_context_reparse

On tumbleweed at least the definition in py_reparse_put of 'reserved' as
'unsigned' causes the tag value to be overwritten. Note: ParseTuple is
given a format of 'Kk' where
  K = unsigned long long (for tag)
  k = unsigned long      (for reserved)

The problem is 'reserved' is defined as 'unsigned' which on a
64 bit linux system has size 4. The size however of the 'unsigned long' type
on the same 64 bit system is 8. This causes 'tag' to be overwritten by
the value of 'reserved' because it's destination size is smaller than
expected.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15702
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Aug 28 18:38:01 UTC 2024 on atb-devel-224

Autobuild-User(v4-21-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-21-test): Thu Aug 29 13:10:29 UTC 2024 on atb-devel-224

2024-08-29 13:10:29 +00:00

auth

libcli/auth: fix debug level 100 valgrind warnings in SMBOWFencrypt_ntv2()

2024-07-17 10:12:36 +00:00

cldap

libcli: Don’t call memcpy() with a NULL pointer

2023-05-29 22:32:28 +00:00

dns

libcli: Add missing newlines to logging messages

2023-08-08 04:39:36 +00:00

drsuapi

libcli:drsuapi: Fix code spelling