1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
samba-mirror/source3/modules
Jeremy Allison bed323cebc s3 : smbd : Protect all possible code paths from fsp->op == NULL.
In changes to come this will be possible for an INTERNAL_OPEN_ONLY.
The protection was already in place for some code paths, this
makes the coverage compete.

Bug 10564 - Lock order violation and file lost

https://bugzilla.samba.org/show_bug.cgi?id=10564

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
2014-05-02 21:27:07 +02:00
..
developer.c
getdate.c
getdate.h Introduce system MIT krb5 build with --with-system-mitkrb5 option. 2012-05-23 17:51:50 +03:00
getdate.y
gpfs.c s3: Avoid oplock break by storing timestamps with gpfs_set_times 2014-01-09 00:04:47 +01:00
nfs4_acls.c vfs: Support NFS control flags in nfs4_acls.c. 2014-04-05 00:50:14 +02:00
nfs4_acls.h vfs: Support NFS control flags in nfs4_acls.c. 2014-04-05 00:50:14 +02:00
non_posix_acls.c vfs: Convert non_posix_sys_acl_blob_get_file_helper to synthetic_smb_fname 2013-04-17 14:49:59 -07:00
non_posix_acls.h vfs: Add helper function for non posix ACL modules 2013-02-04 12:19:30 +01:00
perfcount_test.c Rename module init functions from samba_init_module 2014-04-02 08:50:03 +02:00
README-gpfs-acl.txt
README.nfs4acls.txt s3: Update README.nfs4acls.txt 2013-05-09 06:18:21 +02:00
vfs_acl_common.c vfs_acl_common: Do not fetch the underlying NT ACL unless we need it 2013-02-04 12:19:30 +01:00
vfs_acl_tdb.c dbwrap: add a dbwrap_flags argument to db_open() 2014-02-07 16:06:06 +01:00
vfs_acl_xattr.c Fix the overwriting of errno before use in a DEBUG statement and use the return value from store_acl_blob_fsp rather than ignoring it. 2012-05-16 03:43:40 +02:00
vfs_afsacl.c s3:modules: vfs_afsacl has the afs_syscall prototype via proto.h 2013-09-23 20:55:29 +02:00
vfs_aio_fork.c s3-vfs: Don't leak file descriptor. 2013-02-22 16:36:13 +01:00
vfs_aio_linux.c s3:modules: s/struct fd_event/struct tevent_fd 2013-02-19 23:47:59 +01:00
vfs_aio_posix.c s3: Add aio_fsync to the aio_posix module 2012-07-18 15:51:43 -07:00
vfs_aio_pthread.c pthreadpool: Allow multiple jobs to be received 2014-03-27 06:06:11 +01:00
vfs_aixacl2.c s3:modules/vfs_aixacl2 fix compile errors 2013-05-09 06:18:21 +02:00
vfs_aixacl_util.c smbd: Add mem_ctx to sys_acl_init() and all callers 2012-10-11 12:25:11 +11:00
vfs_aixacl_util.h smbd: Add mem_ctx to sys_acl_init() and all callers 2012-10-11 12:25:11 +11:00
vfs_aixacl.c vfs: Fix alternative posix and no-op sys acl implementations to take a mem_ctx 2012-10-11 14:45:03 +11:00
vfs_audit.c build: Remove SMB_STRUCT_DIR define 2012-04-05 02:39:09 +02:00
vfs_btrfs.c s3 : smbd : Protect all possible code paths from fsp->op == NULL. 2014-05-02 21:27:07 +02:00
vfs_cacheprime.c build: Remove SMB_OFF_T, replace with off_t 2012-04-06 01:47:43 +02:00
vfs_cap.c vfs: Convert cap_ntimes to cp_smb_filename 2013-04-17 14:49:56 -07:00
vfs_catia.c vfs_catia: add chmod() 2014-03-11 13:39:17 +01:00
vfs_ceph.c Fix warnings and one compile error caused by newer gcc 4.7. 2013-05-05 19:01:37 +02:00
vfs_commit.c smbd: Fix bug 9544, part 2 2013-01-15 00:55:51 +01:00
vfs_crossrename.c s3-vfs: Don't leak file descriptor on error. 2013-02-22 16:36:14 +01:00
vfs_default_quota.c vfs: Make function pointer names consistent. They all end in _fn 2011-12-12 04:58:40 +01:00
vfs_default.c s3 : smbd : Protect all possible code paths from fsp->op == NULL. 2014-05-02 21:27:07 +02:00
vfs_dfs_samba4.c loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *. 2012-07-18 15:07:23 +09:30
vfs_dirsort.c s3: vfs_dirsort module. 2014-02-12 12:37:03 +13:00
vfs_expand_msdfs.c loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *. 2012-07-18 15:07:23 +09:30
vfs_extd_audit.c build: Remove SMB_STRUCT_DIR define 2012-04-05 02:39:09 +02:00
vfs_fake_acls.c vfs: Convert fake_acls_sys_acl_delete_def_file to synthetic_smb_fname 2013-04-17 14:49:58 -07:00
vfs_fake_perms.c vfs_fake_perms: Fix bug 9775, segfault for "artificial" conn_structs 2013-04-10 00:12:06 +02:00
vfs_fileid.c loadparm: make the source3/ lp_ functions take an explicit TALLOC_CTX *. 2012-07-18 15:07:23 +09:30
vfs_full_audit.c vfs: add [GET/SET]_COMPRESSION hooks 2013-11-22 08:56:45 -08:00
vfs_glusterfs.c vfs_glusterfs: Remove "integer fd" code and store the glfs pointers. 2014-02-25 12:27:51 -08:00
vfs_gpfs.c vfs_gpfs: Avoid warnings in developer build 2014-04-18 22:25:25 +02:00
vfs_gpfs.h s3: Avoid oplock break by storing timestamps with gpfs_set_times 2014-01-09 00:04:47 +01:00
vfs_hpuxacl.c vfs: Convert hpuxacl_sys_acl_set_file to synthetic_smb_fname 2013-04-17 14:49:57 -07:00
vfs_hpuxacl.h
vfs_linux_xfs_sgid.c vfs: Make function pointer names consistent. They all end in _fn 2011-12-12 04:58:40 +01:00
vfs_media_harmony.c param: rename lp function and variable from "fake_dir_create_times" to "fake_directory_create_times" 2014-02-07 16:19:13 -08:00
vfs_netatalk.c In vfs modules, don't use 'conn->origpath' when we really mean 'conn->cwd'. 2012-09-12 23:45:22 +02:00
vfs_nfs4acl_xattr.c vfs: Add inheritance emulation to vfs_nfs4acl_xattr. 2013-05-09 06:18:21 +02:00
vfs_notify_fam.c s3:modules: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_ 2013-02-19 23:48:00 +01:00
vfs_posix_eadb.c tdb_wrap: Remove tdb_wrap_open_ again 2014-03-31 22:52:14 +02:00
vfs_posixacl.c vfs: Use posix_sys_acl_blob_get_file in vfs_posixacl for posix ACLs 2012-10-11 12:25:13 +11:00
vfs_posixacl.h smbd: Add mem_ctx to sys_acl_init() and all callers 2012-10-11 12:25:11 +11:00
vfs_prealloc.c Check error returns on strnorm(). 2012-08-09 12:07:32 -07:00
vfs_preopen.c s3:modules: s/event_add_fd/tevent_add_fd and s/EVENT_FD_/TEVENT_FD_ 2013-02-19 23:48:00 +01:00
vfs_readahead.c build: Remove SMB_OFF_T, replace with off_t 2012-04-06 01:47:43 +02:00
vfs_readonly.c Add uint32_t share_access to vuid_cache_entry. 2013-01-09 15:28:48 +11:00
vfs_recycle.c vfs: Convert recycle_unlink to synthetic_smb_fname 2013-04-17 14:49:58 -07:00
vfs_scannedonly.c scannedonly: Fix CID 242109 Unchecked return value from library 2013-12-17 01:57:12 +01:00
vfs_shadow_copy2.c shadow_copy2: Fix some typos 2013-12-12 17:58:24 +01:00
vfs_shadow_copy.c build: Remove SMB_STRUCT_DIR define 2012-04-05 02:39:09 +02:00
vfs_smb_traffic_analyzer.c vfs_smb_traffic_analyzer: Cast mode_t to unsigned int for GNU/Solaris build 2013-03-15 10:38:58 -07:00
vfs_smb_traffic_analyzer.h
vfs_solarisacl.c vfs: Fix compilation of solaris ACL module 2013-01-10 18:46:22 +11:00
vfs_solarisacl.h vfs: Fix compilation of ACL support on solaris 2012-10-23 09:29:18 +02:00
vfs_streams_depot.c s3: modules: streaminfo: As we have no VFS function SMB_VFS_LLISTXATTR we can't cope with a symlink when lp_posix_pathnames() is true. 2014-02-08 00:01:16 +01:00
vfs_streams_xattr.c s3: modules: streaminfo: As we have no VFS function SMB_VFS_LLISTXATTR we can't cope with a symlink when lp_posix_pathnames() is true. 2014-02-08 00:01:16 +01:00
vfs_syncops.c vfs: Make function pointer names consistent. They all end in _fn 2011-12-12 04:58:40 +01:00
vfs_time_audit.c vfs_time_audit: Make durable functions static 2014-01-24 13:42:38 -08:00
vfs_tru64acl.c vfs: Use posix_sys_acl_blob_get_file in vfs_tru64acl for posix ACLs 2012-10-11 12:25:13 +11:00
vfs_tru64acl.h
vfs_tsmsm.c s3:vfs_tsmsm only send notifications when file was offline before 2012-08-17 20:05:30 +02:00
vfs_worm.c s3-modules: add new vfs_worm module 2013-12-12 12:50:21 -08:00
vfs_xattr_tdb.c dbwrap: add a dbwrap_flags argument to db_open() 2014-02-07 16:06:06 +01:00
vfs_zfsacl.c vfs: Allow CREATOR GROUP to be used with vfs_zfsacl 2013-05-09 06:18:21 +02:00
wscript_build s3:modules: explicitly use allow_warnings=True were needed 2014-04-02 09:03:46 +02:00

Configuring NFS4 ACLs in Samba3
===============================
Created: Peter Somogyi, 2006-JUN-06
Last modified: Alexander Werth, 2013-MAY-02
Revision no.: 4 
-------------------------------


Parameters in smb.conf:
=======================

Each parameter must have a prefix "nfs4:".
Each one affects the behaviour only when _setting_ an acl on a file/dir:

mode = [simple|special]
- simple: Use OWNER@ and GROUP@ special IDs for non inheriting ACEs only.
  This mode is the default.
- special: use OWNER@ and GROUP@ special IDs in ACEs instead of simple
  user&group ids. This mode is deprecated.

Note1: EVERYONE@ is always processed (if found such an ACE).
Note2: There is a side effect when _only_ chown is performed.
       Later this may be worked out.
Note3: Mode special inherits incorrect ACL entries when the user creating
       a file is different from the owner of the caurrent folder.
Note4: Mode simple uses inheriting OWNER@ and GROUP@ special IDs to
       support Creator Owner and Creator Group.

It's strongly advised to set "store dos attributes = yes" in smb.conf.

chown = [true|false]
- true => enable changing owner and group - default.
- false => disable support for changing owner or group

acedup = [dontcare|reject|ignore|merge]
- dontcare: copy ACEs as they come, don't care with "duplicate" records. Default.
- reject: stop operation, exit acl setter operation with an error
- ignore: don't include the second matching ACE
- merge: OR 2 ace.flag fields and 2 ace.mask fields of the 2 duplicate ACEs into 1 ACE

Two ACEs are considered here "duplicate" when their type and id fields are matching.

Example:

[smbtest]
path = /tests/psomogyi/smbtest
writable = yes
vfs objects = aixacl2
nfs4: mode = special
nfs4: chown = yes
nfs4: acedup = merge

Configuring AIX ACL support
==============================

Binaries: (default install path is [samba]/lib/vfs/)
- aixacl.so: provides AIXC ACL support only, can be compiled and works on all AIX platforms
- aixacl2.so: provides AIXC and JFS2-NFS4 ACL support, can be compiled and works only under AIX 5.3 and newer.
NFS4 acl currently has support only under JFS2 (ext. attr. format must be set to v2).
aixacl2.so always detects support for NFS4 acls and redirects to POSIX ACL handling automatically when NFS4 is not supported for a path.

Adding "vfs objects = aixacl2" to a share should be done only in case when NFS4 is really supported by the filesystem.
(Otherwise you may get performance loss.)

For configuration see also the example above.

General notes
=============

NFS4 handling logic is separated from AIX/jfs2 ACL parsing.

Samba and its VFS modules dosn't reorder ACEs. Windows clients do that (and the smbcacl tool). MSDN also says deny ACEs must come first.
NFS4 ACL's validity is checked by the system API, not by Samba.
NFS4 ACL rights are enforced by the OS or filesystem, not by Samba.

The flag INHERITED_ACE is never set (not required, as doesn't do WinNT/98/me, only since Win2k).
Win2k GUI behaves strangely when detecting inheritance (sometimes it doesn't detect, 
but after adding an ace it shows that - it's some GUI error).

Unknown (unmappable) SIDs are not accepted.

TODOs
=====
- Creator Owner & Group SID handling (same way as posix)
- the 4 generic rights bits support (GENERIC_RIGHT_READ_ACCESS, WRITE, EXEC, ALL)
- chown & no ACL, but we have ONWER@ and GROUP@
- DIALUP, ANONYMOUS, ... builtin SIDs
- audit & alarm support - in theory it's forwarded so it should work, but currently there's no platform which supports them to test
- support for a real NFS4 client (we don't have an accepted API yet)