mirror of
https://github.com/samba-team/samba.git
synced 2025-01-25 06:04:04 +03:00
c2422593f4
For the clone-only case, we have been avoiding a block of code in the DCJoinContext's __init__(). The main reason we do this is because the netbios_name is None for clones, and this block of code tries to derive a bunch of values based on the netbios_name (otherwise, a few lines into this block, it tries to do NoneType.lower(), which Python doesn't like very much). This code is not particularly clone-specific - it is just never going to work if the netbios_name is None. So we can change the conditional check, which allows us to get rid of the clone_only flag. Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz> Autobuild-User(master): Gary Lockyer <gary@samba.org> Autobuild-Date(master): Tue Jul 3 08:12:10 CEST 2018 on sn-devel-144