1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/libcli
Douglas Bagnall c73034cf7c librpc/security.idl: adjust size calculations for upcoming ace types
Soon we will get Conditional ACEs and Resource Attribute ACES, each of
which have trailing bytes at the end of the ACE. Here's a diagram:

              ____      The ACE size field may indicate a size bigger
  .type      /    |     than the known parts, even when you take
  .flags    /     |     rounding to a multiple of four into account.
  .size  --'      |     This extra data is meaningful in some ACEs.
  .access_mask    |
  .trustee (sid) _|  <- known data ends here.
                  :
   "coda"      ___:  <- the trailing part, Zero size unless the size
                        field points beyond the end of the known data.
			Probably empty for ordinary ACE types.

Until now we have thrown away these extra bytes, because they have no
meaning in the ACE types we recognise. But with conditional and
resource attribute ACEs we need to catch and process these bytes, so
we add an extra field for that.

Thus we can drop the manually written ndr_pull_security_ace() that
discarded the trailing bytes, because we just allow it to be pulled
into an unused blob. In the very common case, the blob will be empty.

Microsoft does not use a common name across different ACE types to
describe this end-data -- "coda" is a Samba term.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-08-24 02:53:31 +00:00
..
auth libcli/auth: Remove unnecessary casts 2023-08-21 23:37:29 +00:00
cldap libcli: Don’t call memcpy() with a NULL pointer 2023-05-29 22:32:28 +00:00
dns libcli: Add missing newlines to logging messages 2023-08-08 04:39:36 +00:00
drsuapi libcli:drsuapi: Fix code spelling 2023-04-27 14:25:38 +00:00
echo s4: torture: Change torture_register_suite() to add a TALLOC_CTX *. 2017-05-05 15:52:11 +02:00
http libcli: Add missing newlines to logging messages 2023-08-08 04:39:36 +00:00
ldap libcli/ldap: Don’t try to encode NULL name 2023-08-08 04:39:37 +00:00
lsarpc libcli/lsarpc: add struct trustAuthInOutBlob; forward declaration 2014-04-02 09:03:42 +02:00
named_pipe_auth libcli: Add missing newlines to logging messages 2023-08-08 04:39:36 +00:00
nbt librpc/nbt: Avoid reading invalid member of union 2023-07-07 01:14:06 +00:00
netlogon libcli: Covscan: unchecked return value for file_save() 2022-05-14 03:49:32 +00:00
registry build: Make util_reg subsystem in libcli/registry a library 2011-05-18 16:12:08 +02:00
samsync smbdes: convert sam_rid_crypt() to use gnutls 2019-12-10 00:30:30 +00:00
security librpc/security.idl: adjust size calculations for upcoming ace types 2023-08-24 02:53:31 +00:00
smb libcli: Add required #includes to smbXcli_base.h 2023-08-22 16:45:31 +00:00
smbreadline libcli:smbreadline: Fix code spelling 2023-06-23 13:44:31 +00:00
util s4/scripting/bin: Add NT_STATUS_OK to list of definitions 2023-06-14 22:57:35 +00:00