sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-02-04 17:47:26 +03:00
Code
samba-mirror/lib/util
History
Martin Schwenke a2590298b0 util: CID 1499409: Memory - corruptions (OVERLAPPING_COPY) 
This is quite bizarre:

*** CID 1499409:  Memory - corruptions  (OVERLAPPING_COPY)
/lib/util/debug.c: 1742 in dbghdrclass()
1736     					 sizeof(tvbuf.buf),
1737     					 "%ld seconds since the Epoch", (long)t);
1738     			}
1739     		}
1740
1741     		ensure_hostname();
>>>     CID 1499409:  Memory - corruptions  (OVERLAPPING_COPY)
>>>     In the call to function "snprintf", the object pointed to by argument "state.hostname" may overlap with the object pointed to by argument "state.header_str".
1742     		state.hs_len = snprintf(state.header_str,
1743     					sizeof(state.header_str),
1744     					"%s %s %s[%u]: ",
1745     					tvbuf.buf,
1746     					state.hostname,
1747     					state.prog_name,

Coverity doesn't explicitly say so but the only way this can happen is
if state.hostname is not NUL-terminated within its declared length.
ensure_hostname() and debug_set_hostname() ensure NUL-termination, but
the caching effect of ensure_hostname() probably stops Coverity from
being certain about anything.

Try making Coverity happy by using a precision to limit the number of
characters from hostname that can be used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Feb 22 00:17:12 UTC 2022 on sn-devel-184
2022-02-22 00:17:11 +00:00
..
charset
charset_macosxfs.c: fix compilation on macOS
2021-10-13 01:42:35 +00:00
tests
lib: add a test for null_nttime(NTTIME_THAW)
2021-10-28 18:11:28 +00:00
access.c
lib:util: Remove NIS support from string_match()
2021-04-22 17:57:30 +00:00
access.h
lib: util: Add allow_access_nolog().
2016-11-16 12:41:09 +01:00
asn1.c
asn1: Remove unused function asn1_check_enumerated()
2021-04-01 17:50:49 +00:00
asn1.h
asn1: Remove unused function asn1_check_enumerated()
2021-04-01 17:50:49 +00:00
attr.h
replace, attr.: use function attributes only if supported by feature macro (or old gcc)
2020-05-24 23:55:36 +00:00
base64.c
lib: Avoid includes.h in base64.c
2016-05-04 01:28:23 +02:00
base64.h
lib: Give base64.c its own .h
2016-05-04 01:28:23 +02:00
become_daemon.c
lib:util: Fix log level for normal startup message
2021-05-20 15:07:28 +00:00
become_daemon.h
lib: Remove close_low_fds()
2021-04-27 13:24:35 +00:00
binsearch.h
binsearch.h: Re-licence under LGPLv3 per agreement of the copyright holders
2017-09-22 21:20:23 +02:00
bitmap.c
lib:util: Fix undefined behavior in bitmap.c
2018-11-22 22:13:27 +01:00
bitmap.h
lib/util: Make "struct bitmap" abstract
2012-11-07 15:32:24 +01:00
blocking.c
lib: Provide a meaningful errno if FD_CLOEXEC is missing
2021-01-26 00:10:31 +00:00
blocking.h
lib/util: Add a generic definition for set_close_on_exec
2016-06-08 10:33:19 +02:00
bytearray.h
lib:util: Add (PULL|PUSH)_(BE|LE)_I(8|16|32|64) byterarray macros
2020-02-21 03:35:58 +00:00
byteorder.h
lib:util: Add comments to use bytearray.h to byteorder.h
2020-02-21 02:09:33 +00:00
charset_compat.h
lib/util: Use charset_compat.h if SAMBA_UTIL_CORE_ONLY
2014-10-04 00:11:21 +02:00
close_low_fd.c
lib: Fix CID 1273073 Assign instead of compare
2015-03-03 17:34:39 +01:00
close_low_fd.h
lib: Make close_low_fd() independently linkable
2014-08-01 22:11:46 +02:00
data_blob.c
kdc: Pad UPN_DNS_INFO PAC buffer
2021-12-15 03:41:32 +00:00
data_blob.h
kdc: Pad UPN_DNS_INFO PAC buffer
2021-12-15 03:41:32 +00:00
debug_s3.c
debug: Add new smb.conf option "debug syslog format"
2021-11-01 07:29:47 +00:00
debug_s3.h
Fix warning messages on Freebsd 4.6.2.
2011-06-02 10:10:39 -07:00
debug.c
util: CID 1499409: Memory - corruptions (OVERLAPPING_COPY)
2022-02-22 00:17:11 +00:00
debug.h
debug: Add debug_syslog_format setting
2021-11-01 06:37:32 +00:00
discard.h
lib:util: Move discard_const(_p) to own header for libndr.h
2019-02-14 15:59:26 +01:00
dlinklist.h
DLIST_REMOVE: clang: Fix dereference of a null pointer warning
2019-06-11 12:10:17 +00:00
Doxyfile
…
dprintf.c
lib/util: Fix format-nonliteral warning
2016-08-24 01:33:50 +02:00
fault.c
lib: Avoid all_string_sub() in smb_panic()
2021-01-12 00:10:30 +00:00
fault.h
lib/util/fault.c: Unify printing of the stack trace with the INTERNAL ERROR string
2020-02-27 05:09:44 +00:00
fsusage.c
build: do not use HAVE_EXPLICIT_LARGEFILE_SUPPORT and *64() fucntions any more
2012-04-05 02:39:08 +02:00
genrand_util.c
util: Drop unused variable num_chars
2022-02-17 18:12:51 +00:00
genrand.c
lib:util: Fix documentation for random number functions
2019-08-14 15:07:24 +00:00
genrand.h
lib:util: Fix documentation for random number functions
2019-08-14 15:07:24 +00:00
getpass.c
getpass: Don't fail if stdin is not a tty
2013-04-05 07:34:37 +02:00
gpfswrap.c
lib/gpfswrap: add gpfs_set_times_path() wrapper
2021-08-26 19:18:31 +00:00
gpfswrap.h
lib/gpfswrap: add gpfs_set_times_path() wrapper
2021-08-26 19:18:31 +00:00
idtree_random.c
lib/util: Move idr_get_new_random() to new source file idtree_random.c
2014-09-19 18:11:11 +02:00
idtree_random.h
lib/util: Move idr_get_new_random() to new source file idtree_random.c
2014-09-19 18:11:11 +02:00
idtree.c
lib:util: Fix undefined behavior in idtree
2018-11-22 22:13:27 +01:00
idtree.h
lib: Remove a duplicate function prototype
2019-08-19 23:14:38 +00:00
iov_buf.c
lib/util: clang: Fix 'Null pointer passed as an argument'
2019-07-08 09:30:09 +00:00
iov_buf.h
lib/util: add and use iov_concat
2017-04-18 22:54:15 +02:00
mainpage.dox
…
memcache.c
lib:util: Avoid free'ing our own pointer
2021-02-03 10:57:01 +00:00
memcache.h
memcache: Add new cache type for dfree information
2018-05-25 22:52:12 +02:00
memory.h
lib:util: Sync memory.h with replace.h
2019-04-30 23:18:26 +00:00
mkdir_p.c
lib:util: Fix string check in mkdir_p()
2018-05-17 17:30:09 +02:00
mkdir_p.h
gpo: move mkdir_p to lib/util
2017-11-20 21:41:14 +01:00
modules.c
lib: Give util_paths.c its own header
2017-06-24 01:21:10 +02:00
ms_fnmatch.c
lib/util: clang: Fix a dereference of a null pointer warning(s)
2019-06-11 12:10:17 +00:00
msghdr.c
util: Fix signed/unsigned comparisons by casting
2019-07-01 08:00:29 +00:00
msghdr.h
lib: Move msghdr to lib/util/
2016-06-07 14:34:10 +02:00
params.c
lib: Simplify pm_process()
2022-02-07 19:58:57 +00:00
pidfile.c
lib:util: Initialize pid
2021-12-15 19:32:30 +00:00
pidfile.h
lib: Make pidfile_path_create() return the existing PID on conflict
2021-03-16 17:09:32 +00:00
rbtree.c
lib/util: clang: Fix dereference of a null pointer warning
2019-06-11 12:10:17 +00:00
rbtree.h
…
README
…
rfc1738.c
lib: Use hex_byte() in rfc1738_unescape()
2021-01-08 20:31:33 +00:00
safe_string.h
lib/util: remove extra safe_string.h file
2020-08-28 02:18:40 +00:00
samba_modules.h
lib:util: Make probing of modules more secure
2017-06-06 18:36:07 +02:00
samba_util.h
lib: Add talloc_asprintf_addbuf()
2021-10-08 19:28:31 +00:00
samba-util.pc.in
pkgconfig: Do not hardcode library version numbers in pc files.
2013-08-22 20:48:44 +02:00
select.c
lib: Avoid an includes.h
2017-03-20 12:20:08 +01:00
select.h
lib/util: Remove sys_poll as it is no longer needed
2012-02-16 15:49:21 -08:00
server_id_db.c
lib: Fix return of server_id_db_prune_name()
2019-07-03 10:51:32 +00:00
server_id_db.h
lib: Add server_id_db_pid()
2015-07-07 23:51:23 +02:00
server_id.c
lib: Slightly simplify server_id_set_disconnected()
2021-06-04 17:34:06 +00:00
server_id.h
lib: Add server_id_cmp()
2019-09-17 22:49:36 +00:00
setid.c
lib:util: Always include unistd.h for setgroups
2018-11-22 22:13:27 +01:00
setid.h
Replace all uses of setXX[ug]id() and setgroups with samba_setXX[ug]id() calls.
2012-06-28 17:15:16 -07:00
signal.c
lib/util: Clean up includes for signal.c
2014-10-04 00:11:21 +02:00
signal.h
lib/util: Add signal.h include
2021-12-13 16:22:28 +00:00
smb_strtox.c
lib: fix smb_strtox.[c|h] license header
2020-08-05 10:17:06 +00:00
smb_strtox.h
lib: fix smb_strtox.[c|h] license header
2020-08-05 10:17:06 +00:00
smb_threads_internal.h
…
smb_threads.c
…
smb_threads.h
lib: smb_threads: fix access before init bug
2018-07-04 21:07:09 +02:00
string_wrappers.h
string_wrappers: include replace.h
2020-08-28 00:56:34 +00:00
strv_util.c
util: Fix include file order
2018-11-30 08:12:31 +01:00
strv_util.h
lib/util: Add strv_util.[ch] containing new function strv_split()
2016-03-01 05:43:19 +01:00
strv.c
lib: Allow parsing a strv from a non-talloc const buf
2017-11-29 16:59:16 +01:00
strv.h
lib: Fix includes in strv.h
2021-04-19 18:18:31 +00:00
substitute.c
util:str_sub: talloc_free on error
2021-03-11 21:42:43 +00:00
substitute.h
lib/util: Replace buggy string_sub_talloc() with talloc_string_sub() in lib/util
2021-03-10 08:06:25 +00:00
sys_popen.c
lib: Fix CID 1445648 Null pointer dereferences
2019-05-28 20:27:14 +00:00
sys_popen.h
lib: util: Finally remove possibilities of using sys_popen() unsafely.
2019-05-24 19:00:06 +00:00
sys_rw_data.c
util: Fix signed/unsigned comparisons by casting
2019-07-01 08:00:29 +00:00
sys_rw_data.h
lib: Move sys_rw* to lib/util
2015-10-13 01:23:07 +02:00
sys_rw.c
lib: add sys_block_align[_truncate]()
2021-10-08 19:28:32 +00:00
sys_rw.h
lib: add sys_block_align[_truncate]()
2021-10-08 19:28:32 +00:00
system.c
lib/util: Remove obsolete sys_getpid() and sys_fork().
2012-03-24 21:55:40 +01:00
talloc_keep_secret.c
lib:util: Add support to keep talloc chunks secret
2019-04-03 06:48:21 +00:00
talloc_keep_secret.h
lib:util: Add support to keep talloc chunks secret
2019-04-03 06:48:21 +00:00
talloc_report_printf.c
lib: Add talloc_full_report_printf()
2019-09-18 20:10:24 +00:00
talloc_report_printf.h
lib: Add talloc_full_report_printf()
2019-09-18 20:10:24 +00:00
talloc_report.c
util: Fix signed/unsigned comparisons by casting
2019-07-01 08:00:29 +00:00
talloc_report.h
lib: Add talloc_report_str()
2015-02-13 23:32:07 +01:00
talloc_stack.c
talloc_stack: Call talloc destructors while frame is still around
2018-06-23 04:56:44 +02:00
talloc_stack.h
util: Update GPL header of talloc_stack.h
2016-02-12 09:01:14 +01:00
tevent_debug.c
tevent: add and use debug class for tevent
2015-07-01 23:04:00 +02:00
tevent_ntstatus.c
tevent: Add tevent_received to tevent_req_simple_recv_ntstatus
2013-08-12 13:59:53 -07:00
tevent_ntstatus.h
lib/util: move tevent_req_poll_ntstatus() to tevent_ntstatus.c
2012-05-14 15:12:34 +02:00
tevent_req_profile.c
lib: Avoid the use of open_memstream in tevent_req_profile_string
2018-10-08 22:17:11 +02:00
tevent_req_profile.h
lib: Avoid the use of open_memstream in tevent_req_profile_string
2018-10-08 22:17:11 +02:00
tevent_unix.c
lib: Add tevent_req_poll_unix
2015-07-07 23:51:23 +02:00
tevent_unix.h
lib: Add tevent_req_poll_unix
2015-07-07 23:51:23 +02:00
tevent_werror.c
werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in lib/util/tevent_werror.c
2016-09-28 00:04:18 +02:00
tevent_werror.h
lib: add tevent_req_poll_werror
2012-05-30 00:37:56 +02:00
tfork.c
lib: Fix a typo
2021-04-19 19:07:01 +00:00
tfork.h
lib: Fix a typo
2019-10-02 08:01:40 +00:00
tftw.c
lib: Remove some unneeded #includes from tftw.c
2019-10-02 08:01:40 +00:00
tftw.h
util: Add file tree walk interface
2019-01-28 15:44:18 +01:00
time_basic.c
time_basic.h: Remove unnecessary dependency on replace.h
2016-01-13 04:43:23 +01:00
time_basic.h
time_basic.h: Remove unnecessary dependency on replace.h
2016-01-13 04:43:23 +01:00
time.c
lib: util: Make nt_time_to_full_timespec() call nt_time_to_unix_timespec_raw() for the conversion.
2022-01-11 01:36:51 +00:00
time.h
lib: util: Add a function nt_time_to_unix_timespec_raw().
2022-01-08 05:43:32 +00:00
tini.c
lib/util: add pm_process_with_flags to allow parsing ini files with empty values
2017-01-06 12:28:19 +01:00
tini.h
lib/util: add pm_process_with_flags to allow parsing ini files with empty values
2017-01-06 12:28:19 +01:00
tiniparser.c
lib: CID 1452289: API usage errors (USE_AFTER_FREE)
2019-08-14 07:39:38 +00:00
tiniparser.h
Add fuzzing binary for tiniparser
2019-08-07 06:07:28 +00:00
tsort.h
…
unix_match.c
lib/util: Move unix_wild_match() from source3/lib/util to lib/util/
2016-11-16 12:41:09 +01:00
unix_match.h
lib/util: Move unix_wild_match() from source3/lib/util to lib/util/
2016-11-16 12:41:09 +01:00
unix_privs.c
lib: Add missing include for unistd.h in unix_privs.
2014-04-17 14:56:06 +02:00
util_file.c
lib: Fix file_lines_parse() to do what people expect. Much safer to use.
2020-11-13 16:22:32 +00:00
util_id.c
Fix signed/unsigned comparisons
2014-12-07 00:12:07 +01:00
util_ldb.c
…
util_ldb.h
lib/util/util_ldb.h: fix licence/copyright
2011-06-10 15:11:26 +02:00
util_net.c
lib: Fix a typo
2022-01-05 01:02:38 +00:00
util_net.h
lib: Add samba_sockaddr_[gs]et_port()
2021-01-11 13:19:32 +00:00
util_paths.c
s3: lib: Fix missing TALLOC_FREE in error code path.
2020-07-14 07:42:54 +00:00
util_paths.h
lib:util: Add path_expand_tilde()
2020-05-15 13:18:38 +00:00
util_process.c
lib/util: Make prctl_set_comment take a printf format string
2020-02-27 03:42:35 +00:00
util_process.h
lib/util: Make prctl_set_comment take a printf format string
2020-02-27 03:42:35 +00:00
util_pw.c
lib: Avoid an includes.h
2017-03-28 17:45:19 +02:00
util_pw.h
lib/util: Remove dummy wrapper for getgrgid().
2012-03-24 15:26:36 +01:00
util_runcmd.c
lib: Fix the build on FreeBSD
2021-01-25 09:48:09 +00:00
util_str_common.c
lib: Move ucs2_align() to 'charset' subsystem
2021-01-12 00:10:30 +00:00
util_str_escape.c
lib/util: Add functions to escape log lines but not break all non-ascii
2017-03-29 02:37:26 +02:00
util_str_escape.h
lib/util: Add functions to escape log lines but not break all non-ascii
2017-03-29 02:37:26 +02:00
util_str_hex.c
lib: Simplify parse_guid_string() and ndr_syntax_id_from_string()
2021-01-28 16:58:35 +00:00
util_str_hex.h
lib: Simplify parse_guid_string() and ndr_syntax_id_from_string()
2021-01-28 16:58:35 +00:00
util_str.c
lib: Add talloc_asprintf_addbuf()
2021-10-08 19:28:31 +00:00
util_strlist_v3.c
param: Fix str_list_v3 to accept ; again
2016-02-11 19:19:55 +01:00
util_strlist.c
lib: Add str_list_add_printf()
2021-05-11 22:56:37 +00:00
util_strlist.h
lib: Add str_list_add_printf()
2021-05-11 22:56:37 +00:00
util_tdb.c
lib:util: Check return value of tdb_parse_record()
2021-12-15 19:32:30 +00:00
util_tdb.h
lib: Remove unused tdb_traverse_delete_fn()
2021-04-19 18:18:31 +00:00
util.c
lib/util: add dump_data_diff*() helpers
2022-01-24 15:25:36 +00:00
util.h
lib/util: add dump_data_diff*() helpers
2022-01-24 15:25:36 +00:00
wscript
lib: Use gpfs.h from third_party on Linux
2019-01-18 17:21:02 +01:00
wscript_build
nsswitch: reduce dependecies to private libraries and link static/builtin if possible
2021-11-30 15:53:34 +00:00
wscript_configure
lib/util: use better linux os detection in gpfs configure
2020-01-28 18:05:34 +00:00

README 

This directory contains libutil (until we can think of a better name)

The idea is that this library contains simple but useful data structures 
and support functions that are generally useful; not just for Samba but for 
other projects as well. Functions here should not depend on any external 
libraries, just on libc (perhaps partially provided by libreplace).