1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
samba-mirror/source3
Noel Power 253c5585c9 s3/rpc_client: Fix array offset check
Previous to this commit we were modifying the offset before
the array offset check. This was causing a spurious debug
message indicating the offset was out of bounds. An second
problem is that upon detecting the error we don't exit the loop.
A third problem was that when reading the offset the check
didn't cater for the size of the integer address about to be read.

This commit moves the offset check to before the first read,
additionally when an error is detected now we actually exit the loop
and the offset have been corrected to include the size of the
integer to be read

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15579
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Feb 17 17:58:43 UTC 2024 on atb-devel-224

(cherry picked from commit 885850b6aa)

Autobuild-User(v4-20-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-20-test): Mon Feb 26 10:37:37 UTC 2024 on atb-devel-224
2024-02-26 10:37:37 +00:00
..
auth s3:auth: Allow 'Unix Users' and 'Unix Groups' to create a local token 2023-12-01 08:06:44 +00:00
build
client s3/libsmb: reuse smbXcli_conn_have_posix() 2023-10-26 15:29:29 +00:00
exports
groupdb s3:groupdb: Add missing newline to logging message 2023-08-08 04:39:38 +00:00
include s3:ctdbd_conn: add ctdbd_all_ip_foreach() helper 2024-01-26 17:00:32 +00:00
intl
lib s3:ctdbd_conn: add ctdbd_all_ip_foreach() helper 2024-01-26 17:00:32 +00:00
libads s3:libads: Fix memory leaks in ads_create_machine_acct() 2024-01-23 13:23:33 +00:00
libgpo/gpext
libnet s3:libnet: Remove always‐false comparison (CID 241309) 2023-10-13 02:18:31 +00:00
librpc s3:rpcd_witness.idl: add rpcd_witness_registration_updateB message definitions 2024-01-26 17:00:33 +00:00
libsmb libsmb: Fix whitespace and a typo 2024-01-23 23:28:31 +00:00
locale s3:utils: Fix code spelling 2023-08-08 04:39:38 +00:00
locking libcli/security: Rename dup_nt_token() -> security_token_duplicate() 2023-09-26 23:45:36 +00:00
modules vfs_ceph: Use ceph_fdopendir() when available for SMB_VFS_FDOPENDIR 2024-01-27 00:01:12 +00:00
nmbd VERSION: move COPYRIGHT_STARTUP_MESSAGE as SAMBA_COPYRIGHT_STRING into version.h 2023-12-15 10:44:42 +00:00
param s3:param: Remove unnecessary use of discard_const_p() 2023-12-21 20:21:34 +00:00
passdb s3:passdb: Fix memory leak caused by recursion of get_global_sam_sid() 2024-01-23 14:30:58 +00:00
printing smbd: set fsp_flags.is_fsa to true on printer file handles 2024-01-08 15:53:36 +00:00
profile profile: Fix rusage reporting 2023-12-19 16:05:36 +00:00
registry libcli/security: Rename dup_nt_token() -> security_token_duplicate() 2023-09-26 23:45:36 +00:00
rpc_client s3/rpc_client: Fix array offset check 2024-02-26 10:37:37 +00:00
rpc_server s3:rpc_server/witness: add handling of MSG_RPCD_WITNESS_REGISTRATION_UPDATE messages 2024-01-26 17:00:33 +00:00
rpcclient s3:rpcclient: Use dcerpc_lsa_open_policy_fallback() in cmd_lsarpc.c 2023-11-21 11:16:37 +00:00
script selftest: test listing trusted domains that includes an NT4 domain 2024-01-20 13:20:37 +00:00
selftest selftest: test listing trusted domains that includes an NT4 domain 2024-01-20 13:20:37 +00:00
services
smbd smb2_tcon: only announce SMB3 related share capabilities if SMB3 is used 2024-02-19 14:31:13 +00:00
torture smbd: Give source3/smbd/dir.c its own header file 2023-12-19 16:05:36 +00:00
utils s3/utils: use full 64 bit address for getrows (with 64bit offsets) 2024-02-26 09:34:15 +00:00
web
winbindd winbindd: fix listing trusted domains with NT trusts 2024-01-20 14:23:51 +00:00
.clang_complete
.dmallocrc
.indent.pro
Doxyfile
mainpage.dox
smbadduser.in
wscript vfs_ceph: Use ceph_fdopendir() when available for SMB_VFS_FDOPENDIR 2024-01-27 00:01:12 +00:00
wscript_build VERSION: move COPYRIGHT_STARTUP_MESSAGE as SAMBA_COPYRIGHT_STRING into version.h 2023-12-15 10:44:42 +00:00
wscript_configure_system_ncurses