mirror of
https://github.com/samba-team/samba.git
synced 2024-12-23 17:34:34 +03:00
0159c48e89
Using xargs with sort -u to de-duplicate this list was my idea and causes a couple of things to go wrong. The use of xargs causes double-quotes to be lost. The resulting $public_ifaces value also contains newlines. The newlines could be removed with an additional xargs at the end of the pipeline... but that would add an extra level of quote stripping. I have unsuccessfully tried to find an alternative, but still elegant, command pipeline that de-duplicates the list, while maintaining quoting. So, just drop the de-duplication. This might make interface_ifindex_exists_with_options() slightly less efficient. However, that function walks the whole list, only terminating early when a match is found on both interface and options, so at least it will be correct. Include an extra testcase. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Apr 18 09:08:34 UTC 2024 on atb-devel-224 |
||
|---|---|---|
| .. | ||
| cunit | ||
| eventd | ||
| eventscripts | ||
| onnode | ||
| shellcheck | ||
| takeover | ||
| takeover_helper | ||
| tool | ||