1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-06 13:18:07 +03:00
https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)
Go to file
Andreas Schneider dfbd950a1d s3:winbind: Fix heap buffer overflow in winbind
==36258==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x51300000b096 at pc 0x7fb6b4880b46 bp 0x7ffc67d44b40 sp 0x7ffc67d44300
READ of size 1 at 0x51300000b096 thread T0
    #0 0x7fb6b4880b45 in strlen ../../../../libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:391
    #1 0x560fe898cde3 in winbindd_wins_byip_done ../../source3/winbindd/winbindd_wins_byip.c:111
    #2 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #3 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #4 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #5 0x7fb6b1e24c80 in node_status_query_done ../../source3/libsmb/namequery.c:904
    #6 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #7 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #8 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #9 0x7fb6b1e250bc in nb_trans_done ../../source3/libsmb/namequery.c:756
    #10 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #11 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #12 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #13 0x7fb6b1e270af in sock_packet_read_got_socket ../../source3/libsmb/namequery.c:537
    #14 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #15 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #16 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #17 0x7fb6b33db183 in tdgram_recvfrom_done ../../lib/tsocket/tsocket.c:240
    #18 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #19 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #20 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #21 0x7fb6b33e0d99 in tdgram_bsd_recvfrom_handler ../../lib/tsocket/tsocket_bsd.c:1087
    #22 0x7fb6b33e0263 in tdgram_bsd_fde_handler ../../lib/tsocket/tsocket_bsd.c:811
    #23 0x7fb6b4ef5ac1 in tevent_common_invoke_fd_handler ../../lib/tevent/tevent_fd.c:174
    #24 0x7fb6b4f0b185 in epoll_event_loop ../../lib/tevent/tevent_epoll.c:696
    #25 0x7fb6b4f0b185 in epoll_event_loop_once ../../lib/tevent/tevent_epoll.c:926
    #26 0x7fb6b4f037b8 in std_event_loop_once ../../lib/tevent/tevent_standard.c:110
    #27 0x7fb6b4ef3549 in _tevent_loop_once ../../lib/tevent/tevent.c:820
    #28 0x560fe8a15198 in main ../../source3/winbindd/winbindd.c:1729
    #29 0x7fb6afe2a2ad in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #30 0x7fb6afe2a378 in __libc_start_main_impl ../csu/libc-start.c:360
    #31 0x560fe89454e4 in _start ../sysdeps/x86_64/start.S:115

0x51300000b096 is located 12 bytes after 330-byte region [0x51300000af40,0x51300000b08a)
allocated by thread T0 here:
    #0 0x7fb6b48fc777 in malloc ../../../../libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7fb6b3a64c57 in __talloc_with_prefix ../../lib/talloc/talloc.c:783
    #2 0x7fb6b3a66acf in __talloc ../../lib/talloc/talloc.c:825
    #3 0x7fb6b3a66acf in _talloc_named_const ../../lib/talloc/talloc.c:982
    #4 0x7fb6b3a66acf in _talloc_array ../../lib/talloc/talloc.c:2784
    #5 0x7fb6b1e2b43e in parse_node_status ../../source3/libsmb/namequery.c:337
    #6 0x7fb6b1e2b43e in node_status_query_recv ../../source3/libsmb/namequery.c:921
    #7 0x560fe898cc4f in winbindd_wins_byip_done ../../source3/winbindd/winbindd_wins_byip.c:87
    #8 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #9 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #10 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #11 0x7fb6b1e24c80 in node_status_query_done ../../source3/libsmb/namequery.c:904
    #12 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #13 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #14 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #15 0x7fb6b1e250bc in nb_trans_done ../../source3/libsmb/namequery.c:756
    #16 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #17 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #18 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #19 0x7fb6b1e270af in sock_packet_read_got_socket ../../source3/libsmb/namequery.c:537
    #20 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #21 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #22 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #23 0x7fb6b33db183 in tdgram_recvfrom_done ../../lib/tsocket/tsocket.c:240
    #24 0x7fb6b4ef8ae5 in _tevent_req_notify_callback ../../lib/tevent/tevent_req.c:177
    #25 0x7fb6b4ef8d1c in tevent_req_finish ../../lib/tevent/tevent_req.c:234
    #26 0x7fb6b4ef8d84 in _tevent_req_done ../../lib/tevent/tevent_req.c:240
    #27 0x7fb6b33e0d99 in tdgram_bsd_recvfrom_handler ../../lib/tsocket/tsocket_bsd.c:1087
    #28 0x7fb6b33e0263 in tdgram_bsd_fde_handler ../../lib/tsocket/tsocket_bsd.c:811
    #29 0x7fb6b4ef5ac1 in tevent_common_invoke_fd_handler ../../lib/tevent/tevent_fd.c:174
    #30 0x7fb6b4f0b185 in epoll_event_loop ../../lib/tevent/tevent_epoll.c:696
    #31 0x7fb6b4f0b185 in epoll_event_loop_once ../../lib/tevent/tevent_epoll.c:926
    #32 0x7fb6b4f037b8 in std_event_loop_once ../../lib/tevent/tevent_standard.c:110
    #33 0x7fb6b4ef3549 in _tevent_loop_once ../../lib/tevent/tevent.c:820

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2024-10-24 10:54:37 +00:00
.github Added redirect from GitHub to GitLab 2018-12-05 16:35:33 +01:00
auth gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state 2024-10-10 14:01:04 +00:00
bootstrap Fix Rocky8 build for utf8proc-devel 2024-10-23 14:21:34 +00:00
buildtools Add configure checks for glibc and openssl versions 2024-10-23 14:21:34 +00:00
coverity coverity: Add modeling file for Coverity scan 2017-02-23 07:11:18 +01:00
ctdb ctdb-scripts: Don't set arp_filter=1 by default in 10.interface 2024-10-17 18:53:32 +00:00
dfs_server s4:dfs_server: Use lpcfg_dns_hostname() in dfs_server_ad.c 2024-05-22 20:33:36 +00:00
docs-xml Isolate hsm auth value from the cache 2024-10-23 14:21:33 +00:00
dynconfig Isolate hsm auth value from the cache 2024-10-23 14:21:33 +00:00
examples s3:vfs: add vfs_rename_how to SMB_VFS_RENAMEAT() 2024-08-21 08:02:30 +00:00
file_server s3: Remove --log-stdout from daemons 2021-04-29 03:58:37 +00:00
include build: added placeholder files for public header directories 2011-03-15 12:22:18 +11:00
lib Isolate hsm auth value from the cache 2024-10-23 14:21:33 +00:00
libcli Add ntstatus_gen for Rust 2024-10-23 14:21:33 +00:00
libds/common libds: remove unreachable break statements after return 2024-02-16 02:41:36 +00:00
libgpo libgpo: Initialize struct security_ace array 2024-07-16 11:41:33 +00:00
librpc dcesrv_core: better fault codes dcesrv_auth_prepare_auth3() 2024-10-10 15:17:46 +00:00
nsswitch nsswitch: Fix memory leak in wbcDomainInfoList 2024-10-24 10:54:37 +00:00
packaging packaging: Add missing quotes in smbprint 2024-06-24 07:14:54 +00:00
pidl pidl: Add headerhelper idl property 2024-08-27 07:19:32 +00:00
python Fix usage test broken by rust vendor sources 2024-10-23 14:21:34 +00:00
release-scripts release-script: Fix shellcheck errors 2022-08-17 11:03:54 +00:00
rust Fix pam failure to register Pin following mfa poll 2024-10-23 15:39:09 +00:00
script autobuild: Configure samba-o3 for himmelblau testing 2024-10-23 14:21:34 +00:00
selftest Enable rust cargo test in Samba make test 2024-10-23 14:21:33 +00:00
source3 s3:winbind: Fix heap buffer overflow in winbind 2024-10-24 10:54:37 +00:00
source4 s4:client: Fix memory leaks in smblcient4 2024-10-24 10:54:37 +00:00
testdata testdata: Fix spelling 2023-10-25 22:23:38 +00:00
testprogs testprogs: Remove alias test from test_net_ads.sh 2024-07-26 17:12:36 +00:00
tests tests: Fix code spelling 2023-08-14 21:45:30 +00:00
testsuite testsuite: Reformat shell scripts 2022-08-10 13:17:31 +00:00
third_party third_party/heimdal: Import lorikeet-heimdal-202410161454 (commit 0d61538a16b5051c820702f0711102112cd01a83) 2024-10-16 19:05:15 +00:00
wintest wintest: Fix invalid escape sequences 2023-10-13 04:55:06 +00:00
.bzrignore Add bzrignore symlink. 2010-12-18 00:47:06 +01:00
.clang-format clang-format: sort alphabetically 2023-10-24 14:47:57 +00:00
.clangd Add .clangd configuration file 2023-03-29 16:57:34 +00:00
.codespellignore A Rust 'crate' is not a misspelling of 'create' 2024-10-23 14:21:33 +00:00
.codespellrc codespell: Ignore CTDB bin/ 2024-08-22 09:02:38 +00:00
.editorconfig editorconfig: We always inserted a new line so keep doing that 2022-02-28 10:22:34 +00:00
.git-blame-ignore-revs Add a git-blame-ignore-revs file 2023-03-03 02:02:51 +00:00
.gitattributes .gitattributes: Treat file containing test SDDL as binary 2023-10-25 22:23:37 +00:00
.gitignore gitignore: add WAF lockfile 2023-10-17 04:16:29 +00:00
.gitlab-ci-coverage-runners.yml .gitlab-ci: Remove tags no longer provided by gitlab.com 2024-05-07 13:40:55 +00:00
.gitlab-ci-coverage.yml add .gitlab-ci-coverage.yml for a scheduled build 2021-04-13 09:33:14 +00:00
.gitlab-ci-default-runners.yml .gitlab-ci: Remove tags no longer provided by gitlab.com 2024-05-07 13:40:55 +00:00
.gitlab-ci-default.yml .gitlab-ci.yml: Honour AUTOBUILD_SKIP_SAMBA_O3 in GitLab CI 2021-10-13 11:10:44 +00:00
.gitlab-ci-main.yml Fix Rocky8 build for utf8proc-devel 2024-10-23 14:21:34 +00:00
.gitlab-ci-private.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.gitlab-ci.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.gitleaks.toml Add gitleaks configuration file to avoid false positives 2023-02-13 18:45:21 +00:00
.mailmap mailmap: Associate my identity with my old email address 2024-02-16 02:41:36 +00:00
.testr.conf testr: Use waf testonly and create a custom directory for new workers. 2014-10-14 06:44:07 +02:00
.ycm_extra_conf.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
callcatcher-exceptions.grep build: Add exceptions for callcatcher unused function detection 2012-02-17 09:12:47 +01:00
configure configure/Makefile: export PYTHONHASHSEED=1 in all 'configure/Makefile' scripts 2022-03-29 22:32:32 +00:00
configure.developer lib: Change socket_wrapper to preloadable version. 2014-04-17 14:56:06 +02:00
COPYING r23778: Change to GPLv3. Now to go through all internal source 2007-10-10 12:28:19 -05:00
GPG_AA99442FB680B620_replaces_6F33915B6568B7EA.txt ReleaseKey: add GnuPG key transition statement for the Samba release key 2021-01-21 13:57:45 +01:00
Makefile build: Add 'make printversion' to provide version string 2023-10-17 03:19:38 +00:00
PFIF.txt docs: protocolfreedom.org is no longer 2020-06-12 22:11:43 +00:00
README.cifs-utils Update URL in README.cifs-utils 2010-04-02 06:26:09 -04:00
README.Coding.md README: Add languages to code blocks for highlighting 2024-09-05 14:27:30 +00:00
README.contributing Rename Samba's DCO to Samba Developer's Declaration 2020-10-20 22:54:01 +00:00
README.md Update README.md with more up to date information 2020-06-12 22:11:43 +00:00
SECURITY.md SECURITY.md: Fix spelling 2023-10-25 22:23:37 +00:00
setup.cfg pep8 tidy up config 2020-12-17 00:54:51 +00:00
VERSION VERSION: Bump version up to 4.22.0pre1... 2024-07-29 09:01:32 +00:00
VFS-License-clarification.txt VFS-License-clarification: minor improvements aligning w/ GPLv3 text 2020-11-04 21:29:40 +00:00
WHATSNEW.txt WHATSNEW: add 'vfs mkdir use tmp name' option 2024-08-21 09:18:00 +00:00
wscript Add configure checks for glibc and openssl versions 2024-10-23 14:21:34 +00:00
wscript_build Reorganize rust file tree 2024-10-23 14:21:33 +00:00
wscript_build_embedded_heimdal wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_build_system_heimdal wscript: Correctly determine dependencies for system Heimdal build 2022-11-08 02:39:37 +00:00
wscript_build_system_mitkrb5 wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_configure_embedded_heimdal wscript_configure_embedded_heimdal: define HAVE_CLIENT_GSS_C_CHANNEL_BOUND_FLAG 2024-04-23 23:50:34 +00:00
wscript_configure_system_gnutls lib/crypto: add legacy_gnutls_server_end_point_cb() if needed 2024-04-23 23:50:33 +00:00
wscript_configure_system_heimdal build: Add build time detection for the MIT FAST ccache API 2023-11-29 03:11:34 +00:00
wscript_configure_system_mitkrb5 system_mitkrb5: require 1.16 as we use ENCTYPE_AES256_CTS_HMAC_SHA384_192 2024-09-30 15:51:28 +00:00

About Samba

Samba is the standard Windows interoperability suite of programs for Linux and Unix. Samba is Free Software licensed under the GNU General Public License and the Samba project is a member of the Software Freedom Conservancy. Since 1992, Samba has provided secure, stable and fast file and print services for all clients using the SMB/CIFS protocol, such as all versions of DOS and Windows, OS/2, Linux and many others. Samba is an important component to seamlessly integrate Linux/Unix Servers and Desktops into Active Directory environments. It can function both as a domain controller or as a regular domain member.

For the AD DC implementation a full HOWTO is provided at: https://wiki.samba.org/index.php/Samba4/HOWTO

Community guidelines can be read at: https://wiki.samba.org/index.php/How_to_do_Samba:_Nicely

This software is freely distributable under the GNU public license, a copy of which you should have received with this software (in a file called COPYING).

CONTRIBUTIONS

Please see https://wiki.samba.org/index.php/Contribute for detailed set-by-step instructions on how to submit a patch for Samba via GitLab.

Samba's GitLab mirror is at https://gitlab.com/samba-team/samba

OUR CONTRIBUTORS

See https://www.samba.org/samba/team/ for details of the Samba Team, as well as details of all those currently active in Samba development.

If you like a particular feature then look through the git change-log (on the web at https://gitweb.samba.org/?p=samba.git;a=summary) and see who added it, then send them an email.

Remember that free software of this kind lives or dies by the response we get. If no one tells us they like it then we'll probably move onto something else.

MORE INFO

DOCUMENTATION

There is quite a bit of documentation included with the package, including man pages and the wiki at https://wiki.samba.org

If you would like to help with our documentation, please contribute that improved content to the wiki, we are moving as much content there as possible.

MAILING LIST

Please do NOT send subscription/unsubscription requests to the lists!

There is a mailing list for discussion of Samba. For details go to https://lists.samba.org/ or send mail to samba-subscribe@lists.samba.org

There is also an announcement mailing list where new versions are announced. To subscribe go to https://lists.samba.org/ or send mail to samba-announce-subscribe@lists.samba.org. All announcements also go to the samba list, so you only need to be on one.

For details of other Samba mailing lists and for access to archives, see https://lists.samba.org/

MAILING LIST ETIQUETTE

A few tips when submitting to this or any mailing list.

  1. Make your subject short and descriptive. Avoid the words "help" or "Samba" in the subject. The readers of this list already know that a) you need help, and b) you are writing about samba (of course, you may need to distinguish between Samba PDC and other file sharing software). Avoid phrases such as "what is" and "how do i". Some good subject lines might look like "Slow response with Excel files" or "Migrating from Samba PDC to NT PDC".

  2. If you include the original message in your reply, trim it so that only the relevant lines, enough to establish context, are included. Chances are (since this is a mailing list) we've already read the original message.

  3. Trim irrelevant headers from the original message in your reply. All we need to see is a) From, b) Date, and c) Subject. We don't even really need the Subject, if you haven't changed it. Better yet is to just preface the original message with "On [date] [someone] wrote:".

  4. Please don't reply to or argue about spam, spam filters or viruses on any Samba lists. We do have a spam filtering system that is working quite well thank you very much but occasionally unwanted messages slip through. Deal with it.

  5. Never say "Me too." It doesn't help anyone solve the problem. Instead, if you ARE having the same problem, give more information. Have you seen something that the other writer hasn't mentioned, which may be helpful?

  6. If you ask about a problem, then come up with the solution on your own or through another source, by all means post it. Someone else may have the same problem and is waiting for an answer, but never hears of it.

  7. Give as much relevant information as possible such as Samba release number, OS, kernel version, etc...

  8. RTFM. Google.

WEBSITE

A Samba website has been setup with lots of useful info. Connect to:

https://www.samba.org/

As well as general information and documentation, this also has searchable archives of the mailing list and links to other useful resources such as the wiki.