mirror of
https://github.com/samba-team/samba.git
synced 2024-12-23 17:34:34 +03:00
fcecdfa8e5
This function already exists in bind9 but takes different arguments, so when the DLZ is loaded and this function is called bind crashes: named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: samba_dlz: allowing update of signer=DESKTOP-8BUKMBK\$\@AFOREST.AD name=118.101.168.192.in-addr.arpa tcpaddr=192.168.101.118 type=PTR key=1264-ms-7.1-2ac9.9ef238e1-9747-11ed-9f95-525400dc6981/159/0 named[1523]: client @0x7f26caa90f68 192.168.101.118#58223/key DESKTOP-8BUKMBK\$\@AFOREST.AD: updating zone '101.168.192.in-addr.arpa/NONE': deleting rrset at '118.101.168.192.in-addr.ar named[1523]: name.c:664: REQUIRE(((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))) failed, back trace Backtrace: #0 0x00007f2716c957ec in __pthread_kill_implementation () from /lib64/libc.so.6 #1 0x00007f2716c42816 in raise () from /lib64/libc.so.6 #2 0x00007f2716c2b81c in abort () from /lib64/libc.so.6 #3 0x000055d4de847995 in assertion_failed (file=<optimized out>, line=<optimized out>, type=<optimized out>, cond=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/main.c:237 #4 0x00007f27176388fc in isc_assertion_failed (file=file@entry=0x7f27173b0df6 "name.c", line=line@entry=664, type=type@entry=isc_assertiontype_require, cond=cond@entry=0x7f27173b0268 "((name1) != ((void *)0) && ((const isc__magic_t *)(name1))->magic == ((('D') << 24 | ('N') << 16 | ('S') << 8 | ('n'))))") at /usr/src/debug/bind-9.18.10/lib/isc/assertions.c:48 #5 0x00007f27172946f9 in dns_name_equal (name1=<optimized out>, name2=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/name.c:664 **** Here bind's dns_name_equal() is called instead of samba's dns_name_equal() **** #6 0x00007f27077ad6f2 in dns_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dnsserver_common.c:1346 #7 0x00007f271404732c in b9_record_match (rec1=0x7f26f8042d70, rec2=0x7f26f8044d10) at ../../source4/dns_server/dlz_bind9.c:1830 #8 0x00007f2714047daa in dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=0x7f26c9c10000 "118.101.168.192.in-addr.arpa.\t1200\tIN\tPTR\tDESKTOP-8BUKMBK.aforest.ad.", dbdata=0x7f271003d300, version=0x7f26f8044b20) at ../../source4/dns_server/dlz_bind9.c:2077 #9 0x000055d4de84afb4 in dlopen_dlz_subrdataset (name=0x7f2706ff82f0 "118.101.168.192.in-addr.arpa", rdatastr=<optimized out>, driverarg=<optimized out>, dbdata=0x7f270430f680, version=<optimized out>) at /usr/src/debug/bind-9.18.10/bin/named/dlz_dlopen_driver.c:483 #10 0x00007f271738e734 in modrdataset.constprop.0 (db=0x7f2704291740, node=0x7f26c9c006e0, version=0x7f26f8044b20, rdataset=0x7f2706ff8830, mod_function=0x55d4de84af80 <dlopen_dlz_subrdataset>, options=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/dns/sdlz.c:1107 #11 0x00007f2717251855 in diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, warn=warn@entry=true) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:370 #12 0x00007f2717251c8a in dns_diff_apply (diff=diff@entry=0x7f2706ff8df0, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20) at /usr/src/debug/bind-9.18.10/lib/dns/diff.c:465 #13 0x00007f2717d105aa in do_one_tuple (tuple=tuple@entry=0x7f2706ff8e50, db=db@entry=0x7f2704291740, ver=ver@entry=0x7f26f8044b20, diff=diff@entry=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:454 #14 0x00007f2717d10fff in update_one_rr (rdata=0x7f2706ff8ee8, ttl=<optimized out>, name=<optimized out>, op=DNS_DIFFOP_DEL, diff=0x7f2706ff9400, ver=0x7f26f8044b20, db=0x7f2704291740) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:505 #15 delete_if_action (data=<optimized out>, rr=0x7f2706ff8ee0) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1427 #16 0x00007f2717d10ccd in foreach_rr (db=0x7f2704291740, ver=<optimized out>, name=0x7f26caa61d00, type=<optimized out>, covers=<optimized out>, rr_action=rr_action@entry=0x7f2717d10f60 <delete_if_action>, rr_action_data=0x7f2706ff9280) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:736 #17 0x00007f2717d10e76 in delete_if (predicate=predicate@entry=0x7f2717d0fb10 <true_p>, db=<optimized out>, ver=<optimized out>, name=<optimized out>, type=<optimized out>, covers=<optimized out>, update_rr=0x7f2706ff94b0, diff=0x7f2706ff9400) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:1454 #18 0x00007f2717d1bccd in update_action (task=<optimized out>, event=<optimized out>) at /usr/src/debug/bind-9.18.10/lib/ns/update.c:3299 #19 0x00007f271765eb4c in task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:823 #20 isc_task_run (task=0x7f27155ccf00) at /usr/src/debug/bind-9.18.10/lib/isc/task.c:904 #21 0x00007f271762cb12 in isc__nm_async_task (worker=0x7f2716236560, ev0=0x7f26caa07000) at netmgr/netmgr.c:840 #22 process_netievent (worker=worker@entry=0x7f2716236560, ievent=0x7f26caa07000) at netmgr/netmgr.c:918 #23 0x00007f271762d197 in process_queue (worker=worker@entry=0x7f2716236560, type=type@entry=NETIEVENT_TASK) at netmgr/netmgr.c:1011 #24 0x00007f271762d3b3 in process_all_queues (worker=0x7f2716236560) at netmgr/netmgr.c:765 #25 async_cb (handle=0x7f27162368c0) at netmgr/netmgr.c:794 #26 0x00007f2717c4cb0d in uv__async_io (loop=0x7f2716236570, w=<optimized out>, events=<optimized out>) at src/unix/async.c:163 #27 0x00007f2717c6825d in uv__io_poll (loop=0x7f2716236570, timeout=<optimized out>) at src/unix/epoll.c:374 #28 0x00007f2717c5247a in uv__io_poll (timeout=<optimized out>, loop=0x7f2716236570) at src/unix/udp.c:122 #29 uv_run (loop=loop@entry=0x7f2716236570, mode=mode@entry=UV_RUN_DEFAULT) at src/unix/core.c:406 #30 0x00007f271762d834 in nm_thread (worker0=0x7f2716236560) at netmgr/netmgr.c:696 #31 0x00007f27176627f5 in isc__trampoline_run (arg=0x55d4dfe3ad70) at /usr/src/debug/bind-9.18.10/lib/isc/trampoline.c:189 #32 0x00007f2716c9398d in start_thread () from /lib64/libc.so.6 #33 0x00007f2716d19344 in clone () from /lib64/libc.so.6 BUG: https://bugzilla.samba.org/show_bug.cgi?id=14030 Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Autobuild-User(master): Samuel Cabrero <scabrero@samba.org> Autobuild-Date(master): Thu Jan 19 10:20:27 UTC 2023 on atb-devel-224
140 lines
4.2 KiB
C
140 lines
4.2 KiB
C
/*
|
|
Unix SMB/CIFS implementation.
|
|
|
|
DNS server utils
|
|
|
|
Copyright (C) 2014 Stefan Metzmacher
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "rpc_server/dnsserver/dnsserver.h"
|
|
|
|
#ifndef __DNSSERVER_COMMON_H__
|
|
#define __DNSSERVER_COMMON_H__
|
|
|
|
uint8_t werr_to_dns_err(WERROR werr);
|
|
#define DNS_ERR(err_str) WERR_DNS_ERROR_RCODE_##err_str
|
|
|
|
struct ldb_message_element;
|
|
struct ldb_context;
|
|
struct dnsp_DnssrvRpcRecord;
|
|
|
|
struct dns_server_zone {
|
|
struct dns_server_zone *prev, *next;
|
|
const char *name;
|
|
struct ldb_dn *dn;
|
|
};
|
|
|
|
WERROR dns_common_extract(struct ldb_context *samdb,
|
|
const struct ldb_message_element *el,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct dnsp_DnssrvRpcRecord **records,
|
|
uint16_t *num_records);
|
|
|
|
WERROR dns_common_lookup(struct ldb_context *samdb,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct ldb_dn *dn,
|
|
struct dnsp_DnssrvRpcRecord **records,
|
|
uint16_t *num_records,
|
|
bool *tombstoned);
|
|
WERROR dns_common_wildcard_lookup(struct ldb_context *samdb,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct ldb_dn *dn,
|
|
struct dnsp_DnssrvRpcRecord **records,
|
|
uint16_t *num_records);
|
|
WERROR dns_name_check(TALLOC_CTX *mem_ctx,
|
|
size_t len,
|
|
const char *name);
|
|
WERROR dns_get_zone_properties(struct ldb_context *samdb,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct ldb_dn *zone_dn,
|
|
struct dnsserver_zoneinfo *zoneinfo);
|
|
bool dns_name_is_static(struct dnsp_DnssrvRpcRecord *records,
|
|
uint16_t rec_count);
|
|
WERROR dns_common_replace(struct ldb_context *samdb,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct ldb_dn *dn,
|
|
bool needs_add,
|
|
uint32_t serial,
|
|
struct dnsp_DnssrvRpcRecord *records,
|
|
uint16_t rec_count);
|
|
bool dns_name_match(const char *zone, const char *name, size_t *host_part_len);
|
|
WERROR dns_common_name2dn(struct ldb_context *samdb,
|
|
struct dns_server_zone *zones,
|
|
TALLOC_CTX *mem_ctx,
|
|
const char *name,
|
|
struct ldb_dn **_dn);
|
|
bool samba_dns_name_equal(const char *name1, const char *name2);
|
|
|
|
bool dns_record_match(struct dnsp_DnssrvRpcRecord *rec1,
|
|
struct dnsp_DnssrvRpcRecord *rec2);
|
|
|
|
/*
|
|
* For this routine, base_dn is generally NULL. The exception comes
|
|
* from the python bindings to support setting ACLs on DNS objects
|
|
* when joining Windows
|
|
*/
|
|
NTSTATUS dns_common_zones(struct ldb_context *samdb,
|
|
TALLOC_CTX *mem_ctx,
|
|
struct ldb_dn *base_dn,
|
|
struct dns_server_zone **zones_ret);
|
|
|
|
bool dns_zoneinfo_load_zone_property(struct dnsserver_zoneinfo *zoneinfo,
|
|
struct dnsp_DnsProperty *prop);
|
|
/*
|
|
* Log a DNS operation along with it's duration
|
|
* Enabled by setting a log level of "dns:10"
|
|
*
|
|
* const char *operation
|
|
* const char *result
|
|
* const struct timeval *start
|
|
* const char *zone
|
|
* const char *name
|
|
* const char *data
|
|
*/
|
|
#define DNS_COMMON_LOG_OPERATION(result, start, zone, name, data) \
|
|
if (CHECK_DEBUGLVLC(DBGC_DNS, DBGLVL_DEBUG)) { \
|
|
struct timeval now = timeval_current(); \
|
|
uint64_t duration = usec_time_diff(&now, (start));\
|
|
const char *re = (result);\
|
|
const char *zn = (zone); \
|
|
const char *nm = (name); \
|
|
const char *dt = (data); \
|
|
DBG_DEBUG( \
|
|
"DNS timing: result: [%s] duration: (%" PRIi64 ") " \
|
|
"zone: [%s] name: [%s] data: [%s]\n", \
|
|
re == NULL ? "" : re, \
|
|
duration, \
|
|
zn == NULL ? "" : zn, \
|
|
nm == NULL ? "" : nm, \
|
|
dt == NULL ? "" : dt); \
|
|
}
|
|
|
|
/* There are this many nttime jiffies in an hour */
|
|
#define NTTIME_TO_HOURS (3600ULL * 10ULL * 1000ULL * 1000ULL)
|
|
|
|
/*
|
|
* convert unix time to a DNS timestamp
|
|
* (hours in the NTTIME epoch, 32 bit).
|
|
*/
|
|
uint32_t unix_to_dns_timestamp(time_t t);
|
|
|
|
/*
|
|
* Convert a DNS timestamp into NTTIME.
|
|
*/
|
|
NTSTATUS dns_timestamp_to_nt_time(NTTIME *_nt, uint32_t t);
|
|
|
|
#endif /* __DNSSERVER_COMMON_H__ */
|