1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
samba-mirror/lib/ldb
Douglas Bagnall e21251926b ldb:attrib_handlers: reduce non-transitive behaviour in ldb_comparison_fold
If two strings are invalid UTF-8, the string is first compared with
memcmp(), which compares as unsigned char.

If the strings are of different lengths and one is a substring of the
other, the memcmp() returns 0 and a second comparison is made which
assumes the next character in the shorter string is '\0' -- but this
comparison was done using SIGNED chars (on most systems). That leads
to non-transitive comparisons.

Consider the strings {"a\xff", "a", "ab\xff"} under that system.

   "a\xff"  < "a",      because (char)0xff == -1.

   "ab\xff" > "a",     because  'b' == 98.

   "ab\xff" < "a\xff", because memcmp("ab\xff", "a\xff", 2) avoiding the
                       signed char tiebreaker.

(Before c49c48afe0, the final character
might br arbitrarily cast into another character -- in latin-1, for
example, the 0xff here would have been seen as 'ÿ', which would be
uppercased to 'Ÿ', which is U+0178, which would be truncated to
'\x78', a positive char.

On the other hand e.g. 0xfe, 'þ', would have mapped to 0xde, 'Þ',
remaining negative).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit e2051eebd4)
2024-06-10 13:24:17 +00:00
..
ABI ldb: change the version to 2.9.0 for Samba 4.20 2023-07-28 11:49:02 +00:00
common ldb:attrib_handlers: reduce non-transitive behaviour in ldb_comparison_fold 2024-06-10 13:24:17 +00:00
docs lib:ldb: Reformat shell scripts 2022-02-24 09:15:34 +00:00
examples
include ldb: add NUMERIC_CMP macro to ldb.h 2024-06-10 13:24:16 +00:00
ldb_key_value ldb: Fix code spelling 2023-10-25 22:23:37 +00:00
ldb_ldap ldb_ldap: Fix a memleak 2020-07-02 10:38:34 +00:00
ldb_ldb ldb: Add MDB support to ldb:// 2018-05-23 02:27:12 +02:00
ldb_map ldb: Use correct member of union 2023-04-05 02:10:35 +00:00
ldb_mdb lib:ldb: Fix code spelling 2023-04-11 09:06:35 +00:00
ldb_sqlite3 ldb:ldb_sqlite3: Access correct member of union 2023-08-14 04:57:34 +00:00
ldb_tdb ldb: Fix code spelling 2023-10-25 22:23:37 +00:00
man lib:ldb: Fix code spelling 2023-04-11 09:06:35 +00:00
modules ldb:sort: generalise both-NULL check to equality check 2024-06-10 13:24:16 +00:00
nssldb lib:ldb:nssldb: Fix code spelling 2023-04-04 07:31:36 +00:00
tests ldb: Fix code spelling 2023-10-25 22:23:37 +00:00
tools ldb: Fix building with FORTIFY_SOURCE=2 2023-10-01 22:45:38 +00:00
web
_ldb_text.py ldb/tests/_ldb_text: remove unused imports 2018-10-25 21:45:55 +02:00
configure configure/Makefile: export PYTHONHASHSEED=1 in all 'configure/Makefile' scripts 2022-03-29 22:32:32 +00:00
Doxyfile
examples.dox
ldb.pc.in
mainpage.dox
Makefile Search for location of waf script 2019-02-26 10:39:24 +01:00
pyldb_util.c Use python.h from libreplace 2023-11-20 15:37:33 +00:00
pyldb-util.pc.in lib/ldb: Enable use of a python3 pyldb-util system library 2017-03-10 07:31:10 +01:00
pyldb.c Use python.h from libreplace 2023-11-20 15:37:33 +00:00
pyldb.h pyldb: rename pyldb_Dn_AsDn() to pyldb_Dn_AS_DN() 2019-07-10 04:32:13 +00:00
README_gcov.txt
wscript ldb: release 2.9.0 for use in Samba 4.20.x 2024-01-29 14:39:32 +00:00