Daniel Liberman b04e8b7557 s3: ldap client can return NT_STATUS_OK when an error occurs in a paged search. ...

"Inside ads_do_search_all_args(), if the first call to ads_do_paged_search_args()
fails, the proper error status is returned.

But, if the execution is already inside the loop to get all the accounts doing
several calls to ads_do_paged_search_args(), and one of these calls times out,
the status returned is from the *first* call, so success. This causes
net_ads_search() to interpret the return from ads_do_search_retry() as
success and print all the accounts returned, but it’s only a subset."

Also ensure we free previously returned results on error
in subsequent fetches.

https://bugzilla.samba.org/show_bug.cgi?id=10387

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jan 23 01:40:54 CET 2014 on sn-devel-104

2014-01-23 01:40:54 +01:00

..

ads_ldap_protos.h

s3-libads: Remove unused ads_pull_sids_from_extendeddn()

2012-02-23 16:14:19 +11:00

ads_proto.h

s3-libads: Remove unused ads_set_machine_password()

2012-02-23 16:14:19 +11:00

ads_status.c

s3-libads: Map LDAP_TIMELIMIT_EXCEEDED as NT_STATUS_IO_TIMEOUT

2012-05-26 02:03:07 +02:00

ads_status.h

source3/libads/ads_status.h: fix licence/copyright

2011-06-10 15:12:19 +02:00

ads_struct.c

s3-libads: Fix memory leaks in ads_build_path().

2014-01-09 20:42:54 +01:00

authdata.c

auth/gensec: treat struct gensec_security_ops as const if possible.

2013-08-10 09:19:04 +02:00

cldap.c

s3:libads: make use of samba_tevent_context_init()

2013-02-19 23:47:46 +01:00

cldap.h

Add cldap_multi_netlogon_send/recv

2011-10-17 09:52:29 +02:00

disp_sec.c

s3-libndr: add ../librpc/ndr/libndr.h include in some places.

2011-03-31 00:14:01 +02:00

kerberos_keytab.c

s3-libads: Fix copy&paste error in ads_keytab_add_entry().

2012-12-21 13:56:00 +01:00

kerberos_proto.h

Make krb5 wrapper library common so they can be used all over

2012-04-23 19:20:38 -04:00

kerberos_util.c

Avoid overriding default ccache for ads operations.

2012-09-12 21:18:09 +02:00

kerberos.c

s3-libads: Print a message if no realm has been specified.

2013-08-05 12:24:43 +02:00

krb5_errs.c

s3-kerberos: only use krb5 headers where required.

2009-11-27 16:36:00 +01:00

krb5_setpw.c

s3-build: only include asn1 headers where actually needed.

2011-03-16 23:46:18 +01:00

ldap_printer.c

s3:registry: remove usage of reg_objects from libads/ldap_printer.c

2012-04-25 14:11:06 +02:00

ldap_schema.c

s3-talloc Change TALLOC_P() to talloc()

2011-06-09 12:40:08 +02:00

ldap_schema.h

source3/libads/ldap_schema.h: fix licence/copyright

2011-06-10 15:12:22 +02:00

ldap_user.c

s3: avoid global include of ads.h.

2010-08-05 00:32:02 +02:00

ldap_utils.c

lib/param: Move all enum declarations to lib/param

2012-07-24 11:01:17 +02:00

ldap.c

s3: ldap client can return NT_STATUS_OK when an error occurs in a paged search.

2014-01-23 01:40:54 +01:00

ndr.c

lib/param: Move all enum declarations to lib/param

2012-07-24 11:01:17 +02:00

sasl_wrapping.c

s3: avoid global include of ads.h.

2010-08-05 00:32:02 +02:00

sasl.c

Avoid overriding default ccache for ads operations.

2012-09-12 21:18:09 +02:00

sitename_cache.c

Add a talloc context to sitename_fetch().

2013-09-05 09:17:27 -07:00

sitename_cache.h

Add a talloc context to sitename_fetch().

2013-09-05 09:17:27 -07:00

util.c

s3: use generate_random_password() instead of generate_random_str()

2013-02-04 17:14:22 +01:00