1
0
mirror of https://github.com/samba-team/samba.git synced 2025-06-22 07:17:05 +03:00
Andrew Bartlett 530e4cac2e s3-param Remove 'time offset' from smb.conf
This strange parameter is apparently very rarely used, and it seems to
me that on modern networks, if clients don't have correct clocks and
DST offsets, that many other things (Kerberos) start to fail pretty
quickly, and time and DST tables tend to be internet delivered anyway.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun 11 03:54:45 CEST 2011 on sn-devel-104
2011-06-11 03:54:44 +02:00

97 lines
3.0 KiB
C

/*
Unix SMB/CIFS implementation.
util time testing
Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2008
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
#include "torture/torture.h"
static bool test_null_time(struct torture_context *tctx)
{
torture_assert(tctx, null_time(0), "0");
torture_assert(tctx, null_time(0xFFFFFFFF), "0xFFFFFFFF");
torture_assert(tctx, null_time(-1), "-1");
torture_assert(tctx, !null_time(42), "42");
return true;
}
static bool test_null_nttime(struct torture_context *tctx)
{
torture_assert(tctx, null_nttime(-1), "-1");
torture_assert(tctx, null_nttime(-1), "-1");
torture_assert(tctx, !null_nttime(42), "42");
return true;
}
static bool test_http_timestring(struct torture_context *tctx)
{
const char *start = "Thu, 01 Jan 1970";
char *result;
/*
* Correct test for negative UTC offset. Without the correction, the
* test fails when run on hosts with negative UTC offsets, as the date
* returned is back in 1969 (pre-epoch).
*/
time_t now = time(NULL);
struct tm local = *localtime(&now);
struct tm gmt = *gmtime(&now);
time_t utc_offset = mktime(&local) - mktime(&gmt);
result = http_timestring(tctx, 42 - (utc_offset < 0 ? utc_offset : 0));
torture_assert(tctx, !strncmp(start, result,
strlen(start)), result);
torture_assert_str_equal(tctx, "never",
http_timestring(tctx, get_time_t_max()), "42");
return true;
}
static bool test_timestring(struct torture_context *tctx)
{
const char *start = "Thu Jan 1";
char *result;
/*
* Correct test for negative UTC offset. Without the correction, the
* test fails when run on hosts with negative UTC offsets, as the date
* returned is back in 1969 (pre-epoch).
*/
time_t now = time(NULL);
struct tm local = *localtime(&now);
struct tm gmt = *gmtime(&now);
time_t utc_offset = mktime(&local) - mktime(&gmt);
result = timestring(tctx, 42 - (utc_offset < 0 ? utc_offset : 0));
torture_assert(tctx, !strncmp(start, result, strlen(start)), result);
return true;
}
struct torture_suite *torture_local_util_time(TALLOC_CTX *mem_ctx)
{
struct torture_suite *suite = torture_suite_create(mem_ctx, "time");
torture_suite_add_simple_test(suite, "null_time", test_null_time);
torture_suite_add_simple_test(suite, "null_nttime", test_null_nttime);
torture_suite_add_simple_test(suite, "http_timestring",
test_http_timestring);
torture_suite_add_simple_test(suite, "timestring",
test_timestring);
return suite;
}