1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
samba-mirror/source3
Simo Sorce e9e6af5951 r21606: Implement escaping function for ldap RDN values
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs

revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.

- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).

- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.

DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries

DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.

Simo.
(This used to be commit 5b4838f62a)
2007-10-10 12:18:16 -05:00
..
auth r21536: Fix copy/paste typo. 2007-10-10 12:18:11 -05:00
client r21283: Do not display away debug output of cifs dfs resolver by default 2007-10-10 12:17:54 -05:00
codepages r39: * importing .cvsignore files 2007-10-10 10:51:05 -05:00
groupdb r20090: Fix a class of bugs found by James Peach. Ensure 2007-10-10 12:16:24 -05:00
include r21581: Add an error code I just got 2007-10-10 12:18:15 -05:00
iniparser r19928: Fix klokwork id 4509, 4573, 4574. 2007-10-10 12:16:10 -05:00
intl r17345: Some C++ warnings 2007-10-10 11:38:26 -05:00
lib r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
libaddns r21217: Just found a system that does not define in_addr_t but only struct 2007-10-10 12:17:48 -05:00
libads r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
libgpo r20610: Fix a Solaris warning 2007-10-10 12:16:58 -05:00
libmsrpc r20832: Remove extra pointers previously added to unique [out] pointers. Instead, 2007-10-10 12:17:11 -05:00
librpc r21565: Import ndrdump (doesn't compile yet, needs table support functions). 2007-10-10 12:18:14 -05:00
libsmb r21604: I got this wrong also in libsmb :-(. 2007-10-10 12:18:15 -05:00
locking r21257: Better fix for bug #4188 : 2007-10-10 12:17:51 -05:00
modules r21339: Fix the non-linux build. This is more evidence that this needs to be 2007-10-10 12:17:56 -05:00
nmbd r21064: The core of this patch is 2007-10-10 12:17:32 -05:00
nsswitch r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
pam_smbpass r16241: Fix Klocwork #106 and others like it. 2007-10-10 11:17:27 -05:00
param r21547: Fix from Michael Adam <ma@sernet.de>: Refuse registry shares without path. 2007-10-10 12:18:11 -05:00
passdb r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
po r20745: Commit Finnish transalation of SWAT after review 2007-10-10 12:17:08 -05:00
popt r17347: Some C++ warnings -- 271 left 2007-10-10 11:38:27 -05:00
printing r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
profile r21543: Fix 64bit build warning. 2007-10-10 12:18:11 -05:00
python r18801: Fix (at least the build of) python bindings. 2007-10-10 12:00:59 -05:00
registry r21225: Couple of fixes from Martin Zielinski mz@seh.de, 2007-10-10 12:17:48 -05:00
rpc_client r21462: Fix EnumValue (?) 2007-10-10 12:18:06 -05:00
rpc_parse r21507: Fix some "cannot access LDAP when no root" bugs. 2007-10-10 12:18:09 -05:00
rpc_server r21569: Fix bug reported by Martin Zielinski <mz@seh.de> 2007-10-10 12:18:14 -05:00
rpcclient r21320: Display query_user info level 16 in rpcclient. 2007-10-10 12:17:56 -05:00
script r21565: Import ndrdump (doesn't compile yet, needs table support functions). 2007-10-10 12:18:14 -05:00
services r20069: Fix logic bug I introduced 2007-10-10 12:16:23 -05:00
smbd r21603: Horrible backwards compatibility hack as an old server bug 2007-10-10 12:18:15 -05:00
stf r39: * importing .cvsignore files 2007-10-10 10:51:05 -05:00
tdb r21445: Apply tdb_parse_record Tridges error return, merge to 3_0_25 and 4_0 2007-10-10 12:18:04 -05:00
tests r19941: One copy of this code should be sufficient. 2007-10-10 12:16:11 -05:00
torture r21116: Fix the build -- sorry! 2007-10-10 12:17:39 -05:00
utils r21606: Implement escaping function for ldap RDN values 2007-10-10 12:18:16 -05:00
web r17873: Fix possible null deref found by Stanford checker. 2007-10-10 11:38:56 -05:00
.dmallocrc
.indent.pro r11131: updating indent resource file from trunk 2007-10-10 11:05:01 -05:00
.valgrind_suppressions r19062: try to fix the valgrind noise in the build-farm 2007-10-10 12:15:07 -05:00
aclocal.m4 r21467: Add GPFS-provided DMAPI support based on their GPL library 2007-10-10 12:18:06 -05:00
autogen.sh r18644: bring in libreplace in lib/replace 2007-10-10 11:52:03 -05:00
change-log
config.guess r11375: Update to the latest config.guess and config.sub files. 2007-10-10 11:05:14 -05:00
config.sub r11375: Update to the latest config.guess and config.sub files. 2007-10-10 11:05:14 -05:00
configure.developer r18373: copy over configure.developer from samba4 which adds 2007-10-10 11:51:20 -05:00
configure.in r21605: Fix small typo noticed by Raúl Sánchez Siles <rss@barracuda.es>. 2007-10-10 12:18:16 -05:00
Doxyfile r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need 2007-10-10 11:19:14 -05:00
dynconfig.c r15848: Introduce commandline options to set the remainder of the parameters in 2007-10-10 11:17:11 -05:00
install-sh
mainpage.dox
Makefile.in r21565: Import ndrdump (doesn't compile yet, needs table support functions). 2007-10-10 12:18:14 -05:00
samba3-knownfail r19552: Fix names of known failing tests. 2007-10-10 12:15:41 -05:00
smbadduser.in r13384: Adding in some more SuSE patches 2007-10-10 11:09:57 -05:00
TODO r18188: merge 3.0-libndr branch 2007-10-10 11:43:56 -05:00
VERSION r21157: this is 3.0.26 trunk 2007-10-10 12:17:44 -05:00