1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/librpc
Andrew Bartlett f7f92803f6 librpc: Check for NULL pointer in value() in ntlmssp_AUTHENTICATE
This allows ndrdump --validate to avoid following a NULL pointer when re-pushing
a valid but unusual input.

It also avoids an issue if the Samba server code were to provide a response
without an EncryptedRandomSessionKey.

At this stage ntlmssp.idl is not used for this, instead the packets are
generated with msrpc_gen().

Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
fuzzer.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 20 06:06:29 UTC 2019 on sn-devel-184
2019-11-20 06:06:29 +00:00
..
ABI ndr: Include the caller location in ndr_{pull,push}_error() messages 2019-11-19 14:47:46 +00:00
gen_ndr waf-idl: put the gen_ndr/README file for source3 back 2010-07-19 22:17:17 +10:00
idl librpc: Check for NULL pointer in value() in ntlmssp_AUTHENTICATE 2019-11-20 06:06:29 +00:00
ndr ndr_orpc: properly allocate empty DUALSTRINGARRAY 2019-11-20 04:41:28 +00:00
rpc librpc: Unify packet dumping on ndr_pull() failure 2019-11-20 02:14:56 +00:00
tools ndrdump: Still print --dump bytes after parse failure 2019-11-20 04:41:28 +00:00
binding-strings.txt docs: Document DCEPRC binding string for rpcclient 2019-02-04 02:03:56 +01:00
ndr_krb5pac.pc.in build: correct package dependencies 2017-04-18 18:54:13 +02:00
ndr_nbt.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
ndr_standard.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
ndr.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
tables.pl librpc/tables.pl: remove unused $opt_output option 2018-11-20 01:33:35 +01:00
wscript_build ndr: Include the caller location in ndr_{pull,push}_error() messages 2019-11-19 14:47:46 +00:00