mirror of
https://github.com/samba-team/samba.git
synced 2025-11-15 16:23:49 +03:00
I had previously thought this was unnecessary, as windows doesn't use standards compliant UTF-16, and for filesystem operations treats bytes as UCS-2, but Bjoern Jacke has pointed out to me that this means we don't correctly store extended UTF-16 characters as UTF-8 on disk. This can be seen with (for example) the gothic characters with codepoints above 64k. This commit also adds a LOCAL-ICONV torture test that tests the first 1 million codepoints against the system iconv library, and tests 5 million random UTF-16LE buffers for identical error handling to the system iconv library. the lib/iconv.c changes need backporting to samba3
-
Design notes for client library restructure: 1 - no references to cli_state should exist in libcli/raw. 2 - all interfaces to functions in this directory should use cli_session or cli_tree as the primary context structure