mirror of
https://github.com/samba-team/samba.git
synced 2025-01-26 10:04:02 +03:00
ee8f481d94
This fixes the following bug: While we reply with a WACK response to a client. Instead of waiting for the final reply some windows client just resends the request using the same name_trn_id in the nbt_name_packet. We handled this as a new request and send a WACK response (and the challenges) again. Then the first request gets its final success response, but the when we try to send the success for the "second" request we notice that the record was changed in between and we return an error. Windows 2003 (and I assume all other versions as well) detect the packet is just a resent of a currently pending request and ignores it. So we now keep a list of all pending WINS name register requests which result in a WACK response. On each incoming name register request we search through the list to find duplicate requests and ignore them. In theory we should do that for all requests, but name register requests are the only requests we response async and only if we have to go via the WACK code path. metze (from samba4wins tree 382e7d384b70d03e9f81c7bb353afaed288d80f0)