1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
samba-mirror/source3/smbd
Jeremy Allison e05c9cdcb6 Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB
We were not correctly checking the output of asn1_start_tag().
asn1_start_tag() returns -1 and sets data->has_error if the
remaining blob size is too short to contain the tag length.
We were checking data->has_error and returning NT_STATUS_OK
(to allow the second asn.1 parse to fail in that case). We
should not be checking data->has_error in this case, but
falling through to the code that already checks the length.

Thanks to Jim for reproducing this for me. We don't get bitten
by this as we announce a max buffer size of 16k, greater than
Windows's 4k, which means that most krb5 spnego packets already
fit.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 27 02:57:27 CEST 2011 on sn-devel-104
2011-05-27 02:57:27 +02:00
..
aio.c Fixup build without --with-aio. 2011-05-05 21:38:23 +02:00
avahi_register.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
blocking.c Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
close.c s3-messages: make ndr_messaging.h part of messages.h. 2011-03-30 01:13:09 +02:00
conn.c s3-proto: move more headers to rpc_server/rpc_ncacn_np.h where they origin from. 2011-04-29 22:05:07 +02:00
connection.c s3-auth: smbd needs auth.h 2011-03-30 01:13:09 +02:00
dfree.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
dir.c s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 2011-04-29 16:38:13 +10:00
dmapi.c More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
dnsregister.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
dosmode.c s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 2011-04-29 16:38:13 +10:00
error.c s3-smbd ntstatus_to_dos() pulls the DOS error codes out internally 2011-05-06 07:51:24 +02:00
fake_file.c s3-auth: smbd needs auth.h 2011-03-30 01:13:09 +02:00
file_access.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
fileio.c s3-smb Use FILE_ATTRIBUTE_ARCHIVE intead of aARCH 2011-04-29 16:38:13 +10:00
filename.c More const fixes. Remove CONST_DISCARD. 2011-05-06 01:44:07 +02:00
files.c s3: only include tdb headers where needed. 2011-05-06 10:48:10 +02:00
globals.c s3-smbd: expose smbd_set_server_fd() 2011-05-08 12:01:13 +02:00
globals.h s3: only include tdb headers where needed. 2011-05-06 10:48:10 +02:00
ipc.c Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
lanman.c s3-lib Replace StrCaseCmp() with strcasecmp_m() 2011-05-18 16:12:08 +02:00
mangle_hash2.c Simple +1 changes in hardcoded lengths when changing from safe_strcpy to strlcpy. 2011-05-04 12:12:14 -07:00
mangle_hash.c s3: only include tdb headers where needed. 2011-05-06 10:48:10 +02:00
mangle.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
message.c s3: only include smb profiling where needed. 2011-04-14 01:31:39 +02:00
msdfs.c More simple const fixes. 2011-05-05 23:56:07 +02:00
msg_idmap.c s3-build: remove some unused headers. 2011-04-29 12:19:03 +02:00
negprot.c s3: Fork the echo handler only after SMB1 negprot is done 2011-05-20 15:06:03 +02:00
noquotas.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
notify_inotify.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
notify_internal.c s3: only include tdb headers where needed. 2011-05-06 10:48:10 +02:00
notify.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
ntquotas.c s3-libsmb: move protos to libsmb/proto.h 2011-05-06 16:37:18 +02:00
nttrans.c s3-libsmb: move protos to libsmb/proto.h 2011-05-06 16:37:18 +02:00
open.c Fix the SMB2 showstopper, found by an extended torture test from Volker. 2011-05-16 22:38:20 +02:00
oplock_irix.c s3-smbd: try to fix the irix build. 2011-03-30 17:17:58 +02:00
oplock_linux.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
oplock_onefs.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
oplock.c s3-messages: make ndr_messaging.h part of messages.h. 2011-03-30 01:13:09 +02:00
password.c s3-auth: fixed bug with usernames longer than sizeof(char *) 2011-05-06 14:49:47 +10:00
perfcount.c Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
pipes.c Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00
posix_acls.c Fix bug #7996 - sgid bit lost on folder rename. 2011-03-30 18:01:19 -07:00
process.c s3:smbd remove unused code 2011-05-20 16:18:24 +02:00
proto.h s3: Fork the echo handler only after SMB1 negprot is done 2011-05-20 15:06:03 +02:00
quotas.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
reply.c Optimization. If the attributes passed to can_rename() include both FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM then there's no point in reading the source DOS attribute, as we're not going to deny the rename on attribute match. 2011-05-20 09:18:13 -07:00
seal.c s3-libsmb: move protos to libsmb/proto.h 2011-05-06 16:37:18 +02:00
sec_ctx.c s3: only include smb profiling where needed. 2011-04-14 01:31:39 +02:00
server_exit.c s3: include ntdomain.h before including generated srv_ headers. 2011-05-02 15:03:44 +02:00
server_reload.c s3-messages: make ndr_messaging.h part of messages.h. 2011-03-30 01:13:09 +02:00
server.c s3-lib Replace StrCaseCmp() with strcasecmp_m() 2011-05-18 16:12:08 +02:00
service.c s3-tsocket: only include ../lib/tsocket/tsocket.h where needed. 2011-04-29 12:19:04 +02:00
session.c s3-auth: smbd needs auth.h 2011-03-30 01:13:09 +02:00
sesssetup.c Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB 2011-05-27 02:57:27 +02:00
share_access.c s3-auth: smbd needs auth.h 2011-03-30 01:13:09 +02:00
signing.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
smb2_break.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_close.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
smb2_create.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_find.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_flush.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_getinfo.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_glue.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
smb2_ioctl.c s3-proto: move more rpc_server prototypes out of proto.h 2011-05-02 15:03:43 +02:00
smb2_keepalive.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
smb2_lock.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_negprot.c s3: Fix a typo 2011-05-05 16:10:35 +02:00
smb2_notify.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_read.c s3-proto: move more rpc_server prototypes out of proto.h 2011-05-02 15:03:43 +02:00
smb2_server.c s3: Slightly simplify smbd_smb2_request_next_vector 2011-05-12 11:48:29 +02:00
smb2_sesssetup.c More simple const fixes. 2011-05-05 23:56:07 +02:00
smb2_setinfo.c s3-tevent: only include ../lib/util/tevent wrappers where needed. 2011-04-29 14:00:30 +02:00
smb2_signing.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
smb2_tcon.c More simple const fixes. 2011-05-05 23:56:07 +02:00
smb2_write.c s3-proto: move more rpc_server prototypes out of proto.h 2011-05-02 15:03:43 +02:00
smbd.h s3-locking: move locking prototypes out of proto.h. 2011-03-30 01:13:09 +02:00
srvstr.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
statcache.c s3: only include tdb headers where needed. 2011-05-06 10:48:10 +02:00
statvfs.c s3: include smbd/smbd.h where needed. 2011-03-30 01:13:08 +02:00
trans2.c Fix bug 8133 - strange behavior for the file (whose filename first character is period ) in SMB2 case. 2011-05-20 19:26:03 +02:00
uid.c s3-smbd: avoid using pipes_struct when only session_info is needed. 2011-05-02 15:03:43 +02:00
utmp.c s3: try to fix the build on some non-linux buildfarm machines. 2011-03-30 11:39:31 +02:00
vfs.c Fix many const compiler warnings. 2011-05-05 10:41:59 -07:00