1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/librpc
Douglas Bagnall 3be368ff2b ndr: always attempt ACE coda pull if ACE type suggests a coda
We were skipping the pull in cases where the coda size was calculated
to be zero. This has the right result for empty conditional ACEs, but
not for Resource Attribute ACEs where the
CLAIM_SECURITY_ATTRIBUTE_RELATIVE_V1 coda was not intialised.

The situation is made a bit worse, because the function that
calculates the coda size (ndr_subcontext_size_of_ace_coda()) can
return zero in conditions that are not exactly errors, but in which
the would-be calculated value makes so little sense that zero is
thought to be a safer default.

Credit to OSS-Fuzz.

REF: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66577
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15613

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Mar 25 06:00:21 UTC 2024 on atb-devel-224

(cherry picked from commit 6fb98f70c6)

Autobuild-User(v4-20-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-20-test): Tue Mar 26 11:17:58 UTC 2024 on atb-devel-224
2024-03-26 11:17:58 +00:00
..
ABI librpc: Change type of ‘u16string’ from ‘const uint16_t *’ to ‘const unsigned char *’ 2023-12-21 23:48:46 +00:00
gen_ndr
idl librpc:idl: Make netlogon_samlogon_response public 2024-03-01 07:43:08 +00:00
ndr ndr: always attempt ACE coda pull if ACE type suggests a coda 2024-03-26 11:17:58 +00:00
rpc dcesrv_reply: just drop responses if the connection is already terminating 2024-01-09 11:26:55 +00:00
tests librpc: Change type of ‘u16string’ from ‘const uint16_t *’ to ‘const unsigned char *’ 2023-12-21 23:48:46 +00:00
tools librpc:ndr: Introduce ‘ndr_flags_type’ type 2023-11-01 20:10:45 +00:00
wsp librpc: Fix #define header guard 2023-11-10 01:36:43 +00:00
binding-strings.txt docs: Document DCEPRC binding string for rpcclient 2019-02-04 02:03:56 +01:00
ndr_krb5pac.pc.in build: correct package dependencies 2017-04-18 18:54:13 +02:00
ndr_nbt.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
ndr_standard.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
ndr.pc.in pkgconfig: Do not hardcode library version numbers in pc files. 2013-08-22 20:48:44 +02:00
tables.pl librpc/tables.pl: remove unused $opt_output option 2018-11-20 01:33:35 +01:00
wscript_build s3:rpcd_witness.idl: introduce definitions for rpcd_witness_registration.tdb records 2024-01-26 17:00:33 +00:00