John Mulligan f5d04a43cf python:join: fix reused variable name in provision func ... Recent updates to run adprep during the provision function re-used a variable name that was already in use as a string. This reassignment changed the type of the referenced object. This variable name is later used to setup the mit krb5 kdc conf and expects the var to contain a string. When executed with default cli options on a mit krb5 based build samba tool fails with a traceback: ``` INFO 2023-03-23 21:22:50,399 pid:6 /usr/lib64/python3.10/site-packages/samba/provision/__init__.py #2021: Fixing provision GUIDs ERROR(<class 'AttributeError'>): uncaught exception - 'DomainUpdate' object has no attribute 'upper' File "/usr/lib64/python3.10/site-packages/samba/netcmd/__init__.py", line 230, in _run return self.run(*args, **kwargs) File "/usr/lib64/python3.10/site-packages/samba/netcmd/domain.py", line 555, in run result = provision(self.logger, File "/usr/lib64/python3.10/site-packages/samba/provision/__init__.py", line 2408, in provision create_kdc_conf(paths.kdcconf, realm, domain, os.path.dirname(lp.get("log file"))) File "/usr/lib64/python3.10/site-packages/samba/provision/kerberos.py", line 43, in create_kdc_conf domain = domain.upper() ``` This change removes the re-use of the existing var name by chaining the calls. Fixes: 4bba26579d Signed-off-by: John Mulligan <jmulligan@redhat.com> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Apr 5 02:02:29 UTC 2023 on atb-devel-224		2023-04-05 02:02:29 +00:00
..
examples	python: Remove redundant assignments	2022-05-10 05:19:34 +00:00
samba	python:join: fix reused variable name in provision func	2023-04-05 02:02:29 +00:00
modules.c	py3: Remove PyStr_FromString() compatability macro	2019-06-24 17:24:27 +00:00
modules.h	python: Create macro to hide ugly function signature cast	2019-05-16 17:55:16 +00:00
py3compat.h	py3compat: remove obsolete comments	2021-03-17 17:10:32 +00:00
pyglue.c	python: whitespace fixes	2022-10-03 20:03:32 +00:00
wscript	python/wscript: Remove unused format() argument	2022-05-10 05:19:34 +00:00