sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code
samba-mirror/source3/smbd
History
Ralph Boehme fc6eba619e smbd: SMB2 Compound related chain handling when generation of FileId has failed 
Issue:
We have a scenario where an application sends a Compound Related chain
consisting of:
SMB2_CREATE
SMB2_IOCTL
SMB2_SET_INFO
SMB2_CLOSE

SMB2_CREATE failed with NT_STATUS_ACCESS_DENIED and subsequent
requests all fail. In Samba they return NT_STATUS_FILE_CLOSED.

When I tried the same against a Win2k12 server, I noticed that all the
failed requests of the chain would return NT_STATUS_ACCESS_DENIED.

I believe this behaviour is also mentioned in the [MS-SMB2] Specs
3.3.5.2.7.2: Handling Compounded Related Requests

"When the current operation requires a FileId and the previous
operation either contains or generates a FileId, if the previous
operation fails with an error, the server SHOULD<223> fail the current
operation with the same error code returned by the previous
operation."

Fix:
Save NTATUS of a failed Create request. When we process subsequent
requests of the chain we check if the previous Create has failed. In
case of a Create failure we returned the saved NTSTATUS.

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr  8 17:30:50 UTC 2021 on sn-devel-184
2021-04-08 17:30:50 +00:00
..
notifyd
smbd: Fix the 32-bit build on FreeBSD
2020-11-30 22:24:38 +00:00
aio.c
smbd: use fh_[get|set]_pos() and fh_[get|set]_position_information()
2020-12-16 09:08:30 +00:00
avahi_register.c
s3-smbd: use fruit:model string for mDNS registration
2019-01-15 21:27:20 +01:00
blocking.c
locking: Make share_mode_watch_send() take "share_mode_lock"
2020-11-10 19:49:34 +00:00
close.c
smbd: use real dirfsp with SMB_VFS_UNLINKAT() in rmdir_internals()
2021-01-28 08:11:49 +00:00
conn_idle.c
smbd: In conn_force_tdis_done() when forcing a connection closed force a full reload of services.
2021-01-28 07:03:30 +00:00
conn_msg.c
smbd: Add close-denied-share message
2020-01-15 21:25:35 +00:00
conn.c
s3: smbd: Factor out setting up case parameters for a share to a function - conn_setup_case_options().
2021-01-13 17:02:34 +00:00
connection.c
s3:param: make "servicename" a substituted option
2019-11-27 10:25:37 +00:00
dfree.c
smbdotconf: mark "dfree command" with substitution="1"
2019-11-27 10:25:32 +00:00
dir.c
smbd: don't return NT_STATUS_STOPPED_ON_SYMLINK in openat_pathref_fsp()
2021-02-05 06:22:35 +00:00
dmapi.c
Convert all uses of uint8/16/32 to _t in source3/smbd.
2015-05-06 04:14:14 +02:00
dnsregister.c
…
dosmode.c
dosmode: retry reading dos attributes as root for unreadable files
2021-03-24 20:31:30 +00:00
durable.c
s3:smbd: let vfs_default_durable_reconnect() use file_free()
2021-01-14 11:30:38 +00:00
error.c
s3:smbd: Fix converity warning with _smb_setlen_large()
2018-05-16 21:30:23 +02:00
fake_file.c
smbd: use fh_[get|set]_pos() and fh_[get|set]_position_information()
2020-12-16 09:08:30 +00:00
fd_handle_private.h
vfs: make struct fd_handle private
2020-12-16 09:08:30 +00:00
fd_handle.c
vfs: make struct fd_handle private
2020-12-16 09:08:30 +00:00
fd_handle.h
smbd: add fd_handle.[c|h]
2020-12-16 09:08:30 +00:00
file_access.c
s3: smbd: Change SMB_VFS_GET_NT_ACL() -> SMB_VFS_GET_NT_ACL_AT() in directory_has_default_acl().
2020-05-07 19:27:36 +00:00
fileio.c
smbd: use fdos_mode() in mark_file_modified()
2020-12-16 09:08:31 +00:00
filename.c
smbd: reduce loglevel for failed openat_pathref_fsp() calls
2021-04-06 14:39:46 +00:00
files.c
s3: smbd: Fix parent_pathref() to cope with symlink parents.
2021-04-07 15:39:45 +00:00
globals.c
smbd: let smbd_request_guid() use smb1req->xconn->channel_id
2021-03-06 02:20:05 +00:00
globals.h
smbd: SMB2 Compound related chain handling when generation of FileId has failed
2021-04-08 17:30:50 +00:00
ipc.c
Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"
2019-01-11 23:11:16 +01:00
lanman.c
printing: Move rap2jobid functions to their own file
2021-03-16 17:09:31 +00:00
mangle_hash2.c
smbd: Save 520 bytes of writable memory from every smbd
2019-10-23 02:37:12 +00:00
mangle_hash.c
smbd: Convert valid.dat to C code
2015-03-24 00:00:20 +01:00
mangle.c
smbdotconf: mark "mangling method" with constant="1"
2019-11-27 10:25:37 +00:00
message.c
smbdotconf: mark "message command" with substitution="1"
2019-11-27 10:25:35 +00:00
msdfs.c
smbd: use real dirfsp for SMB_VFS_UNLINKAT() in remove_msdfs_link()
2021-01-28 08:11:49 +00:00
negprot.c
s3: safe_string: do not include string_wrappers.h
2020-08-28 00:56:34 +00:00
notify_fam.c
smbd: Allow passing notify filter from inotify and fam
2016-07-18 15:14:11 +02:00
notify_inotify.c
smbd: Align two integer types
2020-11-04 18:55:39 +00:00
notify_msg.c
notifyd: Factor out notify_walk() into its own file
2020-10-24 05:57:31 +00:00
notify.c
smbd/notify: add option "honor change notify privilege"
2020-12-17 15:01:53 +00:00
ntquotas.c
smbd: add twrp arg to synthetic_smb_fname()
2020-05-05 19:18:40 +00:00
nttrans.c
s3: smbd: Fix SMB_VFS_FGET_NT_ACL/SMB_VFS_FSET_NT_ACL on stream handles.
2021-03-30 20:14:35 +00:00
open.c
smbd: cancel pending poll open timer in poll_open_done()
2021-03-18 16:52:37 +00:00
oplock_linux.c
smbd: use fh_[get|set]_gen_id()
2020-12-16 09:08:30 +00:00
oplock.c
smbd: use fh_[get|set]_gen_id()
2020-12-16 09:08:30 +00:00
password.c
smbd: RIP user_struct
2020-01-13 21:09:01 +00:00
perfcount.c
smbdotconf: mark "perfcount module" with substitution="1"
2019-11-27 10:25:36 +00:00
pipes.c
smbd: use fsp_set_fd()
2020-12-16 09:08:30 +00:00
posix_acls.c
s3/smbd: posix_acls SMB_VFS_SETXATTR -> SMB_VFS_FSETXATTR
2021-03-11 17:50:30 +00:00
process.c
smbd: introduce a smbXsrv_connection_destructor()
2021-03-06 02:20:05 +00:00
proto.h
s3/smbd: Remove connection_struct from get_ea_names_from_file
2021-02-26 21:28:33 +00:00
pysmbd.c
s3:pysmbd: fix fd leak in py_smbd_create_file()
2021-02-10 14:00:32 +00:00
quotas.c
quotas: Check group quota for directory when SGID is set
2019-08-14 16:27:43 +00:00
reply.c
smbd: make use of smb2_signing_key_{copy,sign_create,cipher_create}() helpers
2021-03-17 00:49:32 +00:00
scavenger.c
smbd: Use share_mode_servicepath() in scavenger.c
2020-11-10 19:49:35 +00:00
scavenger.h
…
seal.c
auth: Always supply both the remote and local address to the auth subsystem
2017-03-29 02:37:26 +02:00
sec_ctx.c
s3:smbd: Fix incorrect use of sys_getgroups()
2017-04-18 15:43:02 +02:00
server_exit.c
lib: give global_contexts.c its own header file
2021-01-08 20:31:33 +00:00
server_reload.c
printing: Introduce printer_list_printername_exists()
2021-03-16 17:09:31 +00:00
server.c
smbd: Factor out a bool expr into a descriptive variable
2021-04-01 19:32:36 +00:00
service.c
s3: smbd: Factor out setting up case parameters for a share to a function - conn_setup_case_options().
2021-01-13 17:02:34 +00:00
session.c
s3:smbd: fix SAFE_FREE() vs. TALLOC_FREE() in list_sessions()
2019-03-28 23:09:33 +00:00
sesssetup.c
smbd: make use of smb2_signing_key_{copy,sign_create,cipher_create}() helpers
2021-03-17 00:49:32 +00:00
share_access.c
s3:smbd: Fix possible null pointer dereference in token_contains_name()
2020-11-12 15:13:47 +00:00
signing.c
s3:smbd: Return NTSTATUS for srv_calculate_sign_mac()
2019-05-21 00:03:22 +00:00
smb1_utils.c
smbd: add need_fsa arg and logic to file_find_di_(first|next)
2020-12-16 09:08:31 +00:00
smb1_utils.h
lib: Move send_keepalive() to smbd/smb1_utils.c
2020-08-17 19:35:37 +00:00
smb2_break.c
s3:smbd: pass down smbXsrv_client to smbd_smb2_send_{oplock,lease}_break()
2020-07-08 15:54:40 +00:00
smb2_close.c
smbd: don't return NT_STATUS_STOPPED_ON_SYMLINK in openat_pathref_fsp()
2021-02-05 06:22:35 +00:00
smb2_create.c
smbd: SMB2 Compound related chain handling when generation of FileId has failed
2021-04-08 17:30:50 +00:00
smb2_flush.c
smbd: use fsp_get_io_fd() when accessing a file or it's associated metadata
2020-12-16 09:08:30 +00:00
smb2_getinfo.c
smbd: use fsp_get_pathref_fd() for fstat() calls
2020-12-16 09:08:30 +00:00
smb2_glue.c
s3:smbd: implement FSCTL_SMBTORTURE_FORCE_UNACKED_TIMEOUT
2020-07-08 15:54:40 +00:00
smb2_ioctl_dfs.c
s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.
2018-03-22 02:15:13 +01:00
smb2_ioctl_filesys.c
vfs: SMB_VFS_GET_COMPRESSION() -> SMB_VFS_FGET_COMPRESSION()
2020-12-16 09:08:32 +00:00
smb2_ioctl_named_pipe.c
Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"
2019-01-11 23:11:16 +01:00
smb2_ioctl_network_fs.c
smbd: Align integer types
2020-11-10 19:49:33 +00:00
smb2_ioctl_private.h
smbd: implement FSCTL_SMBTORTURE_IOCTL_RESPONSE_BODY_PADDING8 as reproducer for bug 14607
2021-01-15 07:26:29 +00:00
smb2_ioctl.c
smbd: implement FSCTL_SMBTORTURE_IOCTL_RESPONSE_BODY_PADDING8 as reproducer for bug 14607
2021-01-15 07:26:29 +00:00
smb2_keepalive.c
s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.
2018-03-22 02:15:13 +01:00
smb2_lock.c
locking: Make share_mode_watch_send() take "share_mode_lock"
2020-11-10 19:49:34 +00:00
smb2_negprot.c
smb2_negotiate: maintain xconn->smb2.server.sign_algo
2021-03-17 00:49:32 +00:00
smb2_notify.c
smbd: Use NT_STATUS_NOTIFY_ENUM_DIR instead of STATUS_NOTIFY_ENUM_DIR
2020-06-22 12:07:38 +00:00
smb2_query_directory.c
smbd: pass a dirfsp to fd_open() and rename it to fd_openat()
2020-12-16 09:08:30 +00:00
smb2_read.c
s3:smbd: add smbd_smb2_send_queue.sendfile_body_size
2020-07-08 15:54:40 +00:00
smb2_server.c
smbd: SMB2 Compound related chain handling when generation of FileId has failed
2021-04-08 17:30:50 +00:00
smb2_sesssetup.c
smb2_sesssetup: validate that sign_algo and encryption_cipher match on a session bind
2021-03-17 01:56:37 +00:00
smb2_setinfo.c
s3: smbd: fix deferred renames
2021-03-31 06:13:39 +00:00
smb2_tcon.c
smb2_tcon: also try to cancel pending compound requests on tdis
2021-03-29 20:43:28 +00:00
smb2_write.c
s3:smb2_write: add missing initialization of state->in_offset
2019-03-28 23:09:33 +00:00
smbd_cleanupd.c
smbd: Remove unused brlock code
2019-06-20 17:18:19 +00:00
smbd_cleanupd.h
smbd: Implement a cleanup daemon
2015-11-16 14:51:33 +01:00
smbd.h
smbd: add fd_handle.[c|h]
2020-12-16 09:08:30 +00:00
smbXsrv_client.c
smbXsrv_client: move the connection passing to smb2srv_client_mc_negprot_send/recv
2021-03-06 03:30:06 +00:00
smbXsrv_open.c
smbXsrv_open: intruduce smbXsrv_open_replay_cache to support FILE_NOT_AVAILABLE
2021-03-29 19:36:37 +00:00
smbXsrv_session.c
smbXsrv_session: always cancel pending requests in smb2srv_session_shutdown_send() in the same way
2021-03-29 19:36:37 +00:00
smbXsrv_tcon.c
smbXsrv_tcon: explicitly set tcon->db_rec = NULL after tcon->db_rec = local_rec
2021-03-06 02:20:05 +00:00
smbXsrv_version.c
lib: Pass mem_ctx to lock_path()
2018-08-17 11:30:10 +02:00
srvstr.c
s3: safe_string: do not include string_wrappers.h
2020-08-28 00:56:34 +00:00
statcache.c
smbd: strip @GMT token in canonicalize_snapshot_path()
2020-05-05 19:18:43 +00:00
statvfs.c
statvfs: rename linux_statvfs to posix_statvfs
2019-01-11 02:53:57 +01:00
trans2.c
s3: smbd: Change SMB_VFS_REMOVEXATTR -> SMB_VFS_FREMOVEXATTR.
2021-04-07 16:26:28 +00:00
uid.c
smbd: call set_current_user_info() in smbd_become_authenticated_pipe_user()
2021-03-12 00:54:01 +00:00
utmp.c
s3/smbd: fix utmp hostname logging on Solaris
2019-01-10 22:46:11 +01:00
vfs.c
VFS: Remove SMB_VFS_REMOVEXATTR, no longer used
2021-04-07 16:26:28 +00:00