Stefan Metzmacher 99673b77b0 s3:idmap_hash: reliable return ID_TYPE_BOTH ...

idmap_hash used to bounce back the requested type,
which was ID_TYPE_UID, ID_TYPE_GID or ID_TYPE_NOT_SPECIFIED
before as the winbindd parent always used a lookupsids.
When the lookupsids failed because of an unknown domain,
the idmap child weren't requested at all and the caller
sees ID_TYPE_NOT_SPECIFIED.

This module should have supported ID_TYPE_BOTH since
samba-4.1.0, similar to idmap_rid and idmap_autorid.

Now that the winbindd parent will pass ID_TYPE_BOTH in order to
indicate that the domain exists, it's better to always return
ID_TYPE_BOTH instead of a random mix of ID_TYPE_UID, ID_TYPE_GID
or ID_TYPE_BOTH. In order to request a type_hint it will return
ID_REQUIRE_TYPE for ID_TYPE_NOT_SPECIFIED, which means that
the parent at least assures that the domain sid exists.
And the caller still gets ID_TYPE_NOT_SPECIFIED if the
domain doesn't exist.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14539

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jan 22 11:32:46 UTC 2021 on sn-devel-184

(cherry picked from commit d8339056eef2845805f573bd8b0f3323370ecc8f)
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(v4-14-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-14-test): Wed Jan 27 17:06:51 UTC 2021 on sn-devel-184

2021-01-27 17:06:50 +00:00

..

idmap_hash

s3:idmap_hash: reliable return ID_TYPE_BOTH

2021-01-27 17:06:50 +00:00

idmap_ad_nss.c

winbindd/idmap: apply const to struct nss_info_methods pointers

2020-10-23 03:25:35 +00:00

idmap_ad.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_autorid_tdb.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

idmap_autorid.c

winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE

2020-10-23 03:25:37 +00:00

idmap_ldap.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

idmap_nss.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_passdb.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_proto.h

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_rfc2307.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

idmap_rid.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_rw.c

winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE

2020-10-23 03:25:37 +00:00

idmap_rw.h

…

idmap_script.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_tdb2.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_tdb_common.c

winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE

2020-10-23 03:25:37 +00:00

idmap_tdb_common.h

…

idmap_tdb.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

idmap_util.c

…

idmap.c

winbindd/idmap: apply const to struct idmap_methods pointers

2020-10-23 03:25:35 +00:00

nss_info_template.c

…

nss_info.c

winbindd/idmap: apply const to struct nss_info_methods pointers

2020-10-23 03:25:35 +00:00

wb_dsgetdcname.c

winbind: Fix an error path memleak

2019-02-27 01:35:18 +01:00

wb_getgrsid.c

…

wb_getpwsid.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

wb_gettoken.c

…

wb_group_members.c

…

wb_lookupname.c

winbind: Pass upn unmodified to lookup names

2018-05-11 09:07:36 +02:00

wb_lookupsid.c

winbindd: Use dom_sid_str_buf

2018-12-20 23:40:25 +01:00

wb_lookupsids.c

winbind: Use dom_sid_str_buf

2018-11-27 07:13:14 +01:00

wb_lookupuseraliases.c

…

wb_lookupusergroups.c

winbindd: Use dom_sid_str_buf

2018-11-02 21:21:15 +01:00

wb_next_grent.c

…

wb_next_pwent.c

…

wb_query_group_list.c

…

wb_query_user_list.c

winbind: Fix "wbint_Principals" definition

2018-11-27 07:13:14 +01:00

wb_queryuser.c

wb_queryuser: explain why wb_parent_idmap_setup_send/recv is not needed

2020-10-23 03:25:36 +00:00

wb_seqnum.c

…

wb_seqnums.c

…

wb_sids2xids.c

wb_sids2xids: defer/skip wb_lookupsids* unless we get ID_TYPE_WB_REQUIRE_TYPE

2020-10-23 04:47:26 +00:00

wb_xids2sids.c

wb_xids2sids: make use of the new wb_parent_idmap_setup_send/recv() helpers

2020-10-23 03:25:36 +00:00

winbindd_ads.c

winbind: Fix a memleak

2020-09-14 13:33:13 +00:00

winbindd_ads.h

…

winbindd_allocate_gid.c

…

winbindd_allocate_uid.c

…

winbindd_async.c

…

winbindd_cache.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_ccache_access.c

Fix spelling mistakes

2018-11-30 03:35:13 +01:00

winbindd_change_machine_acct.c

…

winbindd_check_machine_acct.c

…

winbindd_cm.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_cred_cache.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_creds.c

winbind: Fix UPN handling in parse_domain_user()

2018-05-11 09:07:37 +02:00

winbindd_domain_info.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_domain.c

…

winbindd_dsgetdcname.c

winbind: Align integer types

2020-11-30 22:24:37 +00:00

winbindd_dual_ndr.c

librpc/dcesrv_core: move two rpcint_dispatch() copies into dcesrv_call_dispatch_local()

2020-10-23 16:02:37 +00:00

winbindd_dual_srv.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_dual.c

winbind: handle MSG_SMB_CONF_UPDATED in the winbinds children

2021-01-27 16:00:06 +00:00

winbindd_endgrent.c

…

winbindd_endpwent.c

…

winbindd_getdcname.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_getgrent.c

s3:winbind: Log client process name

2018-11-12 09:50:25 +01:00

winbindd_getgrgid.c

winbindd: handling missing idmap in getgrgid()

2020-02-05 17:56:58 +00:00

winbindd_getgrnam.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_getgroups.c

winbindd: allow idmap backends to mark entries with ID_[TYPE_WB_]REQUIRE_TYPE

2020-10-23 03:25:37 +00:00

winbindd_getpwent.c

s3:winbind: Log client process name

2018-11-12 09:50:25 +01:00

winbindd_getpwnam.c

winbindd: Use dom_sid_str_buf

2018-12-20 23:40:25 +01:00

winbindd_getpwsid.c

winbindd: Use dom_sid_str_buf

2018-12-20 23:40:25 +01:00

winbindd_getpwuid.c

winbindd: Use dom_sid_str_buf

2018-12-20 23:40:25 +01:00

winbindd_getsidaliases.c

winbindd: Use dom_sid_str_buf

2018-12-07 23:29:01 +01:00

winbindd_getuserdomgroups.c

winbindd: Use dom_sid_str_buf

2018-12-07 23:29:01 +01:00

winbindd_getusersids.c

winbindd: Use dom_sid_str_buf

2018-12-20 23:40:25 +01:00

winbindd_gpupdate.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_group.c

s3-winbindd: use fill_domain_username_talloc() in winbind.

2018-05-17 17:30:08 +02:00

winbindd_idmap.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_irpc.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_list_groups.c

winbind: honor WBFLAG_FROM_NSS along with winbind enum users/groups

2018-12-22 03:11:14 +01:00

winbindd_list_users.c

winbind: honor WBFLAG_FROM_NSS along with winbind enum users/groups

2018-12-22 03:11:14 +01:00

winbindd_locator.c

…

winbindd_lookupname.c

winbind: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

winbindd_lookuprids.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_lookupsid.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_lookupsids.c

CVE-2020-14323 winbind: Fix invalid lookupsids DoS

2020-10-29 10:25:37 +00:00

winbindd_misc.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

winbindd_msrpc.c

winbind: Return queried domain name from name_to_sid

2019-04-18 17:21:18 +00:00

winbindd_ndr.c

…

winbindd_pam_auth_crap.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_pam_auth.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_pam_chauthtok.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_pam_chng_pswd_auth_crap.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_pam_logoff.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

winbindd_pam.c

winbind: check for allowed domains in winbindd_pam_auth_pac_verify()

2021-01-27 16:00:06 +00:00

winbindd_ping_dc.c

winbindd: Fix winbindd_ping_dc_recv

2018-06-16 01:06:36 +02:00

winbindd_proto.h

winbind: move config-reloading code to winbindd_dual.c

2021-01-27 16:00:06 +00:00

winbindd_reconnect_ads.c

winbind: Return queried domain name from name_to_sid

2019-04-18 17:21:18 +00:00

winbindd_reconnect.c

winbind: Return queried domain name from name_to_sid

2019-04-18 17:21:18 +00:00

winbindd_rpc.c

s3:winbind: Don't abort when receiving a NULL SID

2019-10-16 16:39:42 +00:00

winbindd_rpc.h

winbind: Return queried domain name from name_to_sid

2019-04-18 17:21:18 +00:00

winbindd_samr.c

winbind: directly use dcerpc_binding_handle_is_connected() in reset_connection_on_error() SAMR code

2020-08-08 10:59:38 +00:00

winbindd_setgrent.c

…

winbindd_setpwent.c

…

winbindd_show_sequence.c

…

winbindd_sids_to_xids.c

…

winbindd_util.c

winbind: move "winbind:ignore domain" logic to a seperate function

2021-01-27 16:00:06 +00:00

winbindd_wins_byip.c

s3: libsmb: Convert node_status_query() and associated functions and callers to expect a size_t * return.

2020-09-15 10:09:36 +00:00

winbindd_wins_byname.c

s3: libsmb: Convert the WINS and broadcast name functions to return size_t * num addresses.

2020-09-15 10:09:36 +00:00

winbindd_xids_to_sids.c

winbind: Enhance xids2sids debugging

2019-02-08 08:51:19 +01:00

winbindd.c

winbind: set logfile after reloading config

2021-01-27 16:00:06 +00:00

winbindd.h

winbindd: add generic wb_parent_idmap_setup_send/recv() helpers

2020-10-23 03:25:36 +00:00

wscript_build

s3:rpc_server: Do not generate and build s3 RPC server code

2020-03-20 15:36:36 +00:00