Jeremy Allison d4e11e82ec s3: smbd: Fix memory leak in smbd_server_connection_terminate_done(). ...

The function smbd_server_connection_terminate_done() does not free subreq
which is allocated in smbXsrv_connection_shutdown_send, this can be a
memory leakage if multi-channel is enabled.

Suggested fix by haihua yang <hhyangdev@gmail.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15174

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Fri Sep 23 09:51:20 UTC 2022 on sn-devel-184

(cherry picked from commit b600b0c8d9690cb5eeded1e5925c8e667c11af04)

Autobuild-User(v4-15-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-15-test): Wed Sep 28 09:36:41 UTC 2022 on sn-devel-184

2022-09-28 09:36:41 +00:00

..

notifyd

smbd: Fix the 32-bit build on FreeBSD

2020-11-30 22:24:38 +00:00

aio.c

smbd: use fh_[get|set]_pos() and fh_[get|set]_position_information()

2020-12-16 09:08:30 +00:00

avahi_register.c

s3-smbd: use fruit:model string for mDNS registration

2019-01-15 21:27:20 +01:00

blocking.c

locking: Make share_mode_watch_send() take "share_mode_lock"

2020-11-10 19:49:34 +00:00

close.c

s3: smbd: Add missing pop_sec_ctx() in error code path of close_directory()

2022-01-17 10:21:10 +00:00

conn_idle.c

smbd: In conn_force_tdis_done() when forcing a connection closed force a full reload of services.

2021-01-28 07:03:30 +00:00

conn_msg.c

smbd: Add close-denied-share message

2020-01-15 21:25:35 +00:00

conn.c

s3/smbd: Use after free when iterating smbd_server_connection->connections

2022-08-23 06:44:13 +00:00

connection.c

s3:param: make "servicename" a substituted option

2019-11-27 10:25:37 +00:00

dfree.c

smbdotconf: mark "dfree command" with substitution="1"

2019-11-27 10:25:32 +00:00

dir.c

smbd: use metadata_fsp() with SMB_VFS_FGET_NT_ACL()

2022-09-06 06:32:13 +00:00

dmapi.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

dnsregister.c

…

dosmode.c

smbd: directly pass fsp to SMB_VFS_FGETXATTR() in fget_ea_dos_attribute()

2022-09-06 06:32:13 +00:00

durable.c

s3: smbd: Allow a durable handle on a leased stat-open.

2022-05-09 07:29:28 +00:00

error.c

s3:smbd: Fix converity warning with _smb_setlen_large()

2018-05-16 21:30:23 +02:00

fake_file.c

smbd: add dosmode_from_fake_filehandle()

2021-06-09 19:47:34 +00:00

fd_handle_private.h

vfs: make struct fd_handle private

2020-12-16 09:08:30 +00:00

fd_handle.c

vfs: make struct fd_handle private

2020-12-16 09:08:30 +00:00

fd_handle.h

smbd: add fd_handle.[c|h]

2020-12-16 09:08:30 +00:00

file_access.c

smbd: use metadata_fsp() with SMB_VFS_FGET_NT_ACL()

2022-09-06 06:32:13 +00:00

fileio.c

smbd: use fdos_mode() in mark_file_modified()

2020-12-16 09:08:31 +00:00

filename.c

smbd: check for streams support in unix_convert()

2022-09-06 07:31:51 +00:00

files.c

smbd: Introduce metadata_fsp()

2022-09-06 06:32:13 +00:00

globals.c

smbd: let smbd_request_guid() use smb1req->xconn->channel_id

2021-03-06 02:20:05 +00:00

globals.h

s3:smbd: implement FSCTL_SMBTORTURE_GLOBAL_READ_RESPONSE_BODY_PADDING8

2021-07-21 09:37:15 +00:00

ipc.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

lanman.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

mangle_hash2.c

smbd: Save 520 bytes of writable memory from every smbd

2019-10-23 02:37:12 +00:00

mangle_hash.c

smbd: Convert valid.dat to C code

2015-03-24 00:00:20 +01:00

mangle.c

smbdotconf: mark "mangling method" with constant="1"

2019-11-27 10:25:37 +00:00

message.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

msdfs.c

CVE-2021-44141: s3: smbd: parse_dfs_path() can ignore wildcards.

2022-01-31 12:23:52 +01:00

negprot.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

notify_fam.c

smbd: Allow passing notify filter from inotify and fam

2016-07-18 15:14:11 +02:00

notify_inotify.c

smbd: Align two integer types

2020-11-04 18:55:39 +00:00

notify_msg.c

notifyd: Factor out notify_walk() into its own file

2020-10-24 05:57:31 +00:00

notify.c

s3: smbd: smbd_check_access_rights_fsp(). Add dirfsp parameter.

2021-06-09 13:14:31 +00:00

ntquotas.c

smbd: add twrp arg to synthetic_smb_fname()

2020-05-05 19:18:40 +00:00

nttrans.c

CVE-2021-44141: s3: smbd: Remove 'const char *src_original_lcomp' parameter from rename_internals().

2022-01-31 12:23:52 +01:00

open.c

smbd: return NT_STATUS_OBJECT_NAME_INVALID if a share doesn't support streams

2022-09-06 06:32:13 +00:00

oplock_linux.c

smbd: use fh_[get|set]_gen_id()

2020-12-16 09:08:30 +00:00

oplock.c

s3:smbd: only clear LEASE_READ if there's no read lease is left

2022-08-23 06:44:13 +00:00

password.c

smbd: RIP user_struct

2020-01-13 21:09:01 +00:00

perfcount.c

smbdotconf: mark "perfcount module" with substitution="1"

2019-11-27 10:25:36 +00:00

pipes.c

smbd: use fsp_set_fd()

2020-12-16 09:08:30 +00:00

posix_acls.c

smbd: use metadata_fsp() in get_acl_group_bits()

2022-09-06 06:32:13 +00:00

process.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

proto.h

smbd: Introduce metadata_fsp()

2022-09-06 06:32:13 +00:00

pysmbd.c

smbd: use metadata_fsp() with SMB_VFS_FSET_NT_ACL()

2022-09-06 06:32:13 +00:00

quotas.c

quotas: Check group quota for directory when SGID is set

2019-08-14 16:27:43 +00:00

reply.c

CVE-2022-32742: s3: smbd: Harden the smbreq_bufrem() macro.

2022-07-24 11:55:51 +02:00

scavenger.c

smbd: Use share_mode_servicepath() in scavenger.c

2020-11-10 19:49:35 +00:00

scavenger.h

…

seal.c

auth: Always supply both the remote and local address to the auth subsystem

2017-03-29 02:37:26 +02:00

sec_ctx.c

sec_ctx.c: Fix -Wunused-function warning on macOS

2021-10-18 08:19:13 +00:00

server_exit.c

lib: give global_contexts.c its own header file

2021-01-08 20:31:33 +00:00

server_reload.c

printing: Introduce printer_list_printername_exists()

2021-03-16 17:09:31 +00:00

server.c

s3:smbd: handle --build-options without parsing smb.conf

2022-01-18 18:42:28 +00:00

service.c

s3: smbd: Add "enum file_close_type close_type" parameter to file_close_conn().

2022-08-23 06:44:13 +00:00

session.c

s3:smbd: fix SAFE_FREE() vs. TALLOC_FREE() in list_sessions()

2019-03-28 23:09:33 +00:00

sesssetup.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

share_access.c

Revert "s3:smbd: Remove NIS support"

2022-06-12 07:44:10 +00:00

signing.c

s3:smbd: Return NTSTATUS for srv_calculate_sign_mac()

2019-05-21 00:03:22 +00:00

smb1_utils.c

smbd: add need_fsa arg and logic to file_find_di_(first|next)

2020-12-16 09:08:31 +00:00

smb1_utils.h

lib: Move send_keepalive() to smbd/smb1_utils.c

2020-08-17 19:35:37 +00:00

smb2_break.c

s3:smbd: pass down smbXsrv_client to smbd_smb2_send_{oplock,lease}_break()

2020-07-08 15:54:40 +00:00

smb2_close.c

smbd: correctly initialize close timestamp fields

2021-05-24 16:56:22 +00:00

smb2_create.c

s3: smbd: smbd_calculate_access_mask_fsp(). Add dirfsp parameter.

2021-06-09 13:14:31 +00:00

smb2_flush.c

smbd: use fsp_get_io_fd() when accessing a file or it's associated metadata

2020-12-16 09:08:30 +00:00

smb2_getinfo.c

smbd: implement access checks for SMB2-GETINFO as per MS-SMB2 3.3.5.20.1

2022-09-06 06:32:13 +00:00

smb2_glue.c

s3:smbd: implement FSCTL_SMBTORTURE_FORCE_UNACKED_TIMEOUT

2020-07-08 15:54:40 +00:00

smb2_ioctl_dfs.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_ioctl_filesys.c

smbd: use sys_io_ranges_overlap() in fsctl_dup_extents_check_overlap()

2021-06-30 16:51:29 +00:00

smb2_ioctl_named_pipe.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_ioctl_network_fs.c

smbd: Align integer types

2020-11-10 19:49:33 +00:00

smb2_ioctl_private.h

s3: smbd: Split out smb2_ioctl_smbtorture() into a separate file.

2021-08-17 07:43:21 +00:00

smb2_ioctl_smbtorture.c

s3: smbd: Call smbd_fsctl_torture_async_sleep() when we get FSCTL_SMBTORTURE_FSP_ASYNC_SLEEP.

2021-08-17 07:43:21 +00:00

smb2_ioctl.c

smb2_ioctl: return BUFFER_TOO_SMALL in smbd_smb2_request_ioctl_done()

2021-12-06 10:42:10 +00:00

smb2_keepalive.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_lock.c

locking: Make share_mode_watch_send() take "share_mode_lock"

2020-11-10 19:49:34 +00:00

smb2_negprot.c

libcli/smb: actually make use of "client/server smb3 signing algorithms"

2021-07-15 00:06:31 +00:00

smb2_notify.c

smbd: Use NT_STATUS_NOTIFY_ENUM_DIR instead of STATUS_NOTIFY_ENUM_DIR

2020-06-22 12:07:38 +00:00

smb2_query_directory.c

smbd: pass a dirfsp to fd_open() and rename it to fd_openat()

2020-12-16 09:08:30 +00:00

smb2_read.c

s3:smbd: implement FSCTL_SMBTORTURE_GLOBAL_READ_RESPONSE_BODY_PADDING8

2021-07-21 09:37:15 +00:00

smb2_server.c

s3: smbd: Fix memory leak in smbd_server_connection_terminate_done().

2022-09-28 09:36:41 +00:00

smb2_sesssetup.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

smb2_setinfo.c

s3: smbd: smbd_smb2_setinfo_send(). All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) clobber fsp->fsp_name->st.st_ex_iflags.

2022-04-11 08:32:10 +00:00

smb2_tcon.c

smb2_tcon: also try to cancel pending compound requests on tdis

2021-03-29 20:43:28 +00:00

smb2_write.c

s3:smbd - support streams larger than 64 KiB

2021-05-10 20:16:21 +00:00

smbd_cleanupd.c

smbd: Remove unused brlock code

2019-06-20 17:18:19 +00:00

smbd_cleanupd.h

smbd: Implement a cleanup daemon

2015-11-16 14:51:33 +01:00

smbd.h

CVE-2021-44141: s3: smbd: UCF_ALWAYS_ALLOW_WCARD_LCOMP 0x00000002 is no longer used.

2022-01-31 12:23:53 +01:00

smbXsrv_client.c

smbXsrv_client: move the connection passing to smb2srv_client_mc_negprot_send/recv

2021-03-06 03:30:06 +00:00

smbXsrv_open.c

smbXsrv_{open,session,tcon}: protect smbXsrv_{open,session,tcon}_global_traverse_fn against invalid records

2021-07-06 11:08:43 +00:00

smbXsrv_session.c

s3:smbd: make sure smbXsrv_session_update() doesn't segfault with table == NULL

2021-07-15 00:06:31 +00:00

smbXsrv_tcon.c

s3: smbd: Add "enum file_close_type close_type" parameter to close_cnum().

2022-08-23 06:44:13 +00:00

smbXsrv_version.c

lib: Pass mem_ctx to lock_path()

2018-08-17 11:30:10 +02:00

srvstr.c

s3: safe_string: do not include string_wrappers.h

2020-08-28 00:56:34 +00:00

statcache.c

source3/smbd/statcache.c: Fix -Wformat build error on macOS

2021-10-18 08:19:13 +00:00

statvfs.c

statvfs: rename linux_statvfs to posix_statvfs

2019-01-11 02:53:57 +01:00

trans2.c

s3: smbd: call_trans2setfilepathinfo(). All calls to SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) clobber fsp->fsp_name->st.st_ex_iflags.

2022-04-11 08:32:10 +00:00

uid.c

source3: move lib/substitute.c functions out of proto.h

2021-11-16 16:01:17 +00:00

utmp.c

s3/smbd: fix utmp hostname logging on Solaris

2019-01-10 22:46:11 +01:00

vfs.c

smbd: add and use vfs_fget_dos_attributes()

2022-09-06 06:32:13 +00:00