Ralph Boehme 8846887a55 s3:printing: Fix %J substition ...

print_run_command() uses lp_print_command() which internally performs basic
substition by calling talloc_sub_basic(). As a result. any of the variables in
the "basic set", including "%J" are already substituted.

To prevent the unwanted subtitution, we declare all affected configuration
options as const, which disabled the basic substition.

As a result print_run_command() can run manual substitution on all characters,
including %J, in the variadic argument list *before* calling lp_string() to run
basic substition which we had disabled before with the const.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov  7 16:01:21 UTC 2019 on sn-devel-184

2019-11-07 16:01:21 +00:00

..

async-tracker.c

s3:utils: use struct initializer in async-tracker long_options

2019-04-29 16:04:28 +00:00

conn_tdb.c

Spelling fixes s/emtpy/empty/

2019-09-01 22:21:26 +00:00

conn_tdb.h

utils: Move conn_tdb.c to utils/

2019-04-12 00:37:05 +00:00

dbwrap_tool.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

dbwrap_torture.c

s3: free popt context in utils

2019-08-22 00:21:50 +00:00

debug2html.c

…

debugparse.c

…

destroy_netlogon_creds_cli.c

utils: Add destroy_netlogon_creds_cli

2018-03-15 15:46:09 +01:00

eventlogadm.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

interact.c

…

interact.h

…

log2pcaphex.c

s3: free popt context in utils

2019-08-22 00:21:50 +00:00

mdfind.c

s3:utils: add mdfind

2019-10-09 14:35:29 +00:00

mvxattr.c

s3: free popt context in utils

2019-08-22 00:21:50 +00:00

net_ads_gpo.c

net: 'net ads gpo getgpo' command not dumping gpo

2019-10-22 19:39:40 +00:00

net_ads.c

docs: modifies 'net ads dns gethostbyname -h' Changes server to nameserver and name to hostname.

2019-10-17 07:58:39 +00:00

net_afs.c

waf: fixup build with fake kaserver enabled

2014-06-04 20:09:39 +02:00

net_afs.h

…

net_cache.c

gencache: Remove transaction-based tdb

2018-11-06 18:57:26 +01:00

net_conf_util.c

net conf: fix error message

2016-11-23 13:00:21 +01:00

net_conf_util.h

…

net_conf.c

s3:utils: Add FALL_THROUGH statements in net_conf.c

2018-03-01 04:37:42 +01:00

net_dns.c

s3:utils: Remove double error check

2018-05-24 18:07:03 +02:00

net_dns.h

s3:utils/net: Add new option 'unregister' in 'net ads dns' command.

2016-06-27 20:43:26 +02:00

net_dom.c

werror: replace WERR_SETUP_NOT_JOINED with WERR_NERR_SETUPNOTJOINED in source3/utils/

2016-09-28 00:04:32 +02:00

net_eventlog.c

…

net_file.c

…

net_g_lock.c

net: Avoid the use of g_lock_do()

2019-11-06 20:36:34 +00:00

net_group.c

…

net_groupmap.c

net: Use dom_sid_str_buf

2018-12-11 00:40:30 +01:00

net_help_common.c

…

net_help_common.h

…

net_help.c

…

net_idmap_check.c

s3:utils: add debug functions instead of magic format strings in net_idmap_check.c

2014-11-25 07:25:45 +01:00

net_idmap_check.h

…

net_idmap.c

net idmap check: correct spelling of --force

2019-07-02 04:21:36 +00:00

net_join.c

…

net_lookup.c

s3:utils: Use C99 initializer in functable in net_lookup

2019-01-28 10:29:23 +01:00

net_notify.c

lib: Add lib/util/server_id.h

2017-01-22 18:30:11 +01:00

net_printing.c

Fix spelling s/formated/formatted/

2018-05-12 02:09:26 +02:00

net_proto.h

s3:net: add 'vfs' hierarchy with 'stream2adouble' command

2019-07-12 21:31:29 +00:00

net_rap.c

Convert all uint32/16/8 to _t in a grab-bag of remaining files.

2015-05-14 22:16:56 +02:00

net_registry_check.c

Spelling fixes s/explicite /explicit /

2019-09-01 22:21:27 +00:00

net_registry_check.h

…

net_registry_util.c

werror: replace WERR_INVALID_PARAM with WERR_INVALID_PARAMETER in source3/utils/

2016-09-28 00:04:23 +02:00

net_registry_util.h

…

net_registry.c

net: Avoid the use of g_lock_do()

2019-11-06 20:36:34 +00:00

net_rpc_audit.c

…

net_rpc_conf.c

net: Return share name in correct case from net rpc conf showshare

2019-05-23 23:26:14 +00:00

net_rpc_printer.c

s3: utils: Convert all uses of uint32/16/8 to _t.

2015-05-07 04:53:39 +02:00

net_rpc_registry.c

source3: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30 11:32:18 +00:00

net_rpc_rights.c

net: Don't crash if lsa_LookupPrivDisplayName returns NULL

2017-03-23 07:43:57 +01:00

net_rpc_samsync.c

net: Use dom_sid_str_buf

2018-12-20 23:40:23 +01:00

net_rpc_service.c

werror: replace WERR_GENERAL_FAILURE with WERR_GEN_FAILURE in source3/utils/

2016-09-28 00:04:21 +02:00

net_rpc_sh_acct.c

…

net_rpc_shell.c

net: Use dom_sid_str_buf

2018-12-11 00:40:30 +01:00

net_rpc_trust.c

s3:utils: Use GnuTLS RC4 in npc_rpc_trust

2019-06-27 12:54:24 +00:00

net_rpc.c

source3/utils/net_rpc.c: typo fixes

2019-10-31 00:43:37 +00:00

net_sam.c

source3: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30 11:32:18 +00:00

net_serverid.c

smbd: Remove some unused includes

2019-04-11 23:35:15 +00:00

net_share.c

net rpc share allowedusers: Allow restricting shares

2018-11-30 03:35:13 +01:00

net_status.c

lib: Remove #define serverid_equal server_id_equal

2019-11-06 20:36:34 +00:00

net_tdb.c

net: Add net tdb command to print information from tdb records

2017-05-08 21:08:23 +02:00

net_time.c

s3:utils:net: Print debug message about Netbios

2019-01-09 22:38:21 +01:00

net_user.c

…

net_usershare.c

net: Use dom_sid_str_buf

2018-12-11 00:40:30 +01:00

net_util.c

libsmb: Give namequery.c its own header

2018-04-11 01:06:39 +02:00

net_vfs.c

smbd: rename [un]become_user*() to [un]become_user_without_service*()

2019-09-11 19:59:34 +00:00

net.c

s3:net: add 'vfs' hierarchy with 'stream2adouble' command

2019-07-12 21:31:29 +00:00

net.h

s3:net: add 'vfs' hierarchy with 'stream2adouble' command

2019-07-12 21:31:29 +00:00

netlookup.c

…

nmblookup.c

s3:utils: Use C99 initializer for poptOption in nmblookup

2019-01-28 10:29:13 +01:00

ntlm_auth_diagnostics.c

ntlm_auth3: let contact_winbind_auth_crap() return pauthoritative

2017-03-24 11:57:09 +01:00

ntlm_auth_proto.h

ntlm_auth3: let contact_winbind_auth_crap() return pauthoritative

2017-03-24 11:57:09 +01:00

ntlm_auth.c

ntlm_auth: Fix nonempty line endings

2019-11-06 20:36:35 +00:00

ntlm_auth.h

…

passwd_proto.h

…

passwd_util.c

s3: smbpasswd - fix crashes on invalid input.

2013-12-16 15:17:58 +01:00

pdbedit.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

profiles.c

s3:utils: Use C99 initializer for poptOption in profiles

2019-01-28 10:29:13 +01:00

regedit_dialog.c

source3: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30 11:32:18 +00:00

regedit_dialog.h

regedit: Fix format-nonliteral warning

2016-08-24 01:33:50 +02:00

regedit_hexedit.c

werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/

2016-09-28 00:04:19 +02:00

regedit_hexedit.h

regedit: handle del and backspace in hexeditor

2014-10-01 14:32:10 +02:00

regedit_list.c

werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/

2016-09-28 00:04:19 +02:00

regedit_list.h

regedit: handle pgup/pgdn/home/end keys on lists

2014-10-01 14:32:10 +02:00

regedit_samba3.c

werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/

2016-09-28 00:04:19 +02:00

regedit_treeview.c

werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/

2016-09-28 00:04:19 +02:00

regedit_treeview.h

regedit: find previous items

2014-10-01 14:32:09 +02:00

regedit_valuelist.c

werror: replace WERR_NOMEM with WERR_NOT_ENOUGH_MEMORY in source3/utils/

2016-09-28 00:04:19 +02:00

regedit_valuelist.h

regedit: search values and repeat search from cursor positions

2014-10-01 14:32:09 +02:00

regedit_wrap.c

s3: utils: Convert all uses of uint32/16/8 to _t.

2015-05-07 04:53:39 +02:00

regedit.c

s3: free popt context in utils

2019-08-22 00:21:50 +00:00

regedit.h

s3: utils: Convert all uses of uint32/16/8 to _t.

2015-05-07 04:53:39 +02:00

sharesec.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

smbcacls.c

s3:utils: If share is NULL in smbcacls, don't print it

2019-05-08 16:33:24 +00:00

smbcontrol.c

messaging: Do POOL_USAGE via a socket

2019-09-18 21:27:30 +00:00

smbcquotas.c

s3:utils: If share is NULL in smbcquotas, don't print it

2019-05-08 16:33:24 +00:00

smbfilter.c

libsmb: Give namequery.c its own header

2018-04-11 01:06:39 +02:00

smbget.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

smbpasswd.c

s3: remove now unneeded call to cmdline_messaging_context()

2019-10-24 09:33:47 +00:00

smbtree.c

s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.

2019-10-30 20:44:31 +00:00

split_tokens.c

s3: free popt context in utils

2019-08-22 00:21:50 +00:00

status_profile_dummy.c

s3:smbprofile: Make "status_profile.h" a proper header

2014-11-19 20:51:37 +01:00

status_profile.c

s3:utils: Fix buffer size for snprintf and format string

2017-08-09 13:37:47 +02:00

status_profile.h

s3:smbprofile: Make "status_profile.h" a proper header

2014-11-19 20:51:37 +01:00

status.c

lib: Remove #define serverid_equal server_id_equal

2019-11-06 20:36:34 +00:00

testparm.c

s3:printing: Fix %J substition

2019-11-07 16:01:21 +00:00

wscript_build

Build registry parsing code into subsystem

2019-10-18 07:31:45 +00:00