sinjuginas/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MINOR: quic: Stalled connections (missing I/O handler wakeup)

Browse Source 
This was due to a missing I/O handler tasklet wakeup in process_timer() when
detecting packet loss. As, qc_release_lost_pkts() could remove the lost packets
from the in flight packets count, qc_set_timer() could cancel the timer used
to wakeup the connection I/O handler. Then the connection could remain idle
until it ends.

Must be backported to 2.6.

(cherry picked from commit 15773f2101e7c56e6e21bf06cb7b35788c3a1647)
Signed-off-by: Willy Tarreau <w@1wt.eu>
This commit is contained in:
Frdric Lcaille 2022-08-24 17:57:09 +02:00 committed by Willy Tarreau
parent 5ecab3fea3
commit 0937ad2b86
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xprt_quic.c
View File

@ -4545,6 +4545,8 @@ static struct task *process_timer(struct task *task, void *ctx, unsigned int sta
struct list lost_pkts = LIST_HEAD_INIT(lost_pkts);
qc_packet_loss_lookup(pktns, qc, &lost_pkts);
if (!LIST_ISEMPTY(&lost_pkts))
tasklet_wakeup(conn_ctx->wait_event.tasklet);
qc_release_lost_pkts(qc, pktns, &lost_pkts, now_ms);
qc_set_timer(qc);
goto out;