sinjuginas/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: lua: handle stick table implicit arguments right.

Browse Source 
In hlua_lua2arg_check(), we allow for the first argument to not be
provided, if it has a type we know, this is true for frontend, backend,
and stick table. However, the stick table code was changed. It used
to be deduced from the proxy, but it is now directly provided in struct
args. So setting the proxy there no longer work, and we have to
explicitely set the stick table.
Not doing so will lead the code do use the proxy pointer as a stick
table pointer, which will likely cause crashes.

This should be backported up to 2.0.

(cherry picked from commit 14f62688839dc7245ca87e040f14fbd2147698e6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
This commit is contained in:
Olivier Houchard 2022-09-13 00:35:53 +02:00 committed by Christopher Faulet
parent bb0cb68fe6
commit 2075777c35
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hlua.c
View File

@ -857,7 +857,11 @@ __LJMP int hlua_lua2arg_check(lua_State *L, int first, struct arg *argp,
break;
case ARGT_TAB:
argp[idx].data.prx = p;
if (!p->table) {
msg = "Mandatory argument expected";
goto error;
}
argp[idx].data.t = p->table;
argp[idx].type = ARGT_TAB;
argp[idx+1].type = ARGT_STOP;
break;