From 82c8332be058d79ce0b97151cd312ea5e43a4356 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 2 Sep 2020 14:16:59 +0200 Subject: [PATCH] BUG/MEDIUM: doc: Fix replace-path action description The description of the replace-path action does not reflect what the code do. When the request path is replaced, the query-string is preserved. But the documentation stated the query-string is part of the replacement, if any is present. Most of time, when the doc and the code differ, the code is fixed. But here, the replace-path action is pretty confusing because the set-path action is only applied on the path. The query-string is left intact. And the path sample fetch also ignores the query-string. In addition, the replace-path action is quite recent. It was added in the 2.2. Thus, exceptionally, the documentation is fixed instead. Note that set-pathq and replace-pathq actions and pathq sample fetch will be added to manipulate the path with the query-string. This patch must be backported as far as 2.0. --- doc/configuration.txt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/configuration.txt b/doc/configuration.txt index 83fb85a56..7d23f4851 100644 --- a/doc/configuration.txt +++ b/doc/configuration.txt @@ -5549,8 +5549,9 @@ http-request replace-path This works like "replace-header" except that it works on the request's path component instead of a header. The path component starts at the first '/' - after an optional scheme+authority. It does contain the query string if any - is present. The replacement does not modify the scheme nor authority. + after an optional scheme+authority and ends before the question mark. Thus, + the replacement does not modify the scheme, the authority and the + query-string. It is worth noting that regular expressions may be more expensive to evaluate than certain ACLs, so rare replacements may benefit from a condition to avoid @@ -5560,9 +5561,6 @@ http-request replace-path # prefix /foo : turn /bar?q=1 into /foo/bar?q=1 : http-request replace-path (.*) /foo\1 - # suffix /foo : turn /bar?q=1 into /bar/foo?q=1 : - http-request replace-path ([^?]*)(\?(.*))? \1/foo\2 - # strip /foo : turn /foo/bar?q=1 into /bar?q=1 http-request replace-path /foo/(.*) /\1 # or more efficient if only some requests match :