sinjuginas/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUILD: http-htx: Silent build error about a possible NULL start-line

Browse Source 
In http_replace_req_uri(), if the URI was successfully replaced, it means
the start-line exists. However, the compiler reports an error about a
possible NULL pointer dereference:

src/http_htx.c: In function ‘http_replace_req_uri’:
src/http_htx.c:392:19: error: potential null pointer dereference [-Werror=null-dereference]
  392 |         sl->flags &= ~HTX_SL_F_NORMALIZED_URI;

So, ALREADY_CHECKED() macro is used to silent the build error. This patch
must be backported with 84cdbe478a ("BUG/MINOR: http-htx: Don't consider an
URI as normalized after a set-uri action").
This commit is contained in:
Christopher Faulet 2022-11-22 18:02:00 +01:00
parent a462ee0af4
commit 92c2de1a06
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/http_htx.c
View File

@ -389,6 +389,8 @@ int http_replace_req_uri(struct htx *htx, const struct ist uri)
goto fail;
sl = http_get_stline(htx);
ALREADY_CHECKED(sl); /* the stline exists because http_replace_stline() succeded */
sl->flags &= ~HTX_SL_F_NORMALIZED_URI;
if (!http_update_host(htx, sl, uri))
goto fail;