Christopher Faulet
48bb2f41aa
BUG/MINOR: h1-htx: Remove flags about protocol upgrade on non-101 responses
It is possible to have an "upgrade:" header and the corresponding value in the "connection:" header for a non-101 response. It happens for 426-Upgrade-Required messages. However, on HAProxy side, a parsing error is reported for this kind of message because no websocket key header ("sec-websocket-accept:") is found in the response. So a possible fix could be to not perform this test for non-101 responses. However, having flags about protocol upgrade on this kind of response could lead to other bugs. Instead, corresponding flags are removed. Thus, during the H1 response post-parsing, H1_MF_CONN_UPG and H1_MF_UPG_WEBSOCKET flags are removed from any non-101 response. This patch should fix the issue #1997. It must be backported as far as 2.4. (cherry picked from commit 5f36bfe42e6fe1daa764c38a8ba158b710e52530) Signed-off-by: Willy Tarreau <w@1wt.eu> (cherry picked from commit b4784965cbcc2b914477a8a47be52cbf6803b62d) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)
Description
Languages
Shell
100%