Willy Tarreau
7b27b7d06e
BUG/MINOR: listener: close tiny race between resume_listener() and stopping
Pierre Cheynier reported a very rare race condition on soft-stop in the listeners. What happens is that if a previously limited listener is being resumed by another thread finishing an accept loop, and at the same time a soft-stop is performed, the soft-stop will turn the listener's state to LI_INIT, and once the listener's lock is released, resume_listener() in the second thread will try to resume this listener which has an fd==-1, yielding a crash in listener_set_state(): FATAL: bug condition "l->rx.fd == -1" matched at src/listener.c:288 The reason is that resume_listener() only checks for LI_READY, but doesn't consider being called with a non-initialized or a stopped listener. Let's also make sure we don't try to ressuscitate such a listener there. This will have to be backported to all versions. (cherry picked from commit d1ebee17740683fd49a88c4064ac1ff6a0dea264) Signed-off-by: Willy Tarreau <w@1wt.eu> (cherry picked from commit 87a566b86d0e7c2af9c59ef1c6ba1681c3b4fd21) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)
Description
Languages
Shell
100%