sinjuginas/oauth2-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ReadAll() & Close() 　close together.

Browse Source
This commit is contained in:
toshi-miura 2019-10-11 16:02:04 +09:00
parent 31d7b61cc4
commit e71797b409
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
providers/github.go
View File

@ -171,8 +171,6 @@ func (p *GitHubProvider) hasOrgAndTeam(accessToken string) (bool, error) {
return false, err
}
body, err := ioutil.ReadAll(resp.Body)
if last == 0 {
// link header may not be obtained
// When paging is not required and all data can be retrieved with a single call
@ -196,10 +194,13 @@ func (p *GitHubProvider) hasOrgAndTeam(accessToken string) (bool, error) {
}
}
resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
if err != nil {
resp.Body.Close()
return false, err
}
resp.Body.Close()
if resp.StatusCode != 200 {
return false, fmt.Errorf(
"got %d from %q %s", resp.StatusCode, endpoint.String(), body)