sinjuginas/rpm-build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

al.c: lazy creation of al->dirIndex and al->provIndex

Browse Source 
For erasedPackages, the dirIndex and provIndex are unused, and
thus should not be created at all.  There is arguably a better
option - to provide explicit alMakeIndex and alFreeIndex API.
This commit is contained in:
Alexey Tourbin 2010-07-12 11:03:50 +04:00
parent 7a1f3ed06d
commit b08133537b
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/al.c
View File

@ -158,6 +158,12 @@ void alIndexPkgProvides(availableList al, int pkgIx)
static
struct alProvEntry *alSearchProv(availableList al, const char *name, int *n)
{
/* first time lookup, create provIndex */
if (al->provIndex == NULL) {
int i;
for (i = 0; i < al->size; i++)
alIndexPkgProvides(al, i);
}
return axSearch(al->provIndex, sizeof(*al->provIndex->prov), name, n);
}
@ -267,6 +273,13 @@ exit:
static
struct alFileEntry *alSearchFile(availableList al, const char *fname, int *n)
{
/* first time lookup, create dirIndex */
if (al->dirIndex == NULL) {
int i;
for (i = 0; i < al->size; i++)
alIndexPkgFiles(al, i);
}
/* need to preserve trailing slahs in d */
const char *b = strrchr(fname, '/') + 1;
int dlen = b - fname;
@ -432,8 +445,13 @@ alAddPackage(availableList al,
p->relocs = NULL;
}
alIndexPkgProvides(al, pkgNum);
alIndexPkgFiles(al, pkgNum);
/* Only update the index if it is already created.
* Otherwise, the index will be constructed upon the first time lookup. */
if (al->provIndex)
alIndexPkgProvides(al, pkgNum);
if (al->dirIndex)
alIndexPkgFiles(al, pkgNum);
return p;
}