sinjuginas/rpm-build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

functions (ValidateBuildRoot): require canonical RPM_BUILD_ROOT

Browse Source 
Some scripts like lib.req rely on the fact that RPM_BUILD_ROOT
should not end with trailing slashes or something.  Other
scripts like find-package explicitly assume that RPM_BUILD_ROOT
can be relocated within filesystem; they use something like
"real_buildroot" variables.  The code gets complicated,
fragile, and error-prone.

Therefore, guys, hereby I FORBID non-canonical RPM_BUILD_ROOT path.
Note that RPM_BUILD_ROOT actually does not have to exist.
This is another problem...
This commit is contained in:
Alexey Tourbin 2008-02-19 02:38:42 +03:00
parent 17b1c6b296
commit e0598b6fe3
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scripts/functions
View File

@ -57,8 +57,16 @@ Debug()
ValidateBuildRoot() ValidateBuildRoot()
{ {
[ -n "${RPM_BUILD_ROOT-}" ] ||
Fatal 'RPM_BUILD_ROOT not set'
[ -n "$(printf %s "$RPM_BUILD_ROOT" |tr -d ' /.')" ] || [ -n "$(printf %s "$RPM_BUILD_ROOT" |tr -d ' /.')" ] ||
Fatal 'invalid $RPM_BUILD_ROOT' Fatal "bogus RPM_BUILD_ROOT=$RPM_BUILD_ROOT"
local real_buildroot
# There could be simply no %install section...
# I pretend that non-existent buildroot is just canonical enough.
real_buildroot=$(readlink -vm -- "$RPM_BUILD_ROOT")
[ "$RPM_BUILD_ROOT" = "$real_buildroot" ] ||
Fatal "non-canonical RPM_BUILD_ROOT=$RPM_BUILD_ROOT real_buildroot=$real_buildroot"
} }
[ -z "${RPM_BUILD_ROOT-}" ] || ValidateBuildRoot [ -z "${RPM_BUILD_ROOT-}" ] || ValidateBuildRoot