2 Commits

Author	SHA1	Message	Date
Gleb Fotengauer-Malinovskiy	051d1fee67	scripts/provided_symbols: use elfutils' readelf instead of binutils' one ... This script is designed to ignore lines that don't follow the expected format, but it is widely known that the output format of readelf utility from the binutils project can be quite unreliable. The output format may vary on certain architectures and ELFs created with certain build tools may contain symbols with peculiar bits that affect the output. Here is a couple of examples illustrating these issues: * On PowerPC, ELF symbols frequently include the localentry bit. For instance: $ readelf --wide --dyn-syms /lib64/libcrypto.so.1.1 | grep ASN1_VISIBLESTRING_new 157: 00000000000938c0 60 FUNC GLOBAL DEFAULT [<localentry>: 8] 11 ASN1_VISIBLESTRING_new@@OPENSSL_1_1_0 * On x86_64, a proprietary blob /usr/lib64/libjcPKCS11ds.so (distributed as an ELF) and on armh /usr/lib/libLLVM-16.so, contain symbols with OS-specific bits: $ readelf --wide --dyn-syms /usr/lib64/libjcPKCS11ds.so | grep _ZNSt7collateIwE2idE 2572: 00000000002df9c8 8 OBJECT <OS specific>: 10 DEFAULT 26 _ZNSt7collateIwE2idE $ readelf --wide --dyn-syms /usr/lib/libLLVM-16.so | grep _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyE 45060: 05af0478 8 OBJECT <OS specific>: 10 DEFAULT 26 _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyE@@LLVM_16 The issue related to PowerPC localentry bits was resolved in the commit 4f4a1d146 ("lib.prov, lib.req: enhance ProvidedSymbols") a long time ago. The issue related to OS-specific bits was discovered recently [1]. Instead of attempting to resolve the output issues of binutils' readelf utility concerning OS-specific bits, it is more convenient to use readelf from elfutils. It has more reliable output (including the handling of the cases described earlier) and is extensively utilized within the project anyway. [1] https://bugzilla.altlinux.org/46447 Reported-by: Konstantin A. Lepikhov <lakostis@altlinux.ru> Reported-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> Fixes: https://bugzilla.altlinux.org/46447	2023-06-08 05:00:00 +00:00
Dmitry V. Levin	2107482334	scripts: move ProvidedSymbols() and SuggestBPP() to separate files ... ProvidedSymbols() used to be defined both in lib.prov.in and lib.req.in, fix this code duplication by moving ProvidedSymbols() to separate provided_symbols executable script. Likewise, SuggestBPP() used to be defined both in lib.prov.in and lib.req.in, fix this code duplication by moving SuggestBPP() to separate suggest_bpp executable script.	2019-01-14 20:56:55 +00:00