sinjuginas/rpm-build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,070 Commits 1 Branch 0 Tags 4.5 MiB
5c202f0b50
Commit Graph

553 Commits

Author SHA1 Message Date
Dmitry V. Levin
88c1020672 verify-elf: fix passing of LD_PRELOAD in verify_unresolved 
In verify_unresolved(), do not preload requested objects to $elf_ldd
directly because the latter is not an ELF interpreter but a shell
script.  Instead, pass the list of objects that have to be preloaded
to $elf_ldd script which in turn assigns it to LD_PRELOAD variable
in the ELF interpreter invocation.
 2017-01-17 16:16:28 +03:00
Gleb Fotengauer-Malinovskiy
fc627b0ef0 Relax check for gcc package name in {cpp,pkgconfiglib}.req generators 2017-01-17 16:11:35 +03:00
Gleb Fotengauer-Malinovskiy
bea326ff93 verify-elf: make verify_lfs check libraries too 
Previously, verify_lfs checked if object has valid interpreter, but it
doesn't make sense in case of shared objects.  verify_lfs check is valid
for all ELFs linked with libraries supporting both LFS and non-LFS API
(libc.so and libz.so in our case).
 2017-01-17 16:11:27 +03:00
Ivan Zakharyaschev
2ac0536ff6 verify_rpath(): distinguish grep's failure and a normal valid case 
Previously (according to the exit statuses):

0. if something strange was found in $rpath, an error was reported;
1. if nothing strange was found, no error was reported;
2. if grep failed, it looked like the previous case and no error was
reported (as if $rpath was valid).

Now, the pipe (and the whole script) would abort on grep's failure.
 2016-12-09 03:23:12 +03:00
Ivan Zakharyaschev
0445f481cc verify_stack(): distinguish failures and a normal status of grep 
Now, if something fails, the pipe (and the function, and the whole
script) will fail.

If the exit codes are normal, they are handled according to our logic.

Previously, a failure (which is an exceptional rare case) would lead to:

1. skipping the further exe_stack check and error_strict STACK "$f" 'STACK entry not found'
2. silently skipping the exe_stack check (which was impossible anyway because of the failure)
 2016-12-09 03:23:12 +03:00
Ivan Zakharyaschev
fc56b0be97 verify_unresolved(): correctly treat the status of grep in a very unusual case 
The pipe (and the function, and the whole script) would fail when the
resulting constructed rpath was empty. But usually at least
$RPM_VERIFY_ELF_LDD_RPATH is not empty, so the bad behavior has not
been observed.
 2016-12-09 03:23:12 +03:00
Dmitry V. Levin
a4fb4d42e7 verify-elf (verify_unresolved): treat PIEs as executables 2016-12-07 11:30:44 +00:00
Dmitry V. Levin
8c1f9d589b Move "is this ELF shared object an executable" check to a separate script 
* configure.ac (AC_OUTPUT): Add scripts/fixup-libraries.
* rpm-4_0.spec (%files build): Add %_rpmlibdir/is_elf_so_executable.
* scripts/is_elf_so_executable: New file.
* scripts/Makefile.am (EXTRA_DIST, config_SCRIPTS): Add it.
* scripts/fixup-libraries: Rename to scripts/fixup-libraries.in,
use is_elf_so_executable.
 2016-12-07 11:30:42 +00:00
Dmitry V. Levin
a51ea574e9 scripts/fixup-libraries: fix recognition of PIEs 2016-12-07 11:30:25 +00:00
Ivan Zakharyaschev
d362bae600 verify-elf made a bit safer: pipes or command substitutions make it fail 
1. set -o pipefail
2. don't use command substitutions inside other complex expressions; just assign to a var -- then it would make the script fail
 2016-11-30 17:49:59 +03:00
Ivan Zakharyaschev
00b00565ea verify-elf: don't call verify_rpath() under a pipe because the errors are saved in a var 
(A pipe makes a subshell and the var is modified there.)
 2016-11-30 17:48:24 +03:00
Ivan Zakharyaschev
c0f11587a5 verify-elf: don't confuse verify_rpath() in case of two RUNPATH/RPATHs (ALT#32826) 2016-11-30 17:30:49 +03:00
Ivan Zakharyaschev
91c923f251 verify-elf: tiny cleanup: unify the awk expression for RPATH extraction 
Rewritten equivalently, like in lib.req.
 2016-11-30 17:09:09 +03:00
Ivan Zakharyaschev
70369c1a8e verify-elf: tiny cleanup: local var declaration moved to the place of use 
The other occurence of "rpath" is in the second part of a pipe and is
local to that subshell anyway.
 2016-11-30 17:08:09 +03:00
Ivan Zakharyaschev
3172abb8c1 %%distribution: ALT Linux --> ALT (ALT#32707) and some minor corrections of old @altlinux.ru addresses 2016-11-29 15:12:34 +03:00
Ivan Zakharyaschev
66f1a4cb8d verify-elf: RUNPATH overrides RPATH for verify_unresolved 
From ld.so's documentation about the search order:

Using the directories specified in the DT_RPATH dynamic section
attribute of the binary if present and DT_RUNPATH attribute does not
exist. Use of DT_RPATH is deprecated.
 2016-11-29 15:11:46 +03:00
Ivan Zakharyaschev
65509e2763 verify-elf: honor RUNPATH, too (like in lib.req.in:95 and debuginfo.req.in:76) 
in addition to RPATH
 2016-11-28 22:37:18 +03:00
Ivan Zakharyaschev
e2810bda5c added me to "Copyright (C)" 2016-11-28 22:37:13 +03:00
Ivan Zakharyaschev
d2e5d7dce7 shell.req: generalize the shebang regexp w.r.t. other locations of env 
No need to be too strict here: shebang.req would (or should) catch bad
locations. It's not our work.
 2016-05-27 16:02:37 +03:00
Ivan Zakharyaschev
ef66de16d5 shell.req: more idiomatic regexp for reading the shebang (use ?) 
Compared with a similar regexp in Emacs sources --
http://git.altlinux.org/gears/e/emacs24.git?p=emacs24.git;a=blob;f=lisp/progmodes/sh-script.el;h=4700324d376db79e27d05e5352fff2f7e841a603;hb=HEAD#l1637
: "#![ \t]?\\([^ \t\n]*/bin/env[ \t]\\)?\\([^ \t\n]+\\)"

Conclusion: mostly identical meaning, with the exception of a more
liberal path of env in Emacs.

But ALT Sisyphus has /usr/bin/env only, so I don't see a good reason
to make the regexp more general. (If a different path is written
there, it won't work in ALT Sisyphus.)
 2016-05-27 15:19:10 +03:00
Ivan Zakharyaschev
f9bf39c2aa shell.req: use the version of (ba|)sh from the shebang 2016-05-24 23:08:04 +03:00
Ivan Zakharyaschev
4d23ad4702 percolate: removed loop optimization (for code clarity), result won't change 2016-04-06 03:26:17 +03:00
Ivan Zakharyaschev
5630438416 debuginfo.req.files: ignore everything under /usr/lib/debug/.build-id/ 
The special directory structure there doesn't correspond to the
directory structure where debuginfo.req expects to find and process
*.debug files.
 2016-04-05 22:57:42 +03:00
Ivan Zakharyaschev
dc0def4a3b percolate: hopefully, it will work just with /bin/sh (not to create an extra dep) 
Conflicts:
	scripts/percolate
 2016-04-05 22:57:42 +03:00
Ivan Zakharyaschev
0f969acf44 percolate: register it in Makefile etc. 2016-04-05 22:57:42 +03:00
Ivan Zakharyaschev
70bf25fc08 percolate: a helper script (will be used to follow symlinks only through known files) 2016-04-05 22:57:35 +03:00
Ivan Zakharyaschev
c024ff3ce7 brp-verify_elf: set -o pipefail -- just in case 2016-03-31 21:23:29 +03:00
Ivan Zakharyaschev
e124ef0b4c brp-verify_elf: handle all rules for setting LD_PRELOAD in the form of pairs of RPM_LD_PRELOAD_@ and RPM_FILES_TO_LD_PRELOAD_@ env vars 2016-03-31 21:23:29 +03:00
Ivan Zakharyaschev
9d2611ea44 verify-elf: substitute LD_PRELOAD before ldd (with what is passed on stdin after \t) 
Of course, this will clean any externally set LD_PRELOAD.
 2016-03-31 21:23:22 +03:00
Dmitry V. Levin
b78cc75d12 lib.req: make "no symbol bindings" condition fatal 2016-03-10 15:30:27 +00:00
Dmitry V. Levin
864001eba2 Revert "ldd.in: pass --list to rtld" 
ld.so --list option is incompatible with LD_TRACE_LOADED_OBJECTS.

This reverts commit da9e6dfaab.
 2016-03-10 16:10:54 +00:00
Dmitry V. Levin
42eacfcc82 brp-bytecompile_python: exclude paths listed in $RPM_PYTHON3_COMPILE_INCLUDE (ALT#28606) 
$RPM_PYTHON3_COMPILE_INCLUDE is usually a subset of
$RPM_PYTHON_COMPILE_INCLUDE, so add the former to the exclude list.
 2016-03-09 15:02:22 +00:00
Dmitry V. Levin
da9e6dfaab ldd.in: pass --list to rtld 2016-01-11 18:19:19 +00:00
Gleb Fotengauer-Malinovskiy
ae81f541b9 compress_files: change default method to xz 2015-12-02 21:46:44 +03:00
Gleb Fotengauer-Malinovskiy
39018f9f32 find-package: add support for newer naming of gcc and libstdc++-devel 2015-05-21 18:07:37 +03:00
Dmitry V. Levin
6ad3a37cb9 verify-elf: fix regression in verify_lfs 2015-01-28 13:41:37 +00:00
Dmitry V. Levin
a44f6ae523 verify-elf: make verify_stack work again 2015-01-23 14:56:29 +00:00
Dmitry V. Levin
213af284d9 fixup-binconfig: strip rpaths 
Extend library search path stripping algorithm to handle rpaths.
 2014-02-25 12:25:51 +00:00
Dmitry V. Levin
2992fcc3ab pkgconfig.req.in: allow pkgconfig names to start with + (ALT#29737) 2014-02-25 12:22:12 +00:00
Dmitry V. Levin
f1dc627616 cpp.req: fix for cpp 4.8.x output 
Adapt cpp output parser to handle cpp 4.8.x output properly.

  $ cpp-4.7 /dev/null
  # 1 "/dev/null"
  # 1 "<command-line>"
  # 1 "/dev/null"
  $ cpp-4.8 /dev/null
  # 1 "/dev/null"
  # 1 "<command-line>"
  # 1 "/usr/include/stdc-predef.h" 1 3 4
  # 1 "<command-line>" 2
  # 1 "/dev/null"
 2014-02-15 03:06:45 +00:00
Dmitry V. Levin
6fb9f3ddc8 brp-debuginfo: add $RPM_DEBUGINFO_SKIPLIST support 2013-10-29 00:51:04 +00:00
Dmitry V. Levin
02fb57b32c fixup-pkgconfig: workaround some broken pkgconfig files (ALT#29427) 2013-10-24 12:42:15 +00:00
Dmitry V. Levin
98730b6009 find-lang: update copyright information 2013-03-11 23:15:51 +00:00
Dmitry V. Levin
c525a0dea9 find-lang: minor regexp optimization 2013-03-11 23:13:27 +00:00
Dmitry V. Levin
d5936fb3eb find-lang: enhance QT files lookup regexps 2013-03-11 23:04:17 +00:00
Dmitry V. Levin
bd376047fd find-lang: enhance KDE lookup regexps 2013-03-11 22:50:38 +00:00
Dmitry V. Levin
00809aa77f find-lang: enhance GNOME lookup regexps 2013-03-11 22:38:28 +00:00
Dmitry V. Levin
9e3d656706 find-lang: enhance man lookup regexps 2013-03-11 21:49:30 +00:00
Dmitry V. Levin
bdda18ca1f find-lang: enhance .mo files lookup regexps 2013-03-11 21:46:43 +00:00
Dmitry V. Levin
5a139641b0 find-lang: add --with-qt option to getopt (ALT#28288) 2013-03-10 00:04:56 +00:00