slipenkomk/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUG/MEDIUM: hlua: Don't set EOM flag on an empty HTX message in HTTP applet

Browse Source 
In a lua HTTP applet, when the script is finished, we must be sure to not
set the EOM on an empty message. Otherwise, because there is no data to
send, the mux on the client side may miss the end of the message and
consider any shutdown as an abort.

See "UG/MEDIUM: stats: Be sure to never set EOM flag on an empty HTX
message" for details.

This patch must be backported as far as 2.4. On previous version there is
still the EOM HTX block.
This commit is contained in:
Christopher Faulet 2022-04-07 10:07:18 +02:00
parent 08b45cb8fd
commit f89af9c205
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/hlua.c
View File

@ -9567,7 +9567,19 @@ void hlua_applet_http_fct(struct appctx *ctx)
if (!(ctx->ctx.hlua_apphttp.flags & APPLET_HDR_SENT))
goto error;
/* no more data are expected. Don't add TLR because mux-h1 will take care of it */
/* no more data are expected. If the response buffer is empty
* for a chunked message, be sure to add something (EOT block in
* this case) to have something to send. It is important to be
* sure the EOM flags will be handled by the endpoint.
*/
if (htx_is_empty(res_htx) && (strm->txn->rsp.flags & (HTTP_MSGF_XFER_LEN|HTTP_MSGF_CNT_LEN)) == HTTP_MSGF_XFER_LEN) {
if (!htx_add_endof(res_htx, HTX_BLK_EOT)) {
si_rx_room_blk(si);
goto out;
}
channel_add_input(res, 1);
}
res_htx->flags |= HTX_FL_EOM;
si->cs->flags |= CS_FL_EOI;
res->flags |= CF_EOI;