e78bb0f6b1
qc_new_conn() is used to allocate a quic_conn instance and its various internal members. If one allocation fails, quic_conn_release() is used to cleanup things. For the moment, pool_zalloc() is used which ensures that all content is null. However, some members must be initialized to a special values to be able to use quic_conn_release() safely. This is the case for quic_conn lists and its tasklet. Also, some quic_conn internal allocation functions were doing their own cleanup on failure without reset to NULL. This caused an issue with quic_conn_release() which also frees this members. To fix this, these functions now only return an error without cleanup. It is the caller responsibility to free the allocated content, which is done via quic_conn_release(). Without this patch, allocation failure in qc_new_conn() would often result in segfault. This was reproduced easily using fail-alloc at 10%. This should be backported up to 2.6. (cherry picked from commit dbf6ad470b3206f64254141e7cf80a980261be29) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com> (cherry picked from commit d35d46916d8ff53b13c08862297f49b5d881d738) Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>