slipenkomk/valkey
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cluster human_nodename Getter data loss in nodes.conf (#12325)

Browse Source 
auxHumanNodenameGetter limited to %.40s, since we did not limit the
length of config cluster-announce-human-nodename, %.40s will cause
nodename data loss (we will persist it in nodes.conf).

Additional modified auxHumanNodenamePresent to use sdslen.
This commit is contained in:
Binbin 2023-06-20 08:13:18 +08:00 committed by GitHub
parent b510624978
commit cd4f3e20c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cluster.c
View File

@ -240,11 +240,11 @@ int auxHumanNodenameSetter(clusterNode *n, void *value, int length) {
} }
sds auxHumanNodenameGetter(clusterNode *n, sds s) { sds auxHumanNodenameGetter(clusterNode *n, sds s) {
return sdscatprintf(s, "%.40s", n->human_nodename); return sdscatprintf(s, "%s", n->human_nodename);
} }
int auxHumanNodenamePresent(clusterNode *n) { int auxHumanNodenamePresent(clusterNode *n) {
return strlen(n->human_nodename); return sdslen(n->human_nodename);
} }
/* clusterLink send queue blocks */ /* clusterLink send queue blocks */