slipenkomk/valkey
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

luaRedisGenericCommand(): log error at WARNING level when re-entered.

Browse Source 
Rationale is that when re-entering, it is likely due to Lua debugging
hooks. Returning an error will be ignored in most cases, going totally
unnoticed. With the log at least we leave a trace.

Related to issue #2302.
This commit is contained in:
antirez 2015-01-20 23:20:12 +01:00
parent bc8675612f
commit e467cf5db3
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/scripting.c
View File

@ -221,8 +221,11 @@ int luaRedisGenericCommand(lua_State *lua, int raise_error) {
* To make this function reentrant is futile and makes it slower, but
* we should at least detect such a misuse, and abort. */
if (inuse) {
luaPushError(lua,
"luaRedisGenericCommand() recursive call detected. Are you doing funny stuff with Lua debug hooks?");
char *recursion_warning =
"luaRedisGenericCommand() recursive call detected. "
"Are you doing funny stuff with Lua debug hooks?";
redisLog(REDIS_WARNING,"%s",recursion_warning);
luaPushError(lua,recursion_warning);
return 1;
}
inuse++;