slipenkomk/valkey
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update rewriteConfigSaveOption function code to rewrite multiple save in one line. (#583)

Browse Source 
Currently, "config rewrite" writes some default value in the config file
incase of empty config file specified.

But it adds multiple "save" config entries as follows:
```
save 3600 1
save 300 100
save 60 10000
```

After the fix the save will look like:
```
save 3600 1 300 100 60 10000
```

---------

Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
This commit is contained in:
Shivshankar 2024-06-10 16:24:04 -04:00 committed by GitHub
parent a3f1535b57
commit e65b2d235c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/config.c
View File

@ -1367,11 +1367,11 @@ void rewriteConfigSaveOption(standardConfig *config, const char *name, struct re
if (!server.saveparamslen) {
rewriteConfigRewriteLine(state, name, sdsnew("save \"\""), 1);
} else {
line = sdsnew(name);
for (j = 0; j < server.saveparamslen; j++) {
line = sdscatprintf(sdsempty(), "save %ld %d", (long)server.saveparams[j].seconds,
server.saveparams[j].changes);
rewriteConfigRewriteLine(state, name, line, 1);
line = sdscatprintf(line, " %ld %d", (long)server.saveparams[j].seconds, server.saveparams[j].changes);
}
rewriteConfigRewriteLine(state, name, line, 1);
}
/* Mark "save" as processed in case server.saveparamslen is zero. */