tsarevvv/haproxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BUILD: init: use the more portable FD_CLOEXEC for /dev/null

Browse Source 
In 3.1-dev10, commit 8dd4efe42f ("MAJOR: mworker: move master-worker
fork in init()"), the FD associated to /dev/null was made CLOEXEC
using O_CLOEXEC. Unfortunately this is not portable on older OSes,
doesn't build on Solaris for example, and was even reported as breaking
moderately old Linux OSes for other projects. Better not use it unless
absolutely certain it will work (currently we only use it for Linux
namespaces, which are optional), and use the conventional FD_CLOEXEC
instead.

No backport is needed.
This commit is contained in:
Willy Tarreau 2024-11-25 08:43:25 +01:00
parent f0548302bb
commit a3613d239b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/haproxy.c
View File

@ -3920,11 +3920,16 @@ int main(int argc, char **argv)
/* End of initialization for standalone and worker modes */
if (!(global.mode & MODE_QUIET) || (global.mode & MODE_VERBOSE)) {
devnullfd = open("/dev/null", (O_RDWR | O_CLOEXEC), 0);
devnullfd = open("/dev/null", O_RDWR, 0);
if (devnullfd < 0) {
ha_alert("Cannot open /dev/null\n");
exit(EXIT_FAILURE);
}
if (fcntl(devnullfd, FD_CLOEXEC) != 0) {
ha_alert("Cannot make /dev/null CLOEXEC\n");
close(devnullfd);
exit(EXIT_FAILURE);
}
}
/* applies the renice value in the worker or standalone after configuration parsing