tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

validator: Raises warning if interfaces exceeds 1000 in single desire state

Browse Source 
Modified libnmstate/validator.py to raise warning if the interfaces exceeds 1000
in single desire state.

Github document page and man page updated, including interfaces limit in single desire state.

Signed-off-by: Arunagirinadan Sudharshan <sudhan.aruna.97@gmail.com>
This commit is contained in:
Arunagirinadan Sudharshan 2020-04-17 02:04:43 +05:30 committed by Gris Ge
parent 5879f67ac2
commit 18aca9a927
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -153,6 +153,8 @@ instructions.
Please refer to [jira page][jira_limitation] for details.
* Maximum supported number of interfaces in a single desire state is 1000.
## Changelog
Please refer to [CHANGELOG](CHANGELOG)

2
doc/nmstatectl.8.in
View File

@ -97,6 +97,8 @@ the user must commit the changes within \fItimeout\fR, or they will be
automatically rolled back. Default: 60 seconds.
.IP \fB--version
displays nmstate version.
.SH LIMITATIONS
*\fR Maximum supported number of interfaces in a single desire state is 1000.
.SH BUG REPORTS
Report bugs on nmstate GitHub issues <https://github.com/nmstate/nmstate>.
.SH COPYRIGHT

17
libnmstate/validator.py
View File

@ -51,6 +51,7 @@ IP_DISABLED_SLAVE_GETTERS = {
InterfaceType.LINUX_BRIDGE: get_slaves_from_state,
InterfaceType.TEAM: get_team_slaves,
}
MAX_SUPPORTED_INTERFACES = 1000
class NmstateRouteWithNoInterfaceError(NmstateValueError):
@ -75,6 +76,7 @@ class NmstateOvsLagValueError(NmstateValueError):
def validate(data, validation_schema=schema.ifaces_schema):
data = copy.deepcopy(data)
_validate_max_supported_intface_count(data)
for ifstate in data.get(schema.Interface.KEY, ()):
if not ifstate.get(schema.Interface.TYPE):
ifstate[schema.Interface.TYPE] = schema.InterfaceType.UNKNOWN
@ -462,3 +464,18 @@ def _validate_slave_ip_config(original_desired_state):
"IP configuration enabled"
)
raise NmstateValueError(msg.format(slave_iface_name))
def _validate_max_supported_intface_count(data):
"""
Raises warning if the interfaces count in the single desired state
exceeds the limit specified in MAX_SUPPORTED_INTERFACES
"""
num_of_interfaces = len(
[intface for intface in data.get(schema.Interface.KEY, ())]
)
if num_of_interfaces > MAX_SUPPORTED_INTERFACES:
logging.warning(
"Interfaces count exceeds the limit %s in desired state",
MAX_SUPPORTED_INTERFACES,
)