tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cmdlib: add check in exec_cmd()

Browse Source 
This patch introduces check parameter in exec_cmd(). This would arise a
subprocess.CalledProcessError exception if the return code is not zero.

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
This commit is contained in:
Fernando Fernandez Mancera 2020-02-11 17:31:03 +01:00 committed by Till Maas
parent 8aba09ef64
commit 3a6d116a5e
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/integration/testlib/cmdlib.py
View File

@ -25,7 +25,7 @@ RC_SUCCESS = 0
RC_FAIL2 = 2
def exec_cmd(cmd, env=None, stdin=None):
def exec_cmd(cmd, env=None, stdin=None, check=False):
"""
Execute cmd in an external process, collect its output and returncode
@ -39,16 +39,18 @@ def exec_cmd(cmd, env=None, stdin=None):
"""
logging.debug(command_log_line(cmd))
p = subprocess.Popen(
p = subprocess.run(
cmd,
close_fds=True,
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
env=env,
check=check,
input=stdin,
)
out, err = p.communicate(stdin)
out = p.stdout
err = p.stderr
logging.debug(_retcode_log_line(p.returncode, err=err))