tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ActiveConnection: Use ActiveConnection.devname

Browse Source 
Use `ActiveConnection.devname` in logging to avoid potential Tracebacks
in case `ActiveConnection._devname` is not initialized.

Signed-off-by: Till Maas <opensource@till.name>
This commit is contained in:
Till Maas 2020-02-25 09:34:36 +01:00
parent 1884c1d28c
commit 612bcf5fad
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libnmstate/nm/active_connection.py
View File

@ -86,7 +86,7 @@ class ActiveConnection:
if self._mainloop.is_action_canceled(e):
logging.debug(
"Connection deactivation aborted on %s: error=%s",
self._nmdev.get_iface(),
self.devname,
e,
)
else:
@ -105,20 +105,19 @@ class ActiveConnection:
else:
self._mainloop.quit(
"Connection deactivation failed on {}: "
"error={}".format(self._nmdev.get_iface(), e)
"error={}".format(self.devname, e)
)
return
if success:
logging.debug(
"Connection deactivation succeeded on %s",
self._nmdev.get_iface(),
"Connection deactivation succeeded on %s", self.devname,
)
self._mainloop.execute_next_action()
else:
self._mainloop.quit(
"Connection deactivation failed on %s: error=unknown"
% self._nmdev.get_iface()
% self.devname
)
@property