tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nm: Sort activation in alphabet order explicitly

Browse Source 
The activation order on bridge/bond ports determins their controler's
MAC address. The default NetworkManager is using alphabet order on
boot. So we should to do the same on profile activation.

Previously, the `libnmstate.show()` provides the sorted interface list.
And the `Ifaces.all_iface()` dictionary is using the inserting order.
So we have the activation sorted in alphabet order implicitly.

This patch is fixing nothing, just do the activation sorting explicitly.

Signed-off-by: Gris Ge <fge@redhat.com>
This commit is contained in:
Gris Ge 2021-06-02 22:46:17 +08:00 committed by Fernando Fernández Mancera
parent 57f97403c7
commit 7b9de8d3f5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libnmstate/nm/profiles.py
View File

@ -21,6 +21,7 @@
# * Actions required the knownldege of multiple NmProfile
import logging
from operator import attrgetter
from libnmstate.schema import InterfaceType
@ -58,9 +59,14 @@ class NmProfiles:
def apply_config(self, net_state, save_to_disk):
self._prepare_state_for_profiles(net_state)
# The activation order on bridge/bond ports determins their controler's
# MAC address. The default NetworkManager is using alphabet order on
# boot. So we should to the same here.
all_profiles = [
NmProfile(self._ctx, iface)
for iface in net_state.ifaces.all_ifaces()
for iface in sorted(
list(net_state.ifaces.all_ifaces()), key=attrgetter("name")
)
]
for profile in all_profiles: