tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nm, connection: Remove logging of connection settings

Browse Source 
Logging the connection settings is no longer useful for debugging in
most cases.
These loggings are remove to make the log easier to read and examine.

```
root:connection.py:463 Connection settings for ConnectionSetting.create:
  id: ovs-br0
  iface: ovs-br0
  uuid: 6db09d43-d0a9-4a05-bc91-2a7d0a50bd91
  type: ovs-bridge
  autoconnect: True
  autoconnect_slaves: <enum NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES_YES
                       of type NM.SettingConnectionAutoconnectSlaves>
root:connection.py:463 Connection settings for ConnectionSetting.create:
  id: ovs0
  iface: ovs0
  uuid: 9df82a54-1573-4195-81d5-eb361837b568
  type: ovs-interface
  autoconnect: True
  autoconnect_slaves: <enum NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES_YES
                       of type NM.SettingConnectionAutoconnectSlaves>
root:connection.py:463 Connection settings for ConnectionSetting.create:
  id: ovs-port-ovs0
  iface: ovs0
  uuid: dd810f8c-a12e-435e-b02e-451c0c73fc9e
  type: ovs-port
  autoconnect: True
  autoconnect_slaves: <enum NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES_YES
                       of type NM.SettingConnectionAutoconnectSlaves>
```

Signed-off-by: Edward Haas <edwardh@redhat.com>
This commit is contained in:
Edward Haas 2020-01-26 12:25:29 +02:00
parent 32924333cf
commit 7e05f0f93a
1 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
libnmstate/nm/connection.py
View File

@ -416,7 +416,6 @@ class ConnectionSetting:
)
self._setting = con_setting
self._log_connection_info("ConnectionSetting.create")
def import_by_profile(self, con_profile):
base = con_profile.profile.get_setting_connection()
@ -429,7 +428,6 @@ class ConnectionSetting:
new.props.autoconnect_slaves = base.props.autoconnect_slaves
self._setting = new
self._log_connection_info("ConnectionSetting.import_by_profile")
def set_master(self, master, slave_type):
if master is not None:
@ -440,29 +438,6 @@ class ConnectionSetting:
def setting(self):
return self._setting
def _log_connection_info(self, source):
setting = self._setting
logging.debug(
"Connection settings for %s:\n"
+ "\n".join(
[
"id: %s",
"iface: %s",
"uuid: %s",
"type: %s",
"autoconnect: %s",
"autoconnect_slaves: %s",
]
),
source,
setting.props.id,
setting.props.interface_name,
setting.props.uuid,
setting.props.type,
setting.props.autoconnect,
setting.props.autoconnect_slaves,
)
def get_device_active_connection(nm_device):
active_conn = None