tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: update outdated xfails

Browse Source 
This patch is updating xfails, adding `strict=True` and wrong reasons.

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
This commit is contained in:
Fernando Fernandez Mancera 2020-06-19 19:49:25 +02:00 committed by Gris Ge
parent 7cac69b47f
commit 8b29c48bd2
5 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/integration/dynamic_ip_test.py
View File

@ -581,7 +581,7 @@ def test_slave_ipaddr_learned_via_dhcp_added_as_static_to_linux_bridge(
assertlib.assert_state_match(state)
@pytest.mark.xfail(raises=NmstateNotImplementedError)
@pytest.mark.xfail(raises=NmstateNotImplementedError, strict=True)
def test_ipv6_autoconf_only(dhcpcli_up):
desired_state = dhcpcli_up
dhcp_cli_desired_state = desired_state[Interface.KEY][0]

4
tests/integration/iface_admin_state_test.py
View File

@ -45,7 +45,9 @@ def test_set_a_down_iface_down(eth1_up):
assertlib.assert_state(desired_state)
@pytest.mark.xfail(reason="Some ifaces cannot be removed", strict=True)
@pytest.mark.xfail(
raises=AssertionError, reason="Some ifaces cannot be removed", strict=True,
)
def test_removing_a_non_removable_iface(eth1_up):
desired_state = {
Interface.KEY: [

4
tests/integration/route_test.py
View File

@ -134,7 +134,9 @@ def test_add_route_without_table_id(eth1_up):
@pytest.mark.xfail(
raises=NmstateNotImplementedError, reason="Red Hat Bug 1707396"
raises=NmstateNotImplementedError,
reason="https://bugzilla.redhat.com/1707396",
strict=True,
)
def test_multiple_gateway(eth1_up):
libnmstate.apply(

3
tests/integration/vxlan_test.py
View File

@ -95,9 +95,6 @@ def test_set_vxlan_iface_down(eth1_up):
assertlib.assert_absent(vxlan.name)
@pytest.mark.xfail(
reason="https://bugzilla.redhat.com/show_bug.cgi?id=1772382", strict=False
)
def test_add_new_bond_iface_with_vxlan(eth1_up):
eth_name = eth1_up[Interface.KEY][0][Interface.NAME]
bond_name = "bond1"

4
tests/lib/nm/route_test.py
View File

@ -212,7 +212,7 @@ def test_change_gateway(nm_ip, routes, gateways):
@pytest.mark.xfail(
raises=NmstateNotImplementedError,
strict=True,
reason="Network Manager Bug: " "https://bugzilla.redhat.com/1707396",
reason="Network Manager Bug: https://bugzilla.redhat.com/1707396",
)
@parametrize_ip_ver_routes_gw
def test_add_two_gateway(nm_ip, routes, gateways):
@ -228,7 +228,7 @@ def test_add_two_gateway(nm_ip, routes, gateways):
@pytest.mark.xfail(
raises=NmstateNotImplementedError,
strict=True,
reason="Network Manager Bug: " "https://bugzilla.redhat.com/1707396",
reason="Network Manager Bug: https://bugzilla.redhat.com/1707396",
)
@parametrize_ip_ver_routes_gw
def test_add_duplicate_gateways(nm_ip, routes, gateways):