tsarevvv/nmstate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nm/checkpoint: Handle NULL NM.Device when rollback

Browse Source 
The covscan report an error:

 nmstate-0.3.1/libnmstate/nm/checkpoint.py:216: property_access:
 Accessing a property of null-like value "nm_dev".

Fixed by checking whether NM.Device is valid.

Signed-off-by: Gris Ge <fge@redhat.com>
This commit is contained in:
Gris Ge 2020-06-11 17:22:33 +08:00
parent 4446febee3
commit 99d2974182
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libnmstate/nm/checkpoint.py
View File

@ -213,10 +213,13 @@ class CheckPoint:
for path in ret:
nm_dev = client.get_device_by_path(path)
iface = path if nm_dev is None else nm_dev.get_iface()
if (
nm_dev.get_state_reason()
== common.NM.DeviceStateReason.NEW_ACTIVATION
) or nm_dev.get_state() == common.NM.DeviceState.IP_CONFIG:
if nm_dev and (
(
nm_dev.get_state_reason()
== common.NM.DeviceStateReason.NEW_ACTIVATION
)
or nm_dev.get_state() == common.NM.DeviceState.IP_CONFIG
):
nm_ac = nm_dev.get_active_connection()
if not is_activated(nm_ac, nm_dev):
profile = connection.ConnectionProfile(self._ctx)