tsarevvv/proxmox-backup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client: task log: only encode upid once

Browse Source 
Instead of percent-encoding the UPID on every loop iteration plus on
abort, just encode it once before entering the loop.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This commit is contained in:
Thomas Lamprecht 2023-01-19 10:38:15 +01:00
parent 158db8c01f
commit 22fc132a73
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pbs-client/src/task_log.rs
View File

@ -46,14 +46,13 @@ pub async fn display_task_log(
let mut start = 1;
let limit = 500;
let upid_encoded = percent_encode_component(upid_str);
loop {
let abort = abort_count.load(Ordering::Relaxed);
if abort > 0 {
if forward_interrupt {
let path = format!(
"api2/json/nodes/localhost/tasks/{}",
percent_encode_component(upid_str)
);
let path = format!("api2/json/nodes/localhost/tasks/{upid_encoded}");
let _ = client.delete(&path, None).await?;
} else {
return Ok(());
@ -62,10 +61,7 @@ pub async fn display_task_log(
let param = json!({ "start": start, "limit": limit, "test-status": true });
let path = format!(
"api2/json/nodes/localhost/tasks/{}/log",
percent_encode_component(upid_str)
);
let path = format!("api2/json/nodes/localhost/tasks/{upid_encoded}/log");
let result = client.get(&path, Some(param)).await?;
let active = result["active"].as_bool().unwrap();