diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs index a0cf50b20..116d2441a 100644 --- a/src/backup/datastore.rs +++ b/src/backup/datastore.rs @@ -825,4 +825,42 @@ impl DataStore { pub fn verify_new(&self) -> bool { self.verify_new } + + /// returns a list of chunks sorted by their inode number on disk + /// chunks that could not be stat'ed are at the end of the list + pub fn get_chunks_in_order( + &self, + index: &Box, + skip_chunk: F, + check_abort: A, + ) -> Result, Error> + where + F: Fn(&[u8; 32]) -> bool, + A: Fn(usize) -> Result<(), Error>, + { + let index_count = index.index_count(); + let mut chunk_list = Vec::with_capacity(index_count); + use std::os::unix::fs::MetadataExt; + for pos in 0..index_count { + check_abort(pos)?; + + let info = index.chunk_info(pos).unwrap(); + + if skip_chunk(&info.digest) { + continue; + } + + let ino = match self.stat_chunk(&info.digest) { + Err(_) => u64::MAX, // could not stat, move to end of list + Ok(metadata) => metadata.ino(), + }; + + chunk_list.push((pos, ino)); + } + + // sorting by inode improves data locality, which makes it lots faster on spinners + chunk_list.sort_unstable_by(|(_, ino_a), (_, ino_b)| ino_a.cmp(&ino_b)); + + Ok(chunk_list) + } } diff --git a/src/backup/verify.rs b/src/backup/verify.rs index 1a51d3fb4..503a404b2 100644 --- a/src/backup/verify.rs +++ b/src/backup/verify.rs @@ -179,42 +179,18 @@ fn verify_index_chunks( } }; - let index_count = index.index_count(); - let mut chunk_list = Vec::with_capacity(index_count); - - use std::os::unix::fs::MetadataExt; - - for pos in 0..index_count { + let check_abort = |pos: usize| -> Result<(), Error> { if pos & 1023 == 0 { verify_worker.worker.check_abort()?; crate::tools::fail_on_shutdown()?; } + Ok(()) + }; - let info = index.chunk_info(pos).unwrap(); - - if skip_chunk(&info.digest) { - continue; // already verified or marked corrupt - } - - match verify_worker.datastore.stat_chunk(&info.digest) { - Err(err) => { - verify_worker.corrupt_chunks.lock().unwrap().insert(info.digest); - task_log!(verify_worker.worker, "can't verify chunk, stat failed - {}", err); - errors.fetch_add(1, Ordering::SeqCst); - rename_corrupted_chunk( - verify_worker.datastore.clone(), - &info.digest, - &verify_worker.worker, - ); - } - Ok(metadata) => { - chunk_list.push((pos, metadata.ino())); - } - } - } - - // sorting by inode improves data locality, which makes it lots faster on spinners - chunk_list.sort_unstable_by(|(_, ino_a), (_, ino_b)| ino_a.cmp(&ino_b)); + let chunk_list = + verify_worker + .datastore + .get_chunks_in_order(&index, skip_chunk, check_abort)?; for (pos, _) in chunk_list { verify_worker.worker.check_abort()?;