ui: prune/gc view: improve sizing & scrolling behaviour
before, this was only used where the top list was a fixed size and only for one datastore (which limits the number of prune jobs a bit) since now we show gc jobs for all datastores here too and all their prune jobs, this panel can get much bigger. To improve it's scrolling sizing behavior, make the prune jobs panel `flex: 1`, so it fills out the rest of the view, and add a splitter between them so one can resize them on the fly. To prevent making one of the panels too small, set an appropriate minHeight for both and make the surrounding panel scrollable. To not save the height into it's state, we have to filter that out for the GCView. Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
parent
ea14e2bb09
commit
7a23a7ca5d
@ -107,6 +107,10 @@ Ext.define('PBS.config.GCJobView', {
|
|||||||
stopStore: function() { this.getView().getStore().rstore.stopUpdate(); },
|
stopStore: function() { this.getView().getStore().rstore.stopUpdate(); },
|
||||||
reload: function() { this.getView().getStore().rstore.load(); },
|
reload: function() { this.getView().getStore().rstore.load(); },
|
||||||
|
|
||||||
|
|
||||||
|
filterState: function(view, state) {
|
||||||
|
delete state.height;
|
||||||
|
},
|
||||||
},
|
},
|
||||||
|
|
||||||
listeners: {
|
listeners: {
|
||||||
@ -114,6 +118,7 @@ Ext.define('PBS.config.GCJobView', {
|
|||||||
beforedestroy: 'stopStore',
|
beforedestroy: 'stopStore',
|
||||||
deactivate: 'stopStore',
|
deactivate: 'stopStore',
|
||||||
itemdblclick: 'editGCJob',
|
itemdblclick: 'editGCJob',
|
||||||
|
beforestatesave: 'filterState',
|
||||||
},
|
},
|
||||||
|
|
||||||
store: {
|
store: {
|
||||||
|
@ -14,6 +14,7 @@ Ext.define('PBS.config.PruneAndGC', {
|
|||||||
collapsible: false,
|
collapsible: false,
|
||||||
margin: '7 10 3 10',
|
margin: '7 10 3 10',
|
||||||
},
|
},
|
||||||
|
scrollable: true,
|
||||||
items: [
|
items: [
|
||||||
{
|
{
|
||||||
xtype: 'pbsGCJobView',
|
xtype: 'pbsGCJobView',
|
||||||
@ -22,6 +23,11 @@ Ext.define('PBS.config.PruneAndGC', {
|
|||||||
cbind: {
|
cbind: {
|
||||||
datastore: '{datastore}',
|
datastore: '{datastore}',
|
||||||
},
|
},
|
||||||
|
minHeight: 125, // shows at least one line of content
|
||||||
|
},
|
||||||
|
{
|
||||||
|
xtype: 'splitter',
|
||||||
|
performCollapse: false,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
xtype: 'pbsPruneJobView',
|
xtype: 'pbsPruneJobView',
|
||||||
@ -30,12 +36,14 @@ Ext.define('PBS.config.PruneAndGC', {
|
|||||||
cbind: {
|
cbind: {
|
||||||
datastore: '{datastore}',
|
datastore: '{datastore}',
|
||||||
},
|
},
|
||||||
|
flex: 1,
|
||||||
|
minHeight: 160, // shows at least one line of content
|
||||||
},
|
},
|
||||||
],
|
],
|
||||||
initComponent: function() {
|
initComponent: function() {
|
||||||
let me = this;
|
let me = this;
|
||||||
|
|
||||||
let subPanelIds = me.items.map(el => el.itemId);
|
let subPanelIds = me.items.map(el => el.itemId).filter(id => !!id);
|
||||||
|
|
||||||
me.callParent();
|
me.callParent();
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user